Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormRecognizer] Should DocumentStyle.IsHandwritten be non-nullable? #24347

Closed
kinelski opened this issue Sep 30, 2021 · 1 comment
Closed

[FormRecognizer] Should DocumentStyle.IsHandwritten be non-nullable? #24347

kinelski opened this issue Sep 30, 2021 · 1 comment
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Milestone

Comments

@kinelski
Copy link
Member

Currently, DocumentStyle is only used for detecting handwritten text. Should the IsHandwritten property be non-nullable then? Or, if returned null, should we default to false?

@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer labels Sep 30, 2021
@kinelski kinelski added this to the [2021] November milestone Sep 30, 2021
@jsquire jsquire modified the milestones: [2021] November, Backlog Nov 18, 2021
@kinelski kinelski modified the milestones: Backlog, [2022] July Jun 21, 2022
@kinelski kinelski added the blocking-release Blocks release label Jun 21, 2022
@kinelski
Copy link
Member Author

The service team confirmed that when the handwritten property is not returned, no assumptions can be made (we cannot default it to true or false in the SDK). In the future, multiple styles could be returned for a single span. One style could contain the handwritten property, and others would contain other pieces of information (bold, color, etc) while keeping the handwritten property null.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Development

No branches or pull requests

2 participants