Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy iothub connection string sample into smoke test arm template #17758

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

benbp
Copy link
Member

@benbp benbp commented Jan 5, 2021

This is a temporary fix for an issue that causes frequent failures in the smoke tests for azure china cloud. The smoke test test-resources.json ARM template uses a template link which tries to download from github.com. This often fails:

 "message": "Unable to download deployment content from 'https://raw.githubusercontent.com/Azure/azure-sdk-for-net/master/samples/iothub-connect-to-eventhubs/sample-resources.json'. 
The tracking Id is '8bc97f2c-776d-4e04-9518-d92cc78ac6c0'. Please see https://aka.ms/arm-deploy for usage details."

The fix involves copying the linked template into the smoke test template. There is an outstanding feature to add file link support in ARM templates (here). Once that is completed, we can remove this inline update.

Related discussion: #17524 (comment)
Issue to remove this update: #17757

@check-enforcer
Copy link

check-enforcer bot commented Jan 5, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

@benbp
Copy link
Member Author

benbp commented Jan 5, 2021

/check-enforcer override

@benbp benbp merged commit fcc2766 into master Jan 5, 2021
@benbp benbp deleted the benbp/iot-samples-template-copy branch January 5, 2021 21:29
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants