Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file linked ARM template for iothub samples #17757

Closed
benbp opened this issue Jan 5, 2021 · 3 comments
Closed

Use file linked ARM template for iothub samples #17757

benbp opened this issue Jan 5, 2021 · 3 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@benbp
Copy link
Member

benbp commented Jan 5, 2021

The smoke tests frequently fail when run against Azure China Cloud, because they use a URI linked ARM template and fail to download a file from github. A temporary fix has been put up to embed the linked template in the smoke test template, but there is an outstanding feature to add support for file linking instead. This is a tracking issue to remove the embedded template once that is rolled out.

File URI feature: microsoft/vscode-azurearmtools#588
Dev tracking issue: microsoft/vscode-azurearmtools#1116
Related discussion: #17524 (comment)

Passing run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=672835&view=results

@benbp benbp added Central-EngSys This issue is owned by the Engineering System team. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jan 5, 2021
@benbp benbp self-assigned this Jan 5, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 5, 2021
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Mar 12, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

Hi @benbp. There hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by removing the no-recent-activity label. Otherwise, we'll close this out in 7 days.

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label Mar 13, 2021
@ghost
Copy link

ghost commented Mar 13, 2021

Hi @benbp. There was a mistake and this issue was unintentionally flagged as a stale pull request. The label has been removed and the issue will remain active; no action is needed on your part. Apologies for the inconvenience.

@jsquire
Copy link
Member

jsquire commented Oct 11, 2022

Closing; the IoT sample that used this template is no longer part of the smoke tests.

@jsquire jsquire closed this as completed Oct 11, 2022
Repository owner moved this from 🤔Triage to 🎊Closed in Azure SDK EngSys 🚢🎉 Oct 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

No branches or pull requests

2 participants