Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are redundancy comment? #21637

Closed
paul-cheung opened this issue Jun 6, 2021 · 4 comments · Fixed by Azure/azure-rest-api-specs#18407 or Azure/azure-sdk-for-python#23700
Closed

Why are redundancy comment? #21637

paul-cheung opened this issue Jun 6, 2021 · 4 comments · Fixed by Azure/azure-rest-api-specs#18407 or Azure/azure-sdk-for-python#23700
Assignees
@RakeshMohanMSFT
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Network - Front Door Service: Azure Front Door question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service.

Comments

@paul-cheung
Copy link
Contributor

azure-sdk-for-net/sdk/frontdoor/Microsoft.Azure.Management.FrontDoor/src/Generated/Models/AzureAsyncOperationResult.cs

Line 41 in 012db17

/// values include: 'InProgress', 'Succeeded', 'Failed'</param>

I mean why the comment has the comment someting like "Possible values are" and "Possible values include" meanwhile.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 6, 2021
@jsquire jsquire added Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Network - Front Door Service: Azure Front Door Service Attention Workflow: This issue is responsible by Azure service team. labels Jun 7, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 7, 2021
@ghost
Copy link

ghost commented Jun 7, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @cdnfdsuppgithub.

Issue Details

azure-sdk-for-net/sdk/frontdoor/Microsoft.Azure.Management.FrontDoor/src/Generated/Models/AzureAsyncOperationResult.cs

Line 41 in 012db17

/// values include: 'InProgress', 'Succeeded', 'Failed'</param>

I mean why the comment has the comment someting like "Possible values are" and "Possible values include" meanwhile.

Author: paul-cheung
Assignees: -
Labels:

Mgmt, Network - Front Door, Service Attention, customer-reported, needs-team-attention, needs-triage, question
Milestone: -

@jsquire jsquire added Service This issue points to a problem in the service. and removed Mgmt This issue is related to a management-plane library. labels Jun 7, 2021
@jsquire
Copy link
Member

jsquire commented Jun 7, 2021 •
edited
Loading

Since this appears in a generated class, the comment is sourced from the service Swagger directly and would need to be updated there.

@jsquire
Copy link
Member

jsquire commented Jun 7, 2021

Thank you for your feedback. Tagging and routing to the team best able to assist.

@paul-cheung
Copy link
Contributor Author

Since this appears in a generated class, the comment is sourced from the service Swagger directly and would need to be updated there.

yeah, I think so, it was from Azure service that generated the swagger the SDK team using.

RakeshMohanMSFT added a commit to Azure/azure-sdk-for-go that referenced this issue Mar 23, 2022
@RakeshMohanMSFT
{Azure-sdk-for-go} fixing redundant documentation
b7be14c 
Fixes Azure/azure-sdk-for-net#21637
@RakeshMohanMSFT RakeshMohanMSFT mentioned this issue Mar 23, 2022
Closed
5 tasks
RakeshMohanMSFT added a commit to Azure/azure-sdk-for-go that referenced this issue Mar 25, 2022
@RakeshMohanMSFT
{Update frontdoor} fixing redundant documentation
3f669bb 
Fixes Azure/azure-sdk-for-net#21637
@RakeshMohanMSFT RakeshMohanMSFT mentioned this issue Mar 25, 2022
Closed
5 tasks
RakeshMohanMSFT added a commit to Azure/azure-rest-api-specs that referenced this issue Mar 25, 2022
@RakeshMohanMSFT
Update {azure-rest-api-specs}
9b5127b 
Fixes Azure/azure-sdk-for-net#21637
@RakeshMohanMSFT RakeshMohanMSFT mentioned this issue Mar 25, 2022
Merged
25 tasks
ArcturusZhang pushed a commit to Azure/azure-rest-api-specs that referenced this issue Mar 25, 2022
@RakeshMohanMSFT
Update {azure-rest-api-specs} (#18407)
6121842 
Fixes Azure/azure-sdk-for-net#21637
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-resource-manager-schemas that referenced this issue Mar 25, 2022
CodeGen from PR 18407 in Azure/azure-rest-api-specs
45bbf5f 
Update {azure-rest-api-specs} (#18407)

Fixes Azure/azure-sdk-for-net#21637
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Mar 25, 2022
CodeGen from PR 18407 in Azure/azure-rest-api-specs
c7f3df3 
Update {azure-rest-api-specs} (Azure#18407)

Fixes Azure/azure-sdk-for-net#21637
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 25, 2022
CodeGen from PR 18407 in Azure/azure-rest-api-specs
e3391de 
Update {azure-rest-api-specs} (Azure#18407)

Fixes Azure/azure-sdk-for-net#21637
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Mar 25, 2022
CodeGen from PR 18407 in Azure/azure-rest-api-specs
64d5348 
Update {azure-rest-api-specs} (Azure#18407)

Fixes Azure#21637
RakeshMohanMSFT pushed a commit that referenced this issue Mar 25, 2022
@RakeshMMSFT
Regenerated AzureAsyncOperationResults.cs to fix #21637
9499660
HarveyLink pushed a commit that referenced this issue Mar 25, 2022
@RakeshMohanMSFT
Regenerated AzureAsyncOperationResults.cs to fix #21637 (#27750)
72c1b5f
HarveyLink pushed a commit that referenced this issue Mar 25, 2022
@RakeshMohanMSFT
{azure-sdk-for-net} Updating version to get a release (#27756)
067f2de 
* Regenerated AzureAsyncOperationResults.cs to fix #21637

* Updating the version in order to get release
RakeshMohanMSFT added a commit to Azure/azure-sdk-for-python that referenced this issue Mar 28, 2022
@RakeshMohanMSFT
{Update frontdoor} fixing redundant documentation
a929ec0 
Fixes Azure/azure-sdk-for-net#21637
@RakeshMohanMSFT RakeshMohanMSFT mentioned this issue Mar 28, 2022
Merged
6 tasks
msyyc pushed a commit to Azure/azure-sdk-for-python that referenced this issue Mar 28, 2022
@RakeshMohanMSFT
{Update frontdoor} fixing redundant documentation (#23700)
ef06226 
Fixes Azure/azure-sdk-for-net#21637
visingl pushed a commit to Azure/azure-rest-api-specs that referenced this issue Mar 30, 2022
@RakeshMohanMSFT @visingl
Update {azure-rest-api-specs} (#18407)
f74f629 
Fixes Azure/azure-sdk-for-net#21637
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this issue Apr 7, 2022
@RakeshMohanMSFT @rakshith91
{Update frontdoor} fixing redundant documentation (Azure#23700)
46c3e94 
Fixes Azure/azure-sdk-for-net#21637
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this issue Apr 10, 2022
@RakeshMohanMSFT @rakshith91
{Update frontdoor} fixing redundant documentation (Azure#23700)
0041190 
Fixes Azure/azure-sdk-for-net#21637
@RakeshMohanMSFT RakeshMohanMSFT self-assigned this Apr 19, 2022
FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this issue May 16, 2022
@RakeshMohanMSFT @FredericHeem
Update {azure-rest-api-specs} (Azure#18407)
db517da 
Fixes Azure/azure-sdk-for-net#21637
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RakeshMohanMSFT RakeshMohanMSFT

Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Network - Front Door Service: Azure Front Door question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service.
Projects
None yet
Milestone
No milestone
3 participants
@jsquire @paul-cheung @RakeshMohanMSFT