Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Microsoft.Azure.Management.ApiManagement UserOperations CreateOrUpdate does not contain notify parameter #18407

Closed
xakpc opened this issue Feb 4, 2021 · 7 comments
Closed

[BUG] Microsoft.Azure.Management.ApiManagement UserOperations CreateOrUpdate does not contain notify parameter #18407

xakpc opened this issue Feb 4, 2021 · 7 comments
Labels
API Management customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@xakpc
Copy link

xakpc commented Feb 4, 2021

Describe the bug
According to documentation ApiManagement.UserOperations.CreateOrUpdate must contain notify parameter which should trigger welcome email.

This parameter is missing in the latest version of Microsoft.Azure.Management.ApiManagement package

Expected behavior
I expect to be able to pass notify parameter to apiManagement.User.CreateOrUpdateAsync

Actual behavior (include Exception or Stack Trace)
There is no such parameter in apiManagement.User.CreateOrUpdateAsync

To Reproduce
Steps to reproduce the behavior (include a code snippet, screenshot, or any additional information that might help us reproduce the issue)

  1. Install package Microsoft.Azure.Management.ApiManagement -Version 6.0.0-preview
  2. Create ApiManagementClient
  3. Check apiManagement.User.CreateOrUpdateAsync

Environment:

  • Name and version of the Library package used: Microsoft.Azure.Management.ApiManagement -Version 6.0.0-preview
  • dotnet
    Version: 5.0.200-preview.20601.7
    Commit: b3b934bbf2
    OS Name: Windows
    OS Version: 10.0.19041
    OS Platform: Windows
  • IDE and version: Visual Studio 16.3
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 4, 2021
@Mohit-Chakraborty Mohit-Chakraborty added the Mgmt This issue is related to a management-plane library. label Feb 4, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 4, 2021
@Mohit-Chakraborty
Copy link
Contributor

Thank you for your feedback. Tagging and routing to the team best able to assist.

@allenjzhang
Copy link
Member

allenjzhang commented Apr 9, 2021 •
edited
Loading

@pakrym , looks like notify query parameter was not generated on neither OperationExtension nor Operation. Do we have a bug on track 1 codegen?

@pakrym
Copy link
Contributor

pakrym commented Apr 9, 2021

I don't think the library was re-generated after Azure/azure-rest-api-specs#10122 went in.

@allenjzhang
Copy link
Member

@vfedonkin, please regenerate SDK to incorporate new swagger changes. Thx.

@allenjzhang allenjzhang added the Service Attention Workflow: This issue is responsible by Azure service team. label Apr 26, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Apr 26, 2021
@ghost
Copy link

ghost commented Apr 26, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @miaojiang.

Issue Details

Describe the bug
According to documentation ApiManagement.UserOperations.CreateOrUpdate must contain notify parameter which should trigger welcome email.

This parameter is missing in the latest version of Microsoft.Azure.Management.ApiManagement package

Expected behavior
I expect to be able to pass notify parameter to apiManagement.User.CreateOrUpdateAsync

Actual behavior (include Exception or Stack Trace)
There is no such parameter in apiManagement.User.CreateOrUpdateAsync

To Reproduce
Steps to reproduce the behavior (include a code snippet, screenshot, or any additional information that might help us reproduce the issue)

  1. Install package Microsoft.Azure.Management.ApiManagement -Version 6.0.0-preview
  2. Create ApiManagementClient
  3. Check apiManagement.User.CreateOrUpdateAsync

Environment:

  • Name and version of the Library package used: Microsoft.Azure.Management.ApiManagement -Version 6.0.0-preview
  • dotnet
    Version: 5.0.200-preview.20601.7
    Commit: b3b934bbf2
    OS Name: Windows
    OS Version: 10.0.19041
    OS Platform: Windows
  • IDE and version: Visual Studio 16.3
Author: xakpc
Assignees: -
Labels:

API Management, Mgmt, Service Attention, customer-reported, needs-team-attention, question
Milestone: -

@ArthurMa1978 ArthurMa1978 added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Dec 28, 2021
@ghost
Copy link

ghost commented Dec 28, 2021

Hi @xakpc. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@ghost ghost removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Dec 28, 2021
@ghost
Copy link

ghost commented Jan 4, 2022

Hi @xakpc, since you haven’t asked that we “/unresolve” the issue, we’ll close this out. If you believe further discussion is needed, please add a comment “/unresolve” to reopen the issue.

@ghost ghost closed this as completed Jan 4, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Mar 25, 2022
CodeGen from PR 18407 in Azure/azure-rest-api-specs
64d5348 
Update {azure-rest-api-specs} (Azure#18407)

Fixes Azure#21637
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
API Management customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pakrym @xakpc @Mohit-Chakraborty @allenjzhang @ArthurMa1978