Pin dependencies and add emitter-package-lock.json lockfile #26200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
requested review from
ckairen,
mikeharder,
weshaggard and
benbp
as code owners
MaryGao
commented
Jun 14, 2023
mikeharder
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
The changes to emitter-package.json look good to me.
Unfortunately, I don't think the emitter-package-lock.json will currently be used. The scripts only copy emitter-package.json, and also call npm install --no-lock-file which would ignore the lockfile even if it were copied.
So you can either omit the emitter-package-lock.json file for now, or add it but know it will be ignored until TypeSpecProject-Generate.ps1 is updated to respect the lockfile.
I will open an issue for TypeSpecProject-Generate.ps1 to respect the lockfile.
|
Actually I would go ahead and merge the lockfile now. The lockfile will need to be added to all language repos before the script can be update to use the lockfile. |
mikeharder
requested changes
Jun 15, 2023
mikeharder
approved these changes
Jun 15, 2023
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Oct 12, 2023
[TypeSpec] Upgrade to 0.49.0 (Azure#26200)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin dependencies and add emitter-package-lock.json lockfile
fixes #26197
fixes #26198