-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the emitter version to latest #26129
Conversation
/check-enforcer override |
@@ -1,7 +1,6 @@ | |||
{ | |||
"main": "dist/src/index.js", | |||
"dependencies": { | |||
"@azure-tools/typespec-ts": "0.13.0", | |||
"@typespec/versioning": "0.44.0" | |||
"@azure-tools/typespec-ts": "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have been trying to avoid using tags here as they tend to break things. Is there a plan to ensure publishing a new version doesn't break existing consumers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use ^.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weshaggard Sorry for the late response. Simply speaking, I don't think pin to any version could avoid to break existing consumers considering the emitter uses peerDependencies with range which would always fetch the latest peer dependencies.
- If these breakings are introduced from underlying dependencies for example typespec compiler, and break the emitter and finally break our end users, then upgrading to the latest emitter would work;
- If these breakings are introduced by emitter for example the supported feature surfaces change, then encuraging users to use the latest would be recommanded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for info, pinning all packages would make sense to me.
@mikeharder I can take these, just double confirm the emitter-package-lock.json
would be treated as package-lock.json
alongside package.json
, Right?
PR is here: #26200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the emitter version to latest
Update the emitter version to latest
Update the emitter version to latest