Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the emitter version to latest #26129

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Update the emitter version to latest #26129

merged 1 commit into from
Jun 7, 2023

Conversation

MaryGao
Copy link
Member

@MaryGao MaryGao commented Jun 7, 2023

Update the emitter version to latest

@MaryGao
Copy link
Member Author

MaryGao commented Jun 7, 2023

/check-enforcer override

@MaryGao MaryGao merged commit 4dae449 into main Jun 7, 2023
@MaryGao MaryGao deleted the bump-version branch June 7, 2023 08:48
@@ -1,7 +1,6 @@
{
"main": "dist/src/index.js",
"dependencies": {
"@azure-tools/typespec-ts": "0.13.0",
"@typespec/versioning": "0.44.0"
"@azure-tools/typespec-ts": "latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been trying to avoid using tags here as they tend to break things. Is there a plan to ensure publishing a new version doesn't break existing consumers?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use ^.

Copy link
Member Author

@MaryGao MaryGao Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshaggard Sorry for the late response. Simply speaking, I don't think pin to any version could avoid to break existing consumers considering the emitter uses peerDependencies with range which would always fetch the latest peer dependencies.

  • If these breakings are introduced from underlying dependencies for example typespec compiler, and break the emitter and finally break our end users, then upgrading to the latest emitter would work;
  • If these breakings are introduced by emitter for example the supported feature surfaces change, then encuraging users to use the latest would be recommanded.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For repeatable builds, we should be pinning the versions of the packages we care about in package.json, and also checking in a package-lock.json which pins all packages. I can create PRs for these issues tomorrow, or you can:

#26197
#26198

Copy link
Member Author

@MaryGao MaryGao Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for info, pinning all packages would make sense to me.
@mikeharder I can take these, just double confirm the emitter-package-lock.json would be treated as package-lock.json alongside package.json, Right?

PR is here: #26200

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaryGao: See my feedback in #26200

KarishmaGhiya pushed a commit that referenced this pull request Jun 8, 2023
Update the emitter version to latest
minhanh-phan pushed a commit to minhanh-phan/azure-sdk-for-js that referenced this pull request Jun 12, 2023
Update the emitter version to latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants