[Search] Fix ISO8601 deserialization #25801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
|
Have you verified the behavior of this with unit tests, maybe? |
|
@KarishmaGhiya I added a unit test! |
KarishmaGhiya
approved these changes
May 9, 2023
minhanh-phan
pushed a commit
to minhanh-phan/azure-sdk-for-js
that referenced
this pull request
Jun 12, 2023
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Oct 16, 2023
Release machinelearningservices microsoft.machine learning services 2023 10 01 shadow (Azure#26104) * Adds base for updating Microsoft.MachineLearningServices from version stable/2023-04-01 to version 2023-10-01 * fix rebase * Updates API version in new specs and examples * mfe.json update description to fix linting errors (Azure#24968) Co-authored-by: Kayla Ames <[email protected]> * add headers for start/stop/restart compute examples (Azure#25072) * Adding SubscriptionId and ResourceGroup for Azure Datastore (Azure#25289) * Add query param in list job api (Azure#25374) Co-authored-by: Shail Paragbhai Shah <[email protected]> * [MachineLearning]Try fixing some lint error in 10-01 version (Azure#25519) * Try fixing some lint error * bug fix * remove unused definition * Update Example * adding queue settings to Oct 2023 stable api version (Azure#25765) * adding queue settings to Oct 2023 stable api version * update new line --------- Co-authored-by: Aaheli Chattopadhyay <[email protected]> * remove job priority (Azure#25775) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Adding MachineLearningService workspace resource publish API and registry datareference API (Azure#25619) * Adding machinelearningservices workspace publish and registry datareference API * minimize diff * minor updates on put job api summary * remove two unneeded APIs * remove extra adding long running annotation * Add managed Vnet to stable version (Azure#25729) * Add managed Vnet to stable version * update missing parameter * Update missing ref * meaningless commit trigger pipeline again * Revert "meaningless commit trigger pipeline again" This reverts commit baa386b8cf0abb96b461a27d9060188e7ed0581e. * add missing ref * Update example version * trigger pipeline * Revert "trigger pipeline" This reverts commit f989c4c91ca85dde28fa636ed82ba9c742a05db9. * add force to purge parameter * trigger pipeline * Revert "trigger pipeline" This reverts commit 42ea0f8c2dc17e42757112b279fae42a4dc6e557. * Update examples * Add format and update examples * [Model Monitoring][GA] - Add model monitoring scenarios (Azure#25801) * Add model monitoring scenarios * add * add * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * add ws vnet properties (Azure#25882) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Fix circular reference 2023-10-01 (Azure#25879) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule * description --------- Co-authored-by: Kayla Ames <[email protected]> * Adding proxy resource (Azure#25904) Co-authored-by: Shail Paragbhai Shah <[email protected]> * Add feature store api's to GA version (Azure#25594) * Add examples * Adding feature store GA api's * Sync examples * Add examples * Converting to ProxyResource --------- Co-authored-by: Shail Paragbhai Shah <[email protected]> * add serverless compute settings (Azure#26012) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * [MachineLearningService]Add featurestore property to stable version (Azure#26121) * Add workspace kind and featureStoreSettings * add description * Add description for ComputeRuntimeDti * remove featurestore settings for lint * remove Kind * Revert "remove featurestore settings for lint" This reverts commit f4d7ae352baf966aeba9085bd06df3456bd17bef. * Update readme fix --------- Co-authored-by: Kayla Ames <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Chunyu Li <[email protected]> Co-authored-by: shail2208 <[email protected]> Co-authored-by: Shail Paragbhai Shah <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: ac923 <[email protected]> Co-authored-by: Aaheli Chattopadhyay <[email protected]> Co-authored-by: chaoyu-msft <[email protected]> Co-authored-by: Mathieu St-Louis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/search-documents
Issues associated with this PR
#25777
Describe the problem that is addressed by this PR
Some valid ISO8601 date strings were not being deserialized into
Dateobjects. This fixes the deserialization behavior for ISO8601 date strings with millisecond values specified with under 3 digits of precision.