Date auto parsing from string is inconsistent

[shlomo-artlist]

• Package Name: @azure/search-documents
• Package Version: 11.3.1
• Operating system: Mac
• nodejs
  • version: 16.15.0
• typescript
  • version: 4.9

Describe the bug
It seems like results are getting back with mixed types in Date fields. Some are string while others are dates.
When looking into the difference I noticed that it will only parse ISO date strings that have all the 3 ms digits in them. If not, it would stay a string.
e.g.
'2023-03-30T07:13:57.397Z' - will parse
while:
'2023-03-30T07:13:57.39Z' - will not parse

Expected behavior
Parse always, or never.
Every valid ISO date should be parsed correctly.
NodeJS native function - Date - handles both cases.

[xirzec]

@dgetu looks like we need to adjust our date regex slightly: https://github.com/Azure/azure-sdk-for-js/blob/aca554effb8c77488693e25e409e28a4d5f3b35a/sdk/search/search-documents/src/serialization.ts#LL6C2-L6C2

I think we can just adjust the quantifier for ms like:

const ISO8601DateRegex = /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}(\.\d{1,3})?Z$/i;

[dgetu]

That looks like it should do the trick. I'll validate this and try to squeeze this fix into this month's release.

[dgetu]

This fix was merged and should be shipped in today's 11.3.2 and 12.0.0-beta.1 releases. Thanks for reporting this to us!

[shlomo-artlist]

Thanks for the fix!
Do you know when this 11.3.2 version going to be released?

[dgetu]

Apologies for going back on what I said before -- 12.0.0-beta.1 was shipped last week, but when trying to ship 11.3.2, we ran into a delay with our release process. We're hoping to ship as soon as the end of this week, but you should be able to either apply this patch manually or temporarily use 12.0.0-beta.1 if you're in more urgent need of unblocking. The beta API surface is mostly just an extension of the stable surface, so it should be a drop-in replacement for most use cases.