-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure communication job router sdk #22806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial commit of job router sdk * Fix code (Todo: createSpan needs to add to client) * add api review file * update pnpm yaml * skip samples for now * add readme * fix lint errors * fix lint errors * fix lint errors * add recordings * add recordings missing content * add recordings missing content - browser mode * remove assert * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/src/routerClient.ts Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/src/routerClient.ts Co-authored-by: Daniel Rodríguez <[email protected]> * update README.md * update README.md Co-authored-by: Marc Ma <[email protected]> Co-authored-by: Daniel Rodríguez <[email protected]>
* update to latest patch routes and models * minor fix * update routerClient * update according to feedback run autorest on latest swagger * minor updaate Co-authored-by: Marc Ma <[email protected]>
…-job-router-preview # Conflicts: # common/config/rush/pnpm-lock.yaml
Co-authored-by: Marc Ma <[email protected]>
update to latest swagger clean up tests Co-authored-by: Marc Ma <[email protected]>
* expose link models * add api file expose models Co-authored-by: Marc Ma <[email protected]>
…-job-router-preview # Conflicts: # common/config/rush/pnpm-lock.yaml
…-preview' into feature/communication-job-router-preview
* Add samples-dev Generate samples from samples-dev Adjust route params with public review swagger * Update options and routerClient Co-authored-by: Marc Ma <[email protected]>
* Add jobRouterAdministration.ts New swagger with new api version * Update samples and api version number Remove requests.ts * Update shrinkwrap file Co-authored-by: Marc Ma <[email protected]>
…-job-router-preview # Conflicts: # common/config/rush/pnpm-lock.yaml # sdk/communication/ci.yml
ghost
added
the
Communication
label
Aug 4, 2022
API change check APIView has identified API level changes in this PR and created following API reviews. |
marche0133
requested review from
witemple-msft,
deyaaeldeen,
mikeharder,
praveenkuttappan,
jeremymeng,
benbp,
bterlson and
xirzec
as code owners
August 4, 2022 19:51
Remove empty options
Update connection string name
joheredi
reviewed
Aug 16, 2022
sdk/communication/communication-jobrouter/samples-dev/JobQueueCrud.ts
Outdated
Show resolved
Hide resolved
sdk/communication/communication-jobrouter/samples-dev/JobQueueCrud.ts
Outdated
Show resolved
Hide resolved
sdk/communication/communication-jobrouter/samples-dev/QuickStart.ts
Outdated
Show resolved
Hide resolved
sdk/communication/communication-jobrouter/src/models/options.ts
Outdated
Show resolved
Hide resolved
joheredi
reviewed
Aug 16, 2022
…-job-router-preview # Conflicts: # common/config/rush/pnpm-lock.yaml
Update pnpm lock
joheredi
reviewed
Aug 23, 2022
...communication/communication-jobrouter/samples/v1-beta/javascript/ClassificationPolicyCrud.js
Outdated
Show resolved
Hide resolved
joheredi
reviewed
Aug 23, 2022
sdk/communication/communication-jobrouter/review/communication-jobrouter.api.md
Outdated
Show resolved
Hide resolved
sample-dev update
joheredi
reviewed
Aug 24, 2022
joheredi
reviewed
Aug 25, 2022
sdk/communication/communication-jobrouter/test/public/exceptionPolicies.spec.ts
Outdated
Show resolved
Hide resolved
joheredi
reviewed
Aug 25, 2022
joheredi
reviewed
Aug 25, 2022
joheredi
reviewed
Aug 25, 2022
Update readme Update some recordings
joheredi
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for incorporating the suggestions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first public version of Azure Communication JobRouter js sdk
JobRouter introduction: https://docs.microsoft.com/en-us/azure/communication-services/concepts/router/concepts
APIView: https://apiview.dev/Assemblies/Review/205ad7b449fb4923bad268ecbd5caaf4