[@azure/communication-job-router] rev 1 for internal review #22096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marche0133
requested review from
danielgerlag,
williamzhao87,
bga-msft,
NathanJBennett,
sarkar-rajarshi,
rcoleobrien,
adamtuck-msft and
cparisineti
ghost
added
the
xirzec
changed the title
marche0133
added a commit
that referenced
this pull request
Aug 29, 2022
* Pass js sdk pipeline ci (#18888) * Initial commit of job router sdk * Fix code (Todo: createSpan needs to add to client) * add api review file * update pnpm yaml * skip samples for now * add readme * fix lint errors * fix lint errors * fix lint errors * add recordings * add recordings missing content * add recordings missing content - browser mode * remove assert * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/README.md Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/src/routerClient.ts Co-authored-by: Daniel Rodríguez <[email protected]> * Update sdk/communication/communication-job-router/src/routerClient.ts Co-authored-by: Daniel Rodríguez <[email protected]> * update README.md * update README.md Co-authored-by: Marc Ma <[email protected]> Co-authored-by: Daniel Rodríguez <[email protected]> * Latest API & Swagger (Update post patch routes, etc) (#19953) * update to latest patch routes and models * minor fix * update routerClient * update according to feedback run autorest on latest swagger * minor updaate Co-authored-by: Marc Ma <[email protected]> * rev 1 (#22096) Co-authored-by: Marc Ma <[email protected]> * address required/options params feedback (#22245) update to latest swagger clean up tests Co-authored-by: Marc Ma <[email protected]> * expose models (#22331) * expose link models * add api file expose models Co-authored-by: Marc Ma <[email protected]> * Add samples for js sdk (#22444) * Add samples-dev Generate samples from samples-dev Adjust route params with public review swagger * Update options and routerClient Co-authored-by: Marc Ma <[email protected]> * Public feedback and new api version (#22793) * Add jobRouterAdministration.ts New swagger with new api version * Update samples and api version number Remove requests.ts * Update shrinkwrap file Co-authored-by: Marc Ma <[email protected]> * Rename to jobrouter * Rename in docs * Resolve lint errors * Remove samples readme temporarily Remove empty options * Remove beta tag Update connection string name * Update test node recordings * Fix lint and tests * Run check-format (prettier) * Update to test-recorder v2 * Update communication packages version to v2 * Resolve conflicts * Update Readme Resolve lint * Update version number * Fix tests in node mode TOOD: fix tests in browser mode * Update according to feedbacks * Update import Update pnpm lock * Update samples * Update api file * Fix api file * Add a missing route * fields renaming sample-dev update * Add paths for the package * Add todos and issue links Update readme Update some recordings * Update tests * Prettier * headerless matcher * rename the package folder * update package name in files Co-authored-by: Marc Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr contains the latest code for the rev 1 in the internal review meeting. We can do the tasks for the feedback from here.
https://apiview.dev/Assemblies/Review/1d6c0f3692674b47a50d72d5041b8d1c
Backlog Task: https://skype.visualstudio.com/SPOOL/_workitems/edit/2846733 (keep in-progress after PR merge)