Run build test pipeline for reduced test scope fore core pipeline #17290
Conversation
praveenkuttappan
added
the
Central-EngSys
praveenkuttappan
requested review from
danieljurek and
weshaggard
as code owners
| @@ -3,6 +3,28 @@ const path = require("path"); | |||
| const process = require("process"); | |||
| const { spawnSync } = require("child_process"); | |||
|
|
|||
| const reducedDependencyTestMatrix = { | |||
There was a problem hiding this comment.
How was this list determined? Is it a manually-selected list of packages we think provide a good balance of coverage vs build time?
There was a problem hiding this comment.
Yes I picked them based from the following categories that I think are important/representative. We could fine tune the list if needed.
- Rest core
- Rest level client
- Perf tests
- Non-storage Track 2 hand-written (core-rest-pipeline)
- Management
- Dev tool
- Identity
- Service Bus (core-amqp)
- Storage
- Template (core-http)
- Test utils
- Generated Track 2
There was a problem hiding this comment.
I must say, this list looks like a great balance of everything!
| rushCommandFlag = "--only"; | ||
| } | ||
|
|
||
| rushRunAll(rushCommandFlag, packageNames); |
There was a problem hiding this comment.
Should we rename rushRunAll to something else since it is no longer running all packages in all cases? perhaps just runRush?
There was a problem hiding this comment.
Sure. Will do in separate cleanup PR if that's fine.
| '@azure/identity-vscode', | ||
| '@azure/service-bus', | ||
| '@azure/storage-blob', | ||
| '@azure/template', |
There was a problem hiding this comment.
maybe we can drop the template too, it does not buy us anything I think
There was a problem hiding this comment.
I would keep template, it should be very fast and we do want to ensure it doesn't break.
There was a problem hiding this comment.
I do not feel strongly about this but my suggestion is mainly because I can not think of a scenario where template could fail but the others do not.
There was a problem hiding this comment.
It took about 20 seconds in js - core - ci pipeline. I picked it because I think it's important in that new packages are often created based on it.
There was a problem hiding this comment.
@jeremymeng every package is important for sure but that is beside the point, do we know if there is a scenario where template could break their build or tests where none of the other packages in the list will? I would be surprised if there is one and IMO will indicate template has an unusual design which does not make sense.
There was a problem hiding this comment.
Let keep it in the category of "Non-Storage Track 2 core-http based" for now until we migrate everything. Text Analytics covers core-rest-pipeline
There was a problem hiding this comment.
@praveenkuttappan please this @azure-tools/test-recorder instead of @azure/test-utils-recorder.
praveenkuttappan
force-pushed
the
reduce_core_test
branch
from
030206e to
252207d
Compare
praveenkuttappan
dismissed
HarshaNalluru’s stale review
changed as per suggestion
|
/azp run js - identity |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Add a new option to configure predefined set of dependent projects as part of build and test instead of using rush logic to find the dependency. This is required to reduce the test scope in core pipeline from growing 110+ packages to fixed 34 packages which includes core packages too.
Local build time is reduced from 40 mins to 7 mins.