Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main #16130

Merged
merged 48 commits into from
Jul 2, 2021
Merged

Merge main #16130

merged 48 commits into from
Jul 2, 2021

Conversation

colawwj
Copy link
Contributor

@colawwj colawwj commented Jul 1, 2021

No description provided.

chradek and others added 30 commits June 25, 2021 17:24
Followed the steps at https://github.com/Azure/azure-sdk-for-js/wiki/Samples-v2-Migration-Guide
/cc @willmtemple 

Note: I moved browserSamples and expressSamples into the generated v5 samples folder since dev-tool doesn't work with those.
to delete tags before delete the image as this is the recommended best
practice for the service.
* [Identity] Test improvements

* temporary node 16 fix

* Since unhandled promise rejections are not supported in Node 16, tickAsync can't be awaited

* fix the test

Co-authored-by: Harsha Nalluru <[email protected]>
## What

- Regenerate from 7.3-preview swagger
- Add `getRandomBytes` method

## Why

- For July we would like to add support for the RNG endpoint in a Managed HSM. While this is a customer ask for Java, we will add this to all languages at the same time.
As part of AzureSDKAutomation#7022, we will be moving the version of `@types/node` from 8 to 12
This PR has the changes required to fix the build errors that occurred when trying out this change
- The [Agent](https://nodejs.org/docs/latest-v12.x/api/http.html#http_class_http_agent) class in Node.js 12 has an extra property `maxTotalSockets`. The docs say there is a default value for this, but it it is still marked as a mandatory property in the types. We use our own interface for this class for the purposes of user providing their own custom agent. Am casting it in this PR to the expected type. If anyone has better ideas here, am all ears :)
- `global.URL` is not a thing as per the types for Node.js 12. We needed this to support Node.js 8
- Fixing the types for `port` in the parsed url

The actual move to v12 for `@types/node` will be done in a separate PR
* Use BufferEncoding as encoding is not a string in Node.js 12

* Fix typing issue for fsStat returning unknown
* adds simple background refresh

* Adds setInterval with unref

* cleanup

* wip prenock

* wip

* Removes recorder, fixes timeout in tests

* extract api

* fix lint

* format

* Adds flag

* lint

* Fix parition spelling

* modify endpoint check

* fix tests

* Comment proxy

* adds back copyright

* skip session spec

* Fix session token

* Fix session spec on emulator
* Support track2 management packages
Perf test packages should not be using the eslint plugin

Fixes the below error

```


ESLint couldn't find the plugin "@azure/eslint-plugin-azure-sdk".

(The package "@azure/eslint-plugin-azure-sdk" was not found when loaded as a Node module from the directory "/home/vsts/work/1/s/sdk".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install @azure/eslint-plugin-azure-sdk@latest --save-dev

The plugin "@azure/eslint-plugin-azure-sdk" was referenced from the config file in "../../../.eslintrc.json".

```
…est-pipeline (Azure#16045)

This PR updates the newly added `@azure-rest/core-client-paging` package to use the same version of `@azure/core-rest-pipeline` that the other packages use.

We recently GA'd (on main, not released yet) version 1.1.0 of `@azure/core-rest-pipeline` and want to keep everyone on the latest version.
Follow up for Azure#16046 to fix the resulting linter errors
…16010)

Update to latest core packages and improve pipeline robustness.
As part of the development of the new pipeline, event grid was hand
ported to use the new pipeline. Now that the code generator targets
the new pipeline, we can start using it to generate the code.

Since EventGrid includes the `/api/events` path segment in the
Endpoint, We need to do a small amount of post processing of the
generated code, to ensure `/api/events` is not appended to the
endpoint (we do this by setting an empty path in the operation spec,
which is as things were before moving over to the generator).

Fixes Azure#15823
…dential (Azure#15856)

* [Identity] Add support for Bridge to Kubernetes to ManagedIdentityCredential

* one very simple test

* forgot this line
…ers (Azure#15932)

* [Monitor Exporter] Separate tests into internal and public folders

* fix build

* put tests in internal

* prettier

* console log for testing

* testing

* format

* console

* try flush processor

* format

* remove console logs
## What

- Adds warning filter to ignore known rollup warnings that are safe to ignore
- Ignore `this has been rewritten to undefined` in synapse
- Ignore circular dependencies in synapse

## Why

These are both known warnings, are safe to ignore, and add noise to the build output unnecessarily. 

The first is totally safe to ignore:

```
var __spreadArray = (this && this.__spreadArray) || function (to, from) {
```

Is emitted from TypeScript in the OTel ESM and is safe to use.
The second is a known issue in OTel 1.0.0 that is not harmful at runtime.

Finally, we have precedent for doing the exact same thing in other packages like service-bus.
The watchful eyes of @vishnureddy17 found that we still have reference to Node.js 8 in our Contributing Guide!!

This PR fixes that.

Related to AzureSDKAutomation#7022
* Update identity to 2.0.0-beta.4 for quantum jobs

* Fix CI Errors

* Fix CI Errors
Based on the Retry-After specification, 503 should also be supported when considering the Retry-After header.

This also aligns with upcoming Identity plans.
@dw511214992
Copy link
Member

Does anyone have the access to Create a Merge Commit instead of Squash and merge? The PR merges the codes of main to feature/v4. So we don't want to squash it. thanks

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is just for merging main, I do not think you need to have it in a PR. You could just push to the feature branch right away.

@dw511214992 dw511214992 merged commit d75f119 into Azure:feature/v4 Jul 2, 2021
@colawwj colawwj deleted the merge-main branch July 8, 2021 08:18
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Feb 28, 2022
Dev securityinsights microsoft.security insights 2021 10 01 (Azure#17924)

* Adds base for updating Microsoft.SecurityInsights from version stable/2021-04-01 to version 2021-10-01

* Updates readme

* Updates API version in new specs and examples

* Add AlertRules to microsoft.security insights 2021 10 01 (Azure#15657)

* Adds base for updating Microsoft.SecurityInsight's AlertRules from version stable/2020-01-01 to version 2021-10-01

* Updates API version in AlertRules specs and examples

* Use common types in AlertRules.json and remove redundant SecurityInsights

* Add AlertRules to readme

* Copy action examples for alert rules

* Add type:object where missing

* Align CloudError with rest of the resources in this version

* Update readme

Co-authored-by: Anat Gilenson <[email protected]>

* Use newest common types to align with rest of Azure (Azure#16130)

* Use newest common types to align with rest of Azure

* Use ErrorResponse instead of CloudError in operations

Co-authored-by: Anat Gilenson <[email protected]>

* Add AlertRules Stable version to 2021-10-01 (Azure#16268)

* Add AlertRules Stable version to 2021-10-01

* Fix missing alignment in common types

* prettier fixes

* move tactics and severity to common

* fix common types file extension

* more prettier fixes

* Add template version field

* prettier

* added version to required fields

* dummy change to trigger checks again

* Add onboarding states to new stable version (Azure#16290)

* Add onboarding states to new stable version

* Update readme.md

* cr fix - remove unused params

* Add missing resources 2021 10 01 (Azure#16666)

* Add missing resources and examples from 2020-01-01

* Update version in added resources and examples

* Use existing common types

* Remove unnesessary SecurityInsights.json

* Update readme

* Use sentinel common types in Incidents and Watchlist

* Extract and common IncidentInfo and IncidentSeverity

* Extract EntityTypes

* Correct double allOf in EntityTypes

* update readme

* Remove eventGroupingSettings and entityMappings from GetAlertRuleTemplateById example.

* rename operations.json

Co-authored-by: Anat Gilenson <[email protected]>

* Fix analytics templates model (Azure#16689)

* add missing properties to scheduled template

* prettier fixes

* restore templates example after merge

* fix templates example after merge and run prettier

* Use CloudError instead of ErrorResponse to align with preview versions and our back-end. (Azure#17472)

* Automation - Stable Version (Azure#17491)

* First

* readMe

* cloudError

* CloudError

* schema

* prettier

* Fix

* test

* fix identifier

* fix description

* fix lable

* fix lable

* ownerInfo

* Fix

* types

* conditionMaxLength

Co-authored-by: Roy Reinhorn <[email protected]>

* Done (Azure#17728)

Co-authored-by: Roy Reinhorn <[email protected]>

* Correct 2021 10 01 (Azure#17830)

* Remove OperationalInsightsResourceProvider parameter in ThreatIntelligence

* Remove OperationalInsightProviderParameter from Watchlist

* Align stable operation names with preview

* Add missing disciminator property in ThreatIntelligence

* Done (Azure#17844)

Co-authored-by: Roy Reinhorn <[email protected]>

* Align enum names with preview (Azure#17831)

* Fix 2021 10 01 validation errors (Azure#17937)

* Add x-ms-identifiers to all arrays

* Add operations_list example

* Add x-ms-identifier in all arrays

* Run prettier

* Fix spelling error

* Add isDataAction to operation schema (Azure#18018)

Co-authored-by: Anat Gilenson <[email protected]>
Co-authored-by: laithhisham <[email protected]>
Co-authored-by: royrein <[email protected]>
Co-authored-by: Roy Reinhorn <[email protected]>
Co-authored-by: Arthur Ning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.