-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[event-hubs] migrate samples to v2 #15053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the samples/browserSample
directory, what I suggest is to move it to samples-browser
and create an entry in //sampleConfiguration
to copy it into the samples/v5
directory, next to javascript
and typescript
during the publication script. This isn't yet documented in the migration guide, but the capability is available through the extraFiles
property: #14576
I'd really like to find a new home for the express sample at some point, but for now we could do the same thing with it or leave the manual copy you created.
Updated, thanks for the tips @willmtemple! |
/azp run js - eventhub - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
@chradek Looks like what we have is a bunch of broken links |
@ramya-rao-a Now it is fixed! If you wait for #15137 to be merged then you can leave me to deal with the fallout of broken links/merge conflicts. |
#15137 is merged! Happy merge conflicts to you! |
/azp run js - eventhub - ci |
No commit pushedDate could be found for PR 15053 in repo Azure/azure-sdk-for-js |
Looks like there are a few more broken links... |
Oh no...I fixed all the merge conflicts then reran the dev-tool publish script and it overwrote the links from Edit: I use worktrees, so I think the dev-tool I installed previously was linked to the one in my master branch, so didn't pick up the changes from |
/azp run js - eventhub - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @chradek! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Followed the steps at https://github.com/Azure/azure-sdk-for-js/wiki/Samples-v2-Migration-Guide
/cc @willmtemple
Note: I moved browserSamples and expressSamples into the generated v5 samples folder since dev-tool doesn't work with those.