Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mock-hub] Initial mock event hubs package #13737

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Conversation

chradek
Copy link
Contributor

@chradek chradek commented Feb 10, 2021

Replaces #10467

Now supports TLS. Currently all JS event-hubs live tests pass against the mock event hubs.

Also tested that sending/receiving events, as well as $management operations (e.g. list event hub properties, list partition properties) work with the .NET and Java clients.

This undoubtedly has some bugs, but I think it's in a good enough state to get more eyes on it and for us to consider using it to run our live tests locally.

@@ -0,0 +1,48 @@
## Mock Event Hubs service

This package exposes a mock Event Hubs service for use in testing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use in testing.

Ah, so like a testhub.

1. Avoid hitting the live service for tests.
2. Deterministically trigger 'bad' service behavior.
3. Simplify tests that rely on state. (populate events, change consumer groups/partition ids)
4. Extend to support record & playback.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3. Simplify tests that rely on state. (populate events, change consumer groups/partition ids)
4. Extend to support record & playback.

Currently, the project only fulfills the 1st goal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but you can help me meet the other goals!

Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, as expected. This is great!

@chradek chradek merged commit d6ac866 into Azure:master Feb 11, 2021
@chradek chradek deleted the add-mock-hubs branch February 11, 2021 20:28
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Apr 1, 2021
Merge Dev-containerservice-microsoft.containerservice-2021-03-01 API to master  (Azure#13737)

* Adds base for updating Microsoft.ContainerService from version stable/2021-02-01 to version 2021-03-01

* Updates readme

* Updates API version in new specs and examples

* fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range (Azure#13349)

Co-authored-by: Charlie Li <[email protected]>

* Add enableFIPS property to 2021-03-01 API in dev 2021-03-01 branch (Azure#13359)

* fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range

* Add enableFIPS property to the 2021-03-01 API

* Add enableFIPS property to the 2021-03-01 API

Co-authored-by: Charlie Li <[email protected]>

* adding node-image upgrade channel enum (Azure#13375)

Co-authored-by: Charlie McBride <[email protected]>

* Add httpProxyConfig specs to 2021-03-01 API - dev (Azure#13410)

* Add httpProxyConfig specs to 2021-03-01 API - dev

* Fix prettier

* aks: add `bindingSelector` to managed cluster pod identity profile (Azure#13399)

* AKS runCommand new feature  (Azure#13420)

* runCommand target to 03-01

* fix api-version in examples

* Add property disableLocalAccounts to 2021-03-01 API version (Azure#13385)

* Add property disableLocalAccounts

* Fix indentation

* Add OSSKU and GPUInstanceProfile to containerservice/microsoft.container API 2021-03-01 (Azure#13532)

* Add OSSKU and GPUInstanceProfile

* Add sample for OSSKU and GPUInstanceProfile

* Fix custom words

* Reference sample files

* update custom-words

* Update readme for sdks  (Azure#13515)

* update readme for sdks

* update readme for sdks

Co-authored-by: Charlie Li <[email protected]>

* Add example to create agent pool with FIPS enabled (Azure#13557)

* add example to create agent pool with FIPS enabled

* change a property name in the example file

Co-authored-by: Charlie Li <[email protected]>

* Added extended location parameter to managed cluster which will target all agent pools to that extended location. (Azure#13560)

* Add data model for get OS options. (Azure#13619)

* Add data model for get OS options.

* Add default resource name in API path.

* Fix container service tags. (Azure#13739)

Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: Charlie Li <[email protected]>
Co-authored-by: Charlie McBride <[email protected]>
Co-authored-by: Charlie McBride <[email protected]>
Co-authored-by: Bo Wang <[email protected]>
Co-authored-by: hbc <[email protected]>
Co-authored-by: Haitao Chen <[email protected]>
Co-authored-by: Tony Xu <[email protected]>
Co-authored-by: Mirza Sikander <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants