[storage] add fromConnectString to DataLakeServiceClient #13420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljian3377
requested review from
bterlson,
chradek,
HarshaNalluru,
jeremymeng,
jiacfan,
vinjiang,
XiaoningLiu and
xirzec
as code owners
ghost
added
the
ljian3377
added
the
APIChange
XiaoningLiu
reviewed
Jan 28, 2021
| * Account connection string example - | ||
| * `DefaultEndpointsProtocol=https;AccountName=myaccount;AccountKey=accountKey;EndpointSuffix=core.windows.net` | ||
| * SAS connection string example - | ||
| * `BlobEndpoint=https://myaccount.blob.core.windows.net/;QueueEndpoint=https://myaccount.queue.core.windows.net/;FileEndpoint=https://myaccount.file.core.windows.net/;TableEndpoint=https://myaccount.table.core.windows.net/;SharedAccessSignature=sasString` |
There was a problem hiding this comment.
Check other datalake SDK align with datalake connection string format (for example, using "BlobEndpoint" as datalake endpoint)
There was a problem hiding this comment.
Oops, turns out .NET don't have this.
XiaoningLiu
approved these changes
Jan 28, 2021
ljian3377
added
the
cross-language alignment
ljian3377
added a commit
that referenced
this pull request
Feb 7, 2021
)" This reverts commit bfa1f92.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Apr 1, 2021
Merge Dev-containerservice-microsoft.containerservice-2021-03-01 API to master (Azure#13737) * Adds base for updating Microsoft.ContainerService from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range (Azure#13349) Co-authored-by: Charlie Li <[email protected]> * Add enableFIPS property to 2021-03-01 API in dev 2021-03-01 branch (Azure#13359) * fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range * Add enableFIPS property to the 2021-03-01 API * Add enableFIPS property to the 2021-03-01 API Co-authored-by: Charlie Li <[email protected]> * adding node-image upgrade channel enum (Azure#13375) Co-authored-by: Charlie McBride <[email protected]> * Add httpProxyConfig specs to 2021-03-01 API - dev (Azure#13410) * Add httpProxyConfig specs to 2021-03-01 API - dev * Fix prettier * aks: add `bindingSelector` to managed cluster pod identity profile (Azure#13399) * AKS runCommand new feature (Azure#13420) * runCommand target to 03-01 * fix api-version in examples * Add property disableLocalAccounts to 2021-03-01 API version (Azure#13385) * Add property disableLocalAccounts * Fix indentation * Add OSSKU and GPUInstanceProfile to containerservice/microsoft.container API 2021-03-01 (Azure#13532) * Add OSSKU and GPUInstanceProfile * Add sample for OSSKU and GPUInstanceProfile * Fix custom words * Reference sample files * update custom-words * Update readme for sdks (Azure#13515) * update readme for sdks * update readme for sdks Co-authored-by: Charlie Li <[email protected]> * Add example to create agent pool with FIPS enabled (Azure#13557) * add example to create agent pool with FIPS enabled * change a property name in the example file Co-authored-by: Charlie Li <[email protected]> * Added extended location parameter to managed cluster which will target all agent pools to that extended location. (Azure#13560) * Add data model for get OS options. (Azure#13619) * Add data model for get OS options. * Add default resource name in API path. * Fix container service tags. (Azure#13739) Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Charlie McBride <[email protected]> Co-authored-by: Charlie McBride <[email protected]> Co-authored-by: Bo Wang <[email protected]> Co-authored-by: hbc <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Tony Xu <[email protected]> Co-authored-by: Mirza Sikander <[email protected]> Co-authored-by: Jun Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13396.
I am reluctant to also add constructor overload for connect string to
DataLakeFileSystemClientandDataLakePathClient... as the constructors will be too heavily overloaded and also I don't think it's that useful.This is what the
BlobClient's constructor looks like now.https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob/src/Clients.ts#L1231-L1241
azure-sdk-for-js/sdk/storage/storage-blob/src/Clients.ts
Lines 1231 to 1241 in ee4b34b
I would rather add an independent
fromConnectStringfor these clients too if needed.