Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Communication - Identity] CommunicationIdentityClient [Playback/Live] [AAD] successfully creates a user and gets a token in a single request failing in nightly runs #18135

Closed
v-jiaodi opened this issue Oct 12, 2021 · 3 comments
Closed

[Communication - Identity] CommunicationIdentityClient [Playback/Live] [AAD] successfully creates a user and gets a token in a single request failing in nightly runs #18135

v-jiaodi opened this issue Oct 12, 2021 · 3 comments
Assignees
@petrsvihlik
Labels
Client This issue points to a problem in the data-plane of the library. Communication test-reliability Issue that causes tests to be unreliable

Comments

@v-jiaodi
Copy link
Member

Communication - Identity nightly test runs are failing with:

Error message:
expected undefined to be a string

Stack trace:
AssertionError: expected undefined to be a string
at Context. (D:\a_work\1\s\sdk\communication\communication-identity\test\public\communicationIdentityClient.spec.ts:65:14)
at processTicksAndRejections (node:internal/process/task_queues:96:5)

For more details check here:
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 12, 2021
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. Communication test-reliability Issue that causes tests to be unreliable and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Oct 12, 2021
@maorleger maorleger assigned petrsvihlik and unassigned maorleger Oct 15, 2021
@maorleger
Copy link
Member

@petrsvihlik this and #18181 - I took a quick look and seems like the latest manually triggered build succeeded, so it might be that this is fixed. But the failures didn't seem flaky - mind taking a look (or assigning to someone from your team?)

@petrsvihlik
Copy link
Contributor

@maorleger I will take a look. thanks!

@petrsvihlik
Copy link
Contributor

there was a problem in DEV and INT last week. we had to do some rollbacks and redeployments but it's resolved now.

related discussion

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 29, 2022
@zhenglaizhang @msdogra
@srmarkov @cohen-uriel-ms @markonikolicmicrosoft @cicovic-andrija-msft @imadan1996
CodeGen from PR 18428 in Azure/azure-rest-api-specs
6098d47 
Rebase Microsoft.SQL in Main Branch (Azure#18428)

* Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (Azure#17143)

* Updated Blob Auditing API Files (Azure#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <[email protected]>

* Adding swagger for endpoint certificates (Azure#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (Azure#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* Adding ManagedServerDnsAliases API endpoints (Azure#18008)

* change

* Update readme.md

* error 201

* Revert "Update readme.md"

This reverts commit ceff39a406eefda1ed38c6188fd9d2eb271053ab.

* Revert "error 201"

This reverts commit 759fa4f92e9967d72060485aa36d7a1b62a9d227.

* Fixed bad reverts

Co-authored-by: Ji Wang <[email protected]>

* Add 201 response example so SQL clients can work correctly (Azure#18121)

* Add examples for cross sub restore (Azure#18135)

* Release Microsoft.sql 2021 11 01 preview (Azure#18005)

* update swagger files and example files

* update readme.md

* address the pipeline error.

* update the reference.

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

* Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (Azure#17143)

* Updated Blob Auditing API Files (Azure#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <[email protected]>

* Adding swagger for endpoint certificates (Azure#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (Azure#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* update swagger files and example files

* update readme.md

* address the pipeline error.

* resolove the conflict

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: msdogra <[email protected]>
Co-authored-by: Mukesh Dogra <[email protected]>
Co-authored-by: srmarkov <[email protected]>
Co-authored-by: Uriel Cohen <[email protected]>
Co-authored-by: Marko Nikolic <[email protected]>
Co-authored-by: Andrija Cicovic <[email protected]>
Co-authored-by: Ishan Rajesh Madan <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petrsvihlik petrsvihlik

Labels
Client This issue points to a problem in the data-plane of the library. Communication test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maorleger @petrsvihlik @v-xuto @v-jiaodi