Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analysisservices - cspell found spelling errors #17143

Closed
danieljurek opened this issue Aug 26, 2021 · 1 comment
Closed

analysisservices - cspell found spelling errors #17143

danieljurek opened this issue Aug 26, 2021 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@danieljurek
Copy link
Member

danieljurek commented Aug 26, 2021 •
edited
Loading

Spell check scanning of analysisservices detected spelling errors. This service directory is opted out of PR spell checking in PR #17142 to keep merges unblocked.

What to do

  1. Ensure Node.js is installed (https://nodejs.org/en/download/). This will include npx
  2. Delete the service's entry in .vscode/cspell.json's ignorePaths field. It will look like: sdk/analysisservices/**/*. You need to do this to enable checking the files.
  3. From the root of the repo run spell check using npx cspell lint --config '.vscode/cspell.json' --no-must-find-files "sdk/analysisservices/**"
  4. Fix detections according to http://aka.ms/azsdk/engsys/spellcheck use the "False positives" section to fix false positives
  5. Check in changes (including the change to .vscode/cspell.json where the ignorePaths is updated to remove the entry for this service.). You may need to run git add -f .vscode/cspell.json to force adding the changes to the file in git.

Spell checking output

/home/djurek/azure-sdk-for-js/sdk/analysisservices/arm-analysisservices/src/models/index.ts:224:71 - Unknown word (DMTS)
/home/djurek/azure-sdk-for-js/sdk/analysisservices/arm-analysisservices/src/models/index.ts:231:24 - Unknown word (dmts)
/home/djurek/azure-sdk-for-js/sdk/analysisservices/arm-analysisservices/src/models/index.ts:231:51 - Unknown word (DMTS)
/home/djurek/azure-sdk-for-js/sdk/analysisservices/arm-analysisservices/src/models/index.ts:235:12 - Unknown word (dmts)
/home/djurek/azure-sdk-for-js/sdk/analysisservices/arm-analysisservices/src/models/mappers.ts:273:7 - Unknown word (dmts)
/home/djurek/azure-sdk-for-js/sdk/analysisservices/arm-analysisservices/src/models/mappers.ts:275:26 - Unknown word (dmts)
@danieljurek danieljurek added the Client This issue points to a problem in the data-plane of the library. label Aug 26, 2021
@ramya-rao-a ramya-rao-a added the EngSys This issue is impacting the engineering system. label Aug 27, 2021
@ramya-rao-a
Copy link
Contributor

All spell check errors are for an auto generated package and we don't intend to make any fixes for such packages

@danieljurek danieljurek mentioned this issue Dec 2, 2021
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 29, 2022
@zhenglaizhang @msdogra
@srmarkov @cohen-uriel-ms @markonikolicmicrosoft @cicovic-andrija-msft @imadan1996
CodeGen from PR 18428 in Azure/azure-rest-api-specs
6098d47 
Rebase Microsoft.SQL in Main Branch (Azure#18428)

* Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (Azure#17143)

* Updated Blob Auditing API Files (Azure#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <[email protected]>

* Adding swagger for endpoint certificates (Azure#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (Azure#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* Adding ManagedServerDnsAliases API endpoints (Azure#18008)

* change

* Update readme.md

* error 201

* Revert "Update readme.md"

This reverts commit ceff39a406eefda1ed38c6188fd9d2eb271053ab.

* Revert "error 201"

This reverts commit 759fa4f92e9967d72060485aa36d7a1b62a9d227.

* Fixed bad reverts

Co-authored-by: Ji Wang <[email protected]>

* Add 201 response example so SQL clients can work correctly (Azure#18121)

* Add examples for cross sub restore (Azure#18135)

* Release Microsoft.sql 2021 11 01 preview (Azure#18005)

* update swagger files and example files

* update readme.md

* address the pipeline error.

* update the reference.

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

* Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (Azure#17143)

* Updated Blob Auditing API Files (Azure#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <[email protected]>

* Adding swagger for endpoint certificates (Azure#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (Azure#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* update swagger files and example files

* update readme.md

* address the pipeline error.

* resolove the conflict

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: msdogra <[email protected]>
Co-authored-by: Mukesh Dogra <[email protected]>
Co-authored-by: srmarkov <[email protected]>
Co-authored-by: Uriel Cohen <[email protected]>
Co-authored-by: Marko Nikolic <[email protected]>
Co-authored-by: Andrija Cicovic <[email protected]>
Co-authored-by: Ishan Rajesh Madan <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danieljurek @ramya-rao-a