Migrate Additional V11 Test Classes #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue
Removes RawClients from Storage Blobs
alzimmermsft
added
Storage
alzimmermsft
requested review from
samvaity,
sima-zhu,
srnagar,
weshaggard,
yaohaizh and
yvgopal
as code owners
alzimmermsft
removed request for
mitchdenny,
danieljurek,
christopheranderson,
g2vinay,
hemanttanwar,
weshaggard,
conniey,
yvgopal,
samvaity,
yaohaizh,
nemakam,
mssfang and
srnagar
| @@ -336,7 +337,7 @@ | |||
| * @return | |||
| * A reactive response containing the information of the cleared pages. | |||
| */ | |||
| public Flux<PageRange> getPageRanges(BlobRange blobRange) { | |||
| public Mono<Response<PageList>> getPageRanges(BlobRange blobRange) { | |||
There was a problem hiding this comment.
We may want to undo these changes (and any others made to listing operation return types). The PagedFlux changes are in PR, and this will just be one more conflict that we know the winner of already.
There was a problem hiding this comment.
Discussed to deal with merge.
jaschrep-msft
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4321
Migrates and turns on DownloadResponseTest, HelperTest, ProgressReporterTest, and RetryTest. Additionally fixes scoping issue on SAS classes and cleanups linting issues related to their scoping change.