Storage SAS implementation #4404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Simplementation Merging storage-post-review1-dev
|
Can one of the admins verify this patch? |
alzimmermsft
added a commit
that referenced
this pull request
Jul 25, 2019
* Storage SAS implementation (#4404) * SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue * Remove RawClients from Blobs (#4375) Removes RawClients from Storage Blobs * Add deleteContainer to StorageClient and getBlobClient with Snapshot to ContainerClient (#4376) * Removed raw clients * Added deleteContainer to StorageClient * Added getAppendBlob with snapshot to ContainerClient * Storage queue linting, builder refactor, tests (#4383) * Initial check in for storage queue * Initial checkin for Storage file (#4414) * Finished the restructure, refactor builder. Added sleep in record feature. Linting * Merge Storage Blob Client Builders (#4468) Merges AppendBlobClientBuilder, BlobClientBuilder, BlockBlobClientBuilder, and PageBlobClientBuilder into a single builder class BlobClientBuilder. Additionally, JavaDoc comments for the other builder classes, ContainerClientBuilder and StorageAccountClientBuilder, were cleaned up and the way the endpoint is handled in builders was changed.
jianghaolu
added a commit
that referenced
this pull request
Jul 29, 2019
* Storage SAS implementation (#4404) * SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue * Remove RawClients from Blobs (#4375) Removes RawClients from Storage Blobs * Add storage swaggers * Update Storage to azure-core preview 3 * Add deleteContainer to StorageClient and getBlobClient with Snapshot to ContainerClient (#4376) * Removed raw clients * Added deleteContainer to StorageClient * Added getAppendBlob with snapshot to ContainerClient * Storage queue linting, builder refactor, tests (#4383) * Initial check in for storage queue * Address code review feedback in AutoRest * Initial checkin for Storage file (#4414) * Finished the restructure, refactor builder. Added sleep in record feature. Linting * Merge Storage Blob Client Builders (#4468) Merges AppendBlobClientBuilder, BlobClientBuilder, BlockBlobClientBuilder, and PageBlobClientBuilder into a single builder class BlobClientBuilder. Additionally, JavaDoc comments for the other builder classes, ContainerClientBuilder and StorageAccountClientBuilder, were cleaned up and the way the endpoint is handled in builders was changed. * Regenerate blob file queue after merge * Up azure core version for file & queue * Apply all the manual fixes in swagger * Change directoryName to directoryPath * Use non-fluent pattern for generated clients * Fix build after merging with master * Return void on setters * Revert spotbugs config change
alzimmermsft
added a commit
that referenced
this pull request
Jul 30, 2019
* Storage SAS implementation (#4404) * SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue * Remove RawClients from Blobs (#4375) Removes RawClients from Storage Blobs * Add deleteContainer to StorageClient and getBlobClient with Snapshot to ContainerClient (#4376) * Removed raw clients * Added deleteContainer to StorageClient * Added getAppendBlob with snapshot to ContainerClient * Storage queue linting, builder refactor, tests (#4383) * Initial check in for storage queue * Beginning of code snippets for BlobAsyncClient * JavaDoc snippets for BlobAsyncClient and BlobClient * Added links to REST API docs for BlobAsyncClient and BlobClient, fixed JavaDoc issues, fix unit test issues * Removed invalid import
alzimmermsft
added a commit
that referenced
this pull request
Aug 2, 2019
* Removed raw clients * Fixed PageBlob getRange and getRangeDiff, turned on all unit tests * Turned on more tests * Partial work for implementing and testing reliable download options * Storage SAS implementation (#4404) * SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue * Turned on download retry test * RetryTests migrated * Passing most of HelperTest * Fixing tests after merge * Remove RawClients from Blobs (#4375) Removes RawClients from Storage Blobs * DownloadResponseTest working * Fixed scoping for some classes, Checkstyle fixes * Fixing more unit tests * Fix Checkstyle issue * Move adding acount name into String.format * Additional move of adding account name into String.format * Fixed assertGenerateOK logic for SAS generation * Removed invalid import * Fixed method parameter ordering
alzimmermsft
added a commit
that referenced
this pull request
Aug 2, 2019
* Removed raw clients * Added deleteContainer to StorageClient * Merged Blob client builders into BlobClientBuilder * Storage SAS implementation (#4404) * SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue * Remove RawClients from Blobs (#4375) Removes RawClients from Storage Blobs * Added getAppendBlob with snapshot to ContainerClient * Updated Storage and Container clients to use AzureBlobStorageImpl to construct clients * Updating unit tests * Fix a snapshot test
srnagar
pushed a commit
to srnagar/azure-sdk-for-java
that referenced
this pull request
Aug 5, 2019
* Removed raw clients * Added deleteContainer to StorageClient * Merged Blob client builders into BlobClientBuilder * Storage SAS implementation (Azure#4404) * SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue * Remove RawClients from Blobs (Azure#4375) Removes RawClients from Storage Blobs * Added getAppendBlob with snapshot to ContainerClient * Updated Storage and Container clients to use AzureBlobStorageImpl to construct clients * Updating unit tests * Fix a snapshot test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.