eng, sdk automation, migrate to tsp-client 0.7.0+ #39829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+4
to
+6
| sudo apt-get install -y --upgrade python3-pip python3-setuptools 2>&1 | ||
| pip3 install --upgrade wheel 2>&1 | ||
| pip3 install --upgrade PyYAML requests 2>&1 |
There was a problem hiding this comment.
2>&1 is not related to tsp-client
It is an improvement to SDK automation output, to avoid irrelevant info get printed to error message.
| '--tsp-config', tsp_dir, | ||
| '--commit', head_sha, | ||
| '--repo', repo, | ||
| '--local-spec-repo', tsp_dir] |
There was a problem hiding this comment.
--local-spec-repo is the new feature of tsp-client 0.7.0 on init action
|
/check-enforcer override |
weidongxu-microsoft
requested review from
haolingdong-msft,
XiaofeiCao,
ArthurMa1978,
hallipr,
weshaggard,
benbp and
JimSuplizio
as code owners
6 tasks
weshaggard
approved these changes
Apr 22, 2024
|
Verified that it works in pr repo |
|
FYI @catalinaperalta |
|
Yay! Happy is worked! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix Azure/azure-sdk-tools#8050
(this PR is almost a revert on #38983)
tsp-clientshould now work in private repo (with--local-spec-repooption).Sample command line
Verification PR in test env https://github.com/test-repo-billy/azure-rest-api-specs/pull/3297/checks?check_run_id=24088451534
Plan is to merge this PR. Then initialize a test on pr repo. If that works, I would notify other languages that tsp-client migration be feasible.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines