eng, revert tsp-client in sdk automation #38983
Conversation
This reverts commit adbd86a.
|
/check-enforcer override |
weidongxu-microsoft
requested review from
haolingdong-msft,
XiaofeiCao,
ArthurMa1978,
hallipr,
weshaggard,
benbp and
JimSuplizio
as code owners
| check_call(cmd, sdk_root) | ||
|
|
||
| sdk_folder = find_sdk_folder() | ||
| cmd = ['pwsh', './eng/common/scripts/TypeSpec-Project-Process.ps1', tsp_dir, head_sha, repo_url] |
There was a problem hiding this comment.
@weidongxu-microsoft why did this need to be reverted? Do we have a plan to switch back?
There was a problem hiding this comment.
It was due to the failure when the automation runs from a private repo.
PR https://github.com/Azure/azure-rest-api-specs-pr/pull/16496/checks?check_run_id=21889059048
automation passes after this revert PR
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3520093&view=logs&j=a8a7a537-82b0-583c-7971-bac70b9822ca&t=37e3947b-3cfb-5d36-86ba-0e22bb7dbc33&s=eb9754a7-3885-5b5b-bd91-16c95dd7881e
I didn't have time to investigate why it fails (and it's pretty hard to investigate on the pr repo), but the ask is pretty urgent (and Java is the only automation that uses tsp-client). Therefore, I did the revert PR first to unblock service.
We can switch back when we figure out why it fails in private repo.
There was a problem hiding this comment.
Thanks @weidongxu-microsoft for the context.
@catalinaperalta based on Azure/azure-sdk-tools#7292 I thought we supported the private repo. Is there a bug or more work to be done to enable it?
There was a problem hiding this comment.
issue on azure-sdk-tools Azure/azure-sdk-tools#8012
There was a problem hiding this comment.
Will take a look, I missed the original notification on this thread. Thanks for opening an issue!
There was a problem hiding this comment.
IIRC in the pipeline we'd need to have git credentials configured for the git sparse checkout command to work. A few months ago I spoke to Ben about this since I'd seen this issue Azure/azure-sdk-tools#3222 opened about this exact scenario. I think we'd need to have a PAT or git credentials configured in the pipeline for this to work. Locally for private spec repo support we rely on folks already being logged in with git/having their credentials configured. If we want to use a PAT in the pipeline...then I think there would be additional work to do in tsp-client. Otherwise if we can configure credentials in the pipeline like it's mentioned in this comment, I believe tsp-client should work as is.
Revert PR #38563
There could be potential problem on tsp-client running automation on private repo.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines