Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming methods/classes based on review. #24474

Merged
merged 12 commits into from
Oct 4, 2021
Merged

Renaming methods/classes based on review. #24474

merged 12 commits into from
Oct 4, 2021

Conversation

conniey
Copy link
Member

@conniey conniey commented Sep 30, 2021

Based on architecture board review:

  • Rename SerializationType -> SerializationFormat
  • endpoint -> fullyQualifiedNamespace
    • fullyQualifiedNamespace does not require a protocol (ie. https://) so removing that validation.
  • Adding SchemaRegistryVersion and exposing it in builder.

Related #24221

@conniey conniey added Client This issue points to a problem in the data-plane of the library. Schema Registry labels Sep 30, 2021
@conniey conniey self-assigned this Sep 30, 2021
@azure-sdk
Copy link
Collaborator

API changes have been detected in this PR. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in this PR. You can review API changes here

lmolkova
lmolkova reviewed Sep 30, 2021
View reviewed changes
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at APIview and found a couple of issues there, sorry for another round of comments :)

...a-schemaregistry/src/main/java/com/azure/data/schemaregistry/models/SerializationFormat.java Outdated Show resolved Hide resolved
...-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryClientBuilder.java Outdated Show resolved Hide resolved
@conniey conniey closed this Oct 4, 2021
@conniey conniey reopened this Oct 4, 2021
@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-data-schemaregistry. You can review API changes here

@conniey conniey merged commit 6bb5653 into Azure:main Oct 4, 2021
@conniey conniey deleted the schema-registry/archboard-renames branch October 4, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova approved these changes

@sjkwak sjkwak Awaiting requested review from sjkwak

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

Assignees

@conniey conniey

Labels
Client This issue points to a problem in the data-plane of the library. Schema Registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conniey @azure-sdk @lmolkova