Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema Registry: Architecture Board review feedback #24221

Closed
6 of 11 tasks
conniey opened this issue Sep 20, 2021 · 1 comment
Closed
6 of 11 tasks

Schema Registry: Architecture Board review feedback #24221

conniey opened this issue Sep 20, 2021 · 1 comment
Assignees
@conniey
Labels
Client This issue points to a problem in the data-plane of the library. Schema Registry
Milestone
[2022] March

Comments

@conniey
Copy link
Member

conniey commented Sep 20, 2021 •
edited
Loading

Schema Registry

  • Rename endpoint to fullyQualifiedNamespace in constructor (discuss with feature crew to decide on name)
  • Add read-only fullyQualifiedNamespace property
  • Add back Response for all methods and remove caching
  • Investigate using BinaryData instead of string as the type for the Content parameter and property type in SchemaRegistrySchema
  • Rename content parameter to schemaDefinition
  • Once GA service version is available, add it to ServiceVersion enum and remove the preview, and 2017 ones
  • Rename SerializationType to SchemaFormat (property could be either Format or SchemaFormat - since we are already in the SchemaProperties)

Avro Serializer

  • Implement an LRU cache with 128 max entries - this does not need to be configurable for GA.
  • Make the groupName parameter optional in the constructor (discussed this offline with Ted)

Docs

  • Come up with guidance around the recommended use of AutoRegisterSchema and make sure it aligns with our default value.
  • Go through Ted's feedback on the .NET README (and give feedback where it is relevant for other languages)

Related Azure/azure-sdk-for-js#17697
@conniey conniey added Client This issue points to a problem in the data-plane of the library. Schema Registry labels Sep 20, 2021
@conniey conniey self-assigned this Sep 20, 2021
This was referenced Sep 27, 2021
Merged
Merged
@deyaaeldeen
Copy link
Member

@conniey we should Rename endpoint to fullyQualifiedNamespace instead.

This was referenced Sep 30, 2021
Merged
Merged
Merged
@conniey conniey changed the title Architecture Board review. Schema Registry: Architecture Board review feedback Oct 7, 2021
@ramya-rao-a ramya-rao-a added this to the [2022] March milestone Jan 13, 2022
@conniey conniey closed this as completed Jan 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@conniey conniey

Labels
Client This issue points to a problem in the data-plane of the library. Schema Registry
Projects
None yet
Milestone
[2022] March
Development

No branches or pull requests
3 participants
@deyaaeldeen @conniey @ramya-rao-a