[Automation] Generate Fluent Lite from iothub#package-2020-03 #21237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
requested review from
ChenTanyi,
weidongxu-microsoft and
yungezz
as code owners
|
Regenerating this control plane SDK to account for a fix in the swagger here. However, it looks like the control plane SDK wasn't doing this validation anyways, so this update just brings in some comment updates from the swagger and some implementation detail changes. |
weidongxu-microsoft
approved these changes
May 10, 2021
| @@ -124,7 +124,7 @@ | |||
| CertificateDescription.Update update(); | |||
|
|
|||
| /** The template for CertificateDescription update. */ | |||
| interface Update extends UpdateStages.WithCertificate, UpdateStages.WithIfMatch { | |||
| interface Update extends UpdateStages.WithCertificate, UpdateStages.WithifMatch { | |||
There was a problem hiding this comment.
I need to double check codegen on this. Seems should be WithIfMatch.withIfMatch.
Fixed in Azure/autorest.java#1020
I will generate it again, after codegen upgrade.
There was a problem hiding this comment.
Sure, I'll hold off on merging until this gets regenerated
There was a problem hiding this comment.
Fix integrated to pipeline.
However you might want wait for a few days for azure-identity May release done.
|
Here is the newly generated PR #21383 |
|
I'll go ahead and close this PR then, since #21383 replaces it |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Oct 25, 2022
Release appcomplianceautomation microsoft.app compliance automation 2022 11 16 preview 1 (Azure#21074) * add appcomplianceautomation specs * update appcomplianceautomation specs for 2022-11-16-preview * remove privatepreview and beta (Azure#21124) Co-authored-by: Yanwen Liu <[email protected]> * Release appcomplianceautomation microsoft.app compliance automation 2022 11 16 preview resolve comments 2 (Azure#21152) * fix comments * remove duplicate in body * resolve comments * edit examples to match schema * fix failure * fix model validation * change passed to passedCount * add x-ms-enum to isPass * change delete 200 description Co-authored-by: Yanwen Liu <[email protected]> * set sasUri x-ms-secret to true (Azure#21161) Co-authored-by: Yanwen Liu <[email protected]> * remove properties from download request body (Azure#21184) * remove properties from download request body * remove properties in snapshot_resourcelist_download.json * keep statuscode 201 and 202 in patch report response, due to RPSaas will change 202 to 201 * add body in patch report 201 response Co-authored-by: Yanwen Liu <[email protected]> * change ProvisioningState Cancelled to Canceled, and some descriptions (Azure#21237) * change ProvisioningState Cancelled to Canceled, and some descriptions * add x-ms-enum extension to ComplianceState Co-authored-by: Yanwen Liu <[email protected]> Co-authored-by: Yanwen Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Automation] Generate Fluent Lite from iothub#package-2020-03