Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Paging to Use a Predicate to Determine Continuation #21124

Merged

Conversation

alzimmermsft
Copy link
Member

This PR enables the paging APIs to use a Predicate to determine if paging should continue.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core labels May 3, 2021
@alzimmermsft alzimmermsft self-assigned this May 3, 2021
@check-enforcer
Copy link

check-enforcer bot commented May 4, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@alzimmermsft alzimmermsft requested a review from srnagar May 4, 2021 18:29
@alzimmermsft alzimmermsft added this to the [2021] June milestone May 5, 2021
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alzimmermsft alzimmermsft merged commit 0ee26bb into Azure:master May 14, 2021
@alzimmermsft alzimmermsft deleted the AzCore_HookForPageContinuation branch May 14, 2021 00:34
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Oct 25, 2022
Release appcomplianceautomation microsoft.app compliance automation 2022 11 16 preview 1 (Azure#21074)

* add appcomplianceautomation specs

* update appcomplianceautomation specs for 2022-11-16-preview

* remove privatepreview and beta (Azure#21124)

Co-authored-by: Yanwen Liu <[email protected]>

* Release appcomplianceautomation microsoft.app compliance automation 2022 11 16 preview resolve comments 2 (Azure#21152)

* fix comments

* remove duplicate in body

* resolve comments

* edit examples to match schema

* fix failure

* fix model validation

* change passed to passedCount

* add x-ms-enum to isPass

* change delete 200 description

Co-authored-by: Yanwen Liu <[email protected]>

* set sasUri x-ms-secret to true (Azure#21161)

Co-authored-by: Yanwen Liu <[email protected]>

* remove properties from download request body (Azure#21184)

* remove properties from download request body

* remove properties in snapshot_resourcelist_download.json

* keep statuscode 201 and 202 in patch report response, due to RPSaas will change 202 to 201

* add body in patch report 201 response

Co-authored-by: Yanwen Liu <[email protected]>

* change ProvisioningState Cancelled to Canceled, and some descriptions (Azure#21237)

* change ProvisioningState Cancelled to Canceled, and some descriptions

* add x-ms-enum extension to ComplianceState

Co-authored-by: Yanwen Liu <[email protected]>

Co-authored-by: Yanwen Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants