-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method on entities for concatenating locations #29
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add method on entities for concatenating locations
This eliminates some repetition in the location client by implementing Stringer on a LocationList as a comma separated list of the location names.
- Loading branch information
commit 6ab955f93ad88ff130d5405f44fd4f5288ba57d3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,10 @@ | ||
package locationClient | ||
|
||
import ( | ||
"bytes" | ||
"encoding/xml" | ||
"errors" | ||
"fmt" | ||
azure "github.com/MSOpenTech/azure-sdk-for-go" | ||
"strings" | ||
) | ||
|
||
const ( | ||
|
@@ -32,12 +30,7 @@ func ResolveLocation(location string) error { | |
return nil | ||
} | ||
|
||
var availableLocations bytes.Buffer | ||
for _, existingLocation := range locations.Locations { | ||
availableLocations.WriteString(existingLocation.Name + ", ") | ||
} | ||
|
||
return errors.New(fmt.Sprintf(invalidLocationError, location, strings.Trim(availableLocations.String(), ", "))) | ||
return errors.New(fmt.Sprintf(invalidLocationError, location, locations.String())) | ||
} | ||
|
||
func GetLocationList() (LocationList, error) { | ||
|
@@ -74,10 +67,5 @@ func GetLocation(location string) (*Location, error) { | |
return &existingLocation, nil | ||
} | ||
|
||
var availableLocations bytes.Buffer | ||
for _, existingLocation := range locations.Locations { | ||
availableLocations.WriteString(existingLocation.Name + ", ") | ||
} | ||
|
||
return nil, errors.New(fmt.Sprintf(invalidLocationError, location, strings.Trim(availableLocations.String(), ", "))) | ||
return nil, errors.New(fmt.Sprintf(invalidLocationError, location, locations.String())) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.String()
is redundant