Add method on entities for concatenating locations #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates some repetition in the location client by implementing Stringer on a LocationList as a comma separated list of the location names.
| } | ||
|
|
||
| return errors.New(fmt.Sprintf(invalidLocationError, location, strings.Trim(availableLocations.String(), ", "))) | ||
| return errors.New(fmt.Sprintf(invalidLocationError, location, locations.String())) |
|
also please consider using |
|
@ahmetalpbalkan that was due to a missing email address on GitHub - not sure where it went... All fixed now. |
|
LGTM |
|
Signed. Was fairly sure I'd done that in the past but apparently before that system! |
ruslangabitov
added a commit
that referenced
this pull request
Feb 1, 2015
Add method on entities for concatenating locations
marstr
pushed a commit
to marstr/azure-sdk-for-go
that referenced
this pull request
Apr 27, 2017
* Added missing parameters As a bonus, updated all documentation links * Fix Travis * Comments from review
marstr
pushed a commit
that referenced
this pull request
Apr 28, 2017
* Added missing parameters As a bonus, updated all documentation links * Fix Travis * Comments from review
mcardosos
added a commit
that referenced
this pull request
May 4, 2017
* Added missing parameters As a bonus, updated all documentation links * Fix Travis * Comments from review
AutorestCI
added a commit
that referenced
this pull request
Aug 21, 2019
Merge pull request #29 from leonardbf/ANF-169-add-07-swagger ANF-169 add 2019-07-01 swagger
richardpark-msft
pushed a commit
to richardpark-msft/azure-sdk-for-go
that referenced
this pull request
Aug 5, 2021
benbp
pushed a commit
to benbp/azure-sdk-for-go
that referenced
this pull request
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #26.
This eliminates some repetition in the location client by implementing Stringer on a LocationList as a comma separated list of the location names.