Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] sdk/resourcemanager/appconfiguration/armappconfiguration/2.0.0 #20589

Merged

Conversation

azure-sdk
Copy link
Collaborator

…0.0 generation from spec commit: 1f22d4dbd99b0fe347ad79e79d4eb1ed44a87291
@Alancere
Copy link
Contributor

Alancere commented Apr 11, 2023

The breaking changes are introduced and approved in this PR.

…-appconfiguration-armappconfiguration-2.0.0-1681175827
@tadelesh
Copy link
Member

@JeffreyRichter please review and approve this major version release.

@JeffreyRichter
Copy link
Member

What are you asking me to do here? If the service broke, then this package must break too and that requires a major version update. Is there anything for me to think about or just want me to add some label?

@tadelesh
Copy link
Member

tadelesh commented Apr 20, 2023

What are you asking me to do here? If the service broke, then this package must break too and that requires a major version update. Is there anything for me to think about or just want me to add some label?

Since Go major version will have more impact to the customer, Rick is asking that we need get approval from you for each major version release. For each release with breaking change, we will attach the service swagger breaking PR which always already get approval from breaking change review board. If there is no further concern, you could just add a label Approved Major Version, then we can continue with the release. Thank you so much.

@Alancere Alancere merged commit 6458592 into main Apr 26, 2023
@Alancere Alancere deleted the release-appconfiguration-armappconfiguration-2.0.0-1681175827 branch April 26, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants