[Hub Generated] Publish private branch 'user/jimmyca/fixAppConfigSpec' #19882

jimmyca15 · 2022-07-21T16:20:27Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

* Remove list key values operation. * Update description for PUT private endpoint connection to be clear it can't be used to create. * Added example for list operations API.

jimmyca15 · 2022-07-21T16:20:29Z

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/7780

openapi-workflow-bot · 2022-07-21T16:20:30Z

Hi, @jimmyca15 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-07-21T16:20:32Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
appconfiguration.json	2022-05-01(7abd680)	2022-05-01(main)

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/keyValues' removed or restructured? Old: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L815:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2022-05-01	package-2022-05-01(7abd680)	package-2022-05-01(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L154
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L216
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L240
`❌` LroPatch202	The async patch operation should return 202. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L289
`❌` ResourceNameRestriction	The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L562
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L610
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L673
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L704
`❌` ResourceNameRestriction	The resource name parameter 'groupName' should be defined with a 'pattern' restriction. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L770
`❌` ResourceNameRestriction	The resource name parameter 'keyValueName' should be defined with a 'pattern' restriction. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L819
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L923
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L954
`❌` PostOperationAsyncResponseValidation	An async POST operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L1057
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L1082
`❌` XmsParameterLocation	The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L2186
`❌` XmsParameterLocation	The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L2212
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L154
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L216
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L260
⚠️ RequiredReadOnlySystemData	The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L563
⚠️ RequiredReadOnlySystemData	The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L610
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L610
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L673
⚠️ RequiredReadOnlySystemData	The response of operation:'KeyValues_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L820
⚠️ RequiredReadOnlySystemData	The response of operation:'KeyValues_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L867
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L923
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L1057
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationStores_CheckNameAvailable Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L1143
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationStores_CheckNameNotAvailable Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L1143
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L1260

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

Operation coverage: total: 0, untested: 0, failed: 0, passed: 0

Traffic Validation is finished. Check pipeline artifact for detail report.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-07-21T16:20:32Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - armappconfiguration - Approved - 2.0.0

+	Field `KeyValueParameters` of struct `KeyValuesClientCreateOrUpdateOptions` has been removed
+	Function `*KeyValuesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, *KeyValuesClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, KeyValue, *KeyValuesClientCreateOrUpdateOptions)`
+	Function `*KeyValuesClient.NewListByConfigurationStorePager` has been removed
+	Struct `KeyValuesClientListByConfigurationStoreOptions` has been removed
+	Struct `KeyValuesClientListByConfigurationStoreResponse` has been removed

❌azure-sdk-for-python-track2 - track2_azure-mgmt-appconfiguration - Approved - 2.2.0

+	Removed operation KeyValuesOperations.list_by_configuration_store

❌azure-sdk-for-js - @azure/arm-appconfiguration - Approved - 4.0.0

+	Interface ConfigurationStoresListByResourceGroupNextOptionalParams no longer has parameter skipToken
+	Interface ConfigurationStoresListKeysNextOptionalParams no longer has parameter skipToken
+	Interface ConfigurationStoresListNextOptionalParams no longer has parameter skipToken
+	Interface OperationsListNextOptionalParams no longer has parameter skipToken
+	Removed operation KeyValues.listByConfigurationStore

❌azure-sdk-for-go - sdk/resourcemanager/appconfiguration/armappconfiguration - Approved - 2.0.0

+	Function `*KeyValuesClient.NewListByConfigurationStorePager` has been removed
+	Struct `KeyValuesClientListByConfigurationStoreResponse` has been removed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 2c4244e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-appconfiguration [View full logs] [Release SDK Changes] Breaking Change Detected
- azure_mgmt_appconfiguration-2.2.0-py3-none-any.whl
- azure-mgmt-appconfiguration-2.2.0.zip
```
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Removed operation KeyValuesOperations.list_by_configuration_store
```

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 2c4244e. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 760 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.AppConfiguration [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 2c4244e. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appconfiguration [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2c4244e. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appconfiguration [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-appconfiguration-4.0.0.tgz

info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation KeyValues.listByConfigurationStore
info	[Changelog]   - Interface ConfigurationStoresListByResourceGroupNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface ConfigurationStoresListKeysNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface ConfigurationStoresListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface OperationsListNextOptionalParams no longer has parameter skipToken

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2c4244e. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appconfiguration/armappconfiguration [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*KeyValuesClient.NewListByConfigurationStorePager` has been removed
info	[Changelog] - Struct `KeyValuesClientListByConfigurationStoreResponse` has been removed
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 0 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 2c4244e. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️appconfiguration [View full logs]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2c4244e. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.AppConfiguration [View full logs] [Release SDK Changes]
- Az.AppConfiguration.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-07-21T16:22:59Z

Hi @jimmyca15, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2022-07-21T16:23:29Z

Hi @jimmyca15, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

jimmyca15 · 2022-07-21T16:24:07Z

All breaking changes have been approved in the private repo PR.

jimmyca15 · 2022-07-25T20:37:35Z

Hello @qiaozha please let me know if there is anything I need to do to complete this PR. All approvals, including breaking change approval can be found in the private branch PR that this was published from.

jimmyca15 · 2022-08-01T19:51:21Z

Hello @qiaozha

The breaking changes for this were approved in the private repo. can we merge this?

qiaozha · 2022-08-04T01:57:03Z

@jimmyca15 Can you fix the avocado failure and prettier check failure ?

qiaozha · 2022-08-04T02:16:07Z

The api breaking change is approved in previous private repo PR.

...guration/resource-manager/Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json

ArcturusZhang

I saw there are the reasons in the corresponding private PR. Approved

qiaozha · 2023-01-04T01:48:56Z

@jimmyca15 can you fix the swagger model validation errors ?

qiaozha · 2023-01-04T01:51:32Z

Also, there's staging lint diff error

jimmyca15 · 2023-01-12T17:26:39Z

@qiaozha Wouldn't fixing those model validation errors be an unapproved breaking change?

Also, the lint diff error is the approved breaking change this PR is making. Is there a way for me to silence that lint diff error?

qiaozha · 2023-01-13T10:14:08Z

@raych1 Can you help take a look at the Model Validation error ? Thanks

qiaozha · 2023-01-13T10:18:35Z

specification/appconfiguration/resource-manager/readme.md

+  - suppress: R4015
+    from: appconfiguration.json
+    where: $.definitions.KeyValue
+  - suppress: R3010
+    from: appconfiguration.json
+    where: $.definitions.KeyValue


@jianyexi Can you help review the suppression directive here ? Thanks

qiaozha · 2023-01-13T10:22:47Z

@ArcturusZhang Can you help take a look at the dotnet sdk track2 generation error ? Thanks

jimmyca15 · 2023-02-01T23:22:09Z

@qiaozha I see you mentioned some people. Should I be reaching out to these individuals for the concerns you mentioned? We really need this checked in.

Please note that all these breaking changes were requested and approved in the private repo PR this was generated from.

https://github.com/Azure/azure-rest-api-specs-pr/pull/7780

specification/appconfiguration/resource-manager/readme.md

raych1 · 2023-02-02T02:14:12Z

@jimmyca15 , please refer to this example to add LRO headers to swagger examples to fix model validation errors.

jimmyca15 · 2023-02-02T22:49:05Z

@raych1 I have added it and resolved the model validation errors.

jimmyca15 added 2 commits July 15, 2022 10:37

Update swagger to match service implementation.

6e1502f

* Remove list key values operation. * Update description for PUT private endpoint connection to be clear it can't be used to create. * Added example for list operations API.

Add suggested message.

3065a3f

openapi-assignment-bot bot assigned qiaozha Jul 21, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jul 21, 2022

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jul 21, 2022

azure-sdk mentioned this pull request Jul 21, 2022

[AutoPR armappconfiguration] [Hub Generated] Publish private branch 'user/jimmyca/fixAppConfigSpec' azure-sdk/azure-sdk-for-go#1796

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jul 21, 2022

azure-sdk mentioned this pull request Jul 21, 2022

[AutoPR track2_azure-mgmt-appconfiguration] [Hub Generated] Publish private branch 'user/jimmyca/fixAppConfigSpec' azure-sdk/azure-sdk-for-python#861

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Jul 21, 2022

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Jul 21, 2022

azure-sdk mentioned this pull request Jul 21, 2022

[AutoPR Az.AppConfiguration] [Hub Generated] Publish private branch 'user/jimmyca/fixAppConfigSpec' azure-sdk/azure-powershell#1407

Closed

Fix lint errors.

bcafb23

qiaozha added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 4, 2022

ArcturusZhang requested changes Aug 4, 2022

View reviewed changes

...guration/resource-manager/Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json Show resolved Hide resolved

ArcturusZhang approved these changes Aug 4, 2022

View reviewed changes

Fix prettier and avocado.

c1b4771

qiaozha reviewed Jan 13, 2023

View reviewed changes

qiaozha added the Approved-SdkBreakingChange-JavaScript label Feb 2, 2023

msyyc added the Approved-SdkBreakingChange-Python label Feb 2, 2023

jianyexi reviewed Feb 2, 2023

View reviewed changes

specification/appconfiguration/resource-manager/readme.md Outdated Show resolved Hide resolved

jianyexi reviewed Feb 2, 2023

View reviewed changes

specification/appconfiguration/resource-manager/readme.md Outdated Show resolved Hide resolved

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Feb 2, 2023

jimmyca15 force-pushed the published/jimmyca15/azure-rest-api-specs-pr/user/jimmyca/fixAppConfigSpec branch from 635a22f to 6d6032b Compare February 2, 2023 19:17

fix model validation with LRO header.

7abd680

jimmyca15 force-pushed the published/jimmyca15/azure-rest-api-specs-pr/user/jimmyca/fixAppConfigSpec branch from 6d6032b to 7abd680 Compare February 2, 2023 22:07

AzureRestAPISpecReview removed the CI-FixRequiredOnFailure label Feb 2, 2023

qiaozha approved these changes Feb 3, 2023

View reviewed changes

qiaozha merged commit 2c4244e into main Feb 3, 2023

qiaozha deleted the published/jimmyca15/azure-rest-api-specs-pr/user/jimmyca/fixAppConfigSpec branch February 3, 2023 02:00

tadelesh mentioned this pull request Apr 19, 2023

[Release] sdk/resourcemanager/appconfiguration/armappconfiguration/2.0.0 Azure/azure-sdk-for-go#20589

Merged

kazrael2119 mentioned this pull request Apr 21, 2023

appconfiguration release Azure/azure-sdk-for-js#25472

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Publish private branch 'user/jimmyca/fixAppConfigSpec' #19882

[Hub Generated] Publish private branch 'user/jimmyca/fixAppConfigSpec' #19882

jimmyca15 commented Jul 21, 2022

jimmyca15 commented Jul 21, 2022

openapi-workflow-bot bot commented Jul 21, 2022

openapi-pipeline-app bot commented Jul 21, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jul 21, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jul 21, 2022

openapi-workflow-bot bot commented Jul 21, 2022

jimmyca15 commented Jul 21, 2022

jimmyca15 commented Jul 25, 2022

jimmyca15 commented Aug 1, 2022

qiaozha commented Aug 4, 2022

qiaozha commented Aug 4, 2022

ArcturusZhang left a comment

qiaozha commented Jan 4, 2023

qiaozha commented Jan 4, 2023

jimmyca15 commented Jan 12, 2023

qiaozha commented Jan 13, 2023

qiaozha Jan 13, 2023

qiaozha commented Jan 13, 2023

jimmyca15 commented Feb 1, 2023

raych1 commented Feb 2, 2023

jimmyca15 commented Feb 2, 2023

[Hub Generated] Publish private branch 'user/jimmyca/fixAppConfigSpec' #19882

[Hub Generated] Publish private branch 'user/jimmyca/fixAppConfigSpec' #19882

Conversation

jimmyca15 commented Jul 21, 2022

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

jimmyca15 commented Jul 21, 2022

openapi-workflow-bot bot commented Jul 21, 2022

openapi-pipeline-app bot commented Jul 21, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jul 21, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jul 21, 2022

openapi-workflow-bot bot commented Jul 21, 2022

jimmyca15 commented Jul 21, 2022

jimmyca15 commented Jul 25, 2022

jimmyca15 commented Aug 1, 2022

qiaozha commented Aug 4, 2022

qiaozha commented Aug 4, 2022

ArcturusZhang left a comment

Choose a reason for hiding this comment

qiaozha commented Jan 4, 2023

qiaozha commented Jan 4, 2023

jimmyca15 commented Jan 12, 2023

qiaozha commented Jan 13, 2023

qiaozha Jan 13, 2023

Choose a reason for hiding this comment

qiaozha commented Jan 13, 2023

jimmyca15 commented Feb 1, 2023

raych1 commented Feb 2, 2023

jimmyca15 commented Feb 2, 2023

openapi-pipeline-app bot commented Jul 21, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jul 21, 2022 •

edited

Loading