Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for storage managed disk challenge #20418

Merged
merged 10 commits into from
Mar 27, 2023
Merged

Added support for storage managed disk challenge #20418

merged 10 commits into from
Mar 27, 2023

Conversation

gapra-msft
Copy link
Member

@gapra-msft gapra-msft commented Mar 15, 2023 •
edited
Loading

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

Resolves #20355

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Mar 15, 2023
@jhendrixMSFT
Copy link
Member

Is it possible to add a live/recorded test at least for page blobs to test this?

@vibhansa-msft vibhansa-msft added this to the azblob v1.0.1 milestone Mar 17, 2023
@gapra-msft
Copy link
Member Author

Is it possible to add a live/recorded test at least for page blobs to test this?

A live/recorded test might be hard since the Disk needs a specific role (not sure how to do this programmatically) and then we have to invoke the compute management plane SDK. I've added a comment of my test and what is required for the test to work. The mock tests should be sufficient

@gapra-msft gapra-msft merged commit a36c563 into main Mar 27, 2023
@gapra-msft gapra-msft deleted the gapra/managedDiskChallenge branch March 27, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibhansa-msft vibhansa-msft vibhansa-msft approved these changes

@souravgupta-msft souravgupta-msft souravgupta-msft approved these changes

@siminsavani-msft siminsavani-msft siminsavani-msft approved these changes

@tasherif-msft tasherif-msft Awaiting requested review from tasherif-msft

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT jhendrixMSFT is a code owner

Assignees
No one assigned
Labels
AzBlob Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
azblob v1.0.1
Development

Successfully merging this pull request may close these issues.

Support bearer challenge for identity based managed disks
5 participants
@gapra-msft @jhendrixMSFT @vibhansa-msft @siminsavani-msft @souravgupta-msft