Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bearer challenge for identity based managed disks #20355

Closed
jhendrixMSFT opened this issue Mar 7, 2023 · 2 comments · Fixed by #20418
Closed

Support bearer challenge for identity based managed disks #20355

jhendrixMSFT opened this issue Mar 7, 2023 · 2 comments · Fixed by #20418
Assignees
@vibhansa-msft @siminsavani-msft
Labels
AzBlob feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)
Milestone
azblob v1.0.1

Comments

@jhendrixMSFT
Copy link
Member

OAuth with managed disks, a special kind of page blob, needs to support bearer challenge.
@jhendrixMSFT jhendrixMSFT added the Storage Storage Service (Queues, Blobs, Files) label Mar 7, 2023
@vibhansa-msft vibhansa-msft added this to the azblob v1.0.1 milestone Mar 8, 2023
@vibhansa-msft
Copy link
Member

This goes in Identity package or azidentity alredy has the support and we need to add it to azblob sdk.

@vibhansa-msft vibhansa-msft added the feature-request This issue requires a new behavior in the product in order be resolved. label Mar 8, 2023
@jhendrixMSFT
Copy link
Member Author

The bearer token policy has extensibility points for handling challenges.

https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azcore/policy/policy.go#L136

Here's an example of how keyvault uses it.

https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/keyvault/internal/challenge_policy.go#L54-L55

@gapra-msft gapra-msft mentioned this issue Mar 15, 2023
Merged
5 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vibhansa-msft vibhansa-msft

@siminsavani-msft siminsavani-msft

Labels
AzBlob feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
azblob v1.0.1
Development

Successfully merging a pull request may close this issue.

Added support for storage managed disk challenge Azure/azure-sdk-for-go
3 participants
@jhendrixMSFT @vibhansa-msft @siminsavani-msft