Clean up version requirements #4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antkmsft
requested review from
danieljurek,
weshaggard,
LarryOsterman,
RickWinter,
vinjiang,
Jinming-Hu,
EmmaZhu,
vhvb1989,
gearama,
microzchang,
gkostal,
anilba06,
ahmadmsft,
ahsonkhan and
schaabs
as code owners
ahsonkhan
reviewed
Jul 20, 2023
ahsonkhan
reviewed
Jul 20, 2023
What happens for customers who may not be using vcpkg, and building the source directly? |
|
@ahsonkhan, we don't have a documented story of building the SDK without vcpkg. If SDK is built without vcpkg, customers will have to ensure the version correctness themselves, at least until we have a better story. |
LarryOsterman
approved these changes
Jul 20, 2023
ahsonkhan
reviewed
Jul 20, 2023
ahsonkhan
reviewed
Jul 20, 2023
ahsonkhan
reviewed
Aug 14, 2023
Comment on lines
+38
to
+39
| ], | ||
| "version>=": "7.44" |
There was a problem hiding this comment.
This change resulted in 7.44 showing up here:
microsoft/vcpkg#32971
And looks like the oldest version of curl listed in the version databse within he catalog is 7.48:
https://github.com/microsoft/vcpkg/blob/master/versions/c-/curl.json#L425
So, to make that work, we got bumped up by vcpkg, here:
microsoft/vcpkg#33109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version numbers are enforced by
"version>="invcpkg.json.They are not necessary in
find_package()orfind_dependency(), which, by the way, can't handle semvers.