Add back package versions to the FolderList.cmake and remove EventHubs from the list for now #4811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from the list for now
ahsonkhan
requested review from
RickWinter,
antkmsft,
vhvb1989,
gearama and
LarryOsterman
as code owners
LarryOsterman
requested changes
Jul 20, 2023
|
What can I put as the versions for its dependencies, like azure-core-amqp? |
The current published version of azure-core-amqp seems like a reasonable version number for AMQP - that would be 1.0.0-beta.1, I believe. |
… within FolderList.cmake
LarryOsterman
approved these changes
Jul 20, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially, reverting the change from #4755 (comment) since it broke CI and blocking PRs like:
#4809
Fixes #4810