Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of DownloadDepVersion macro broken with incorrect number of arguments passed #4810

Closed
ahsonkhan opened this issue Jul 20, 2023 · 1 comment · Fixed by #4811
Closed

Use of DownloadDepVersion macro broken with incorrect number of arguments passed #4810

ahsonkhan opened this issue Jul 20, 2023 · 1 comment · Fixed by #4811
Labels
EngSys This issue is impacting the engineering system.

Comments

@ahsonkhan
Copy link
Member

These pipeline steps are failing during cmake generate, for cpp - identity - ci:

  • CMakeGeneration CMakeSourceGenerate Mac
  • CMakeGeneration CMakeSourceGenerate Linux
  • CMakeSourceGenerate Windows

https://dev.azure.com/azure-sdk/public/_build/results?buildId=2932792&view=logs&j=b9880498-e2fd-50d4-6c78-d5fd2872f1b4&t=b998b90c-fd13-5cc9-4b97-e7c86beef274

2023-07-20T00:01:12.7090311Z setting up compile options for IDENTITY
2023-07-20T00:01:12.7097752Z No transport adapter was selected, using WinHTTP as the default option for Windows.
2023-07-20T00:01:12.7106608Z project found IDENTITY
2023-07-20T00:01:12.7106994Z FLAG VALUE : ON
2023-07-20T00:01:12.7107602Z CMake Error at D:/a/_work/1/s/cmake-modules/FolderList.cmake:8 (DownloadDepVersion):
2023-07-20T00:01:12.7108205Z   DownloadDepVersion Macro invoked with incorrect arguments for macro named:
2023-07-20T00:01:12.7108633Z   DownloadDepVersion
2023-07-20T00:01:12.7108974Z Call Stack (most recent call first):
2023-07-20T00:01:12.7110073Z   CMakeLists.txt:35 (GetFolderList)
2023-07-20T00:01:12.7110466Z 
2023-07-20T00:01:12.7110658Z 
2023-07-20T00:01:12.9281752Z -- Found OpenSSL: optimized;D:/a/_work/1/s/sdk/identity/azure-identity/build/vcpkg_installed/x64-windows/lib/libcrypto.lib;debug;D:/a/_work/1/s/sdk/identity/azure-identity/build/vcpkg_installed/x64-windows/debug/lib/libcrypto.lib (found version "3.1.1")  
2023-07-20T00:01:12.9292768Z -- Retrieving version from D:/a/_work/1/s/sdk/identity/azure-identity/src/private/package_version.hpp
2023-07-20T00:01:12.9293413Z -- VERSION_MAJOR 1
2023-07-20T00:01:12.9293849Z -- VERSION_MINOR 6
2023-07-20T00:01:12.9294257Z -- VERSION_PATCH 0
2023-07-20T00:01:12.9294660Z -- VERSION_PRERELEASE beta.1
2023-07-20T00:01:12.9295100Z -- AZ_LIBRARY_VERSION 
2023-07-20T00:01:13.1240672Z -- Configuring incomplete, errors occurred!
2023-07-20T00:01:13.1986652Z ##[error]Cmd.exe exited with code '1'.
2023-07-20T00:01:13.2219898Z ##[section]Finishing: cmake generate

The error seems to be related to this macro:

elseif(${project} STREQUAL IDENTITY)
DownloadDepVersion(sdk/core azure-core)

From the CI run in #4809

@LarryOsterman The change introduced in #4755 to remove the versions likely caused this to break, since the DownloadDepVersion macro requires 3 parameters:
https://github.com/Azure/azure-sdk-for-cpp/blob/ccf54545c0a8edeeaa17bb66dbe468dad7a13ae7/cmake-modules/FolderList.cmake#L65C7-L65C25

@ahsonkhan ahsonkhan added the EngSys This issue is impacting the engineering system. label Jul 20, 2023
@LarryOsterman
Copy link
Member

That change was made at the explicit request of @antkmsft, he indicated that the CI system would be broken without it.

Any suggestions about how to reconcile these two changes would be appreciated. For now, I'd just put the change back.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
2 participants