Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added properties that were missed in 2019-11-01-preview API version. #9002

Merged
merged 3 commits into from
May 1, 2020
Merged

Added properties that were missed in 2019-11-01-preview API version. #9002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35dc281
Added properties that were missed in 2019-11-01-preview API version.
jimmyca15 Apr 9, 2020
6d35f78
Fixed prettier.
jimmyca15 Apr 13, 2020
35968c0
Added readonly to private endpoint connections.
jimmyca15 Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions ...ource-manager/Microsoft.AppConfiguration/preview/2019-11-01-preview/appconfiguration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,6 +939,26 @@
"encryption": {
"$ref": "#/definitions/EncryptionProperties",
"description": "The encryption settings of the configuration store."
},
"privateEndpointConnections": {
jimmyca15 marked this conversation as resolved.
Show resolved Hide resolved
"description": "The list of private endpoint connections that are set up for this resource.",
"type": "array",
"readOnly": true,
"items": {
"$ref": "#/definitions/PrivateEndpointConnectionReference"
}
},
"publicNetworkAccess": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this one. Adding non-readonly property to response is considered breaking change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullMDR Public network access needs to be editable. We haven't made a breaking change before but we thought we would be able to since our API version is preview. Please let me know if that is not the case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullMDR This API needs to be editable and we are under the assumption that we can fix this because this is a preview version. Please let me know if this is not the case. Thanks!

"description": "Control permission for data plane traffic coming from public networks while private endpoint is enabled.",
"enum": [
"Enabled",
"Disabled"
],
"type": "string",
"x-ms-enum": {
"name": "PublicNetworkAccess",
"modelAsString": true
}
}
}
},
Expand All @@ -952,6 +972,32 @@
}
}
},
"PrivateEndpointConnectionReference": {
"type": "object",
"description": "A reference to a related private endpoint connection.",
"properties": {
"id": {
"description": "The resource ID.",
"type": "string",
"readOnly": true
},
"name": {
"description": "The name of the resource.",
"type": "string",
"readOnly": true
},
"type": {
"description": "The type of the resource.",
"type": "string",
"readOnly": true
},
"properties": {
"$ref": "#/definitions/PrivateEndpointConnectionProperties",
"description": "The properties of a private endpoint connection.",
"x-ms-client-flatten": true
}
}
},
"KeyVaultProperties": {
"type": "object",
"description": "Settings concerning key vault encryption for a configuration store.",
Expand Down Expand Up @@ -1534,6 +1580,14 @@
"type": "string"
},
"readOnly": true
},
"requiredZoneNames": {
"type": "array",
"items": {
"type": "string"
},
"readOnly": true,
"description": "The list of required DNS zone names of the private link resource."
}
},
"description": "Properties of a private link resource."
Expand Down
8 changes: 6 additions & 2 deletions ...osoft.AppConfiguration/preview/2019-11-01-preview/examples/ConfigurationStoresCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand All @@ -52,7 +54,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand Down
8 changes: 6 additions & 2 deletions ...figuration/preview/2019-11-01-preview/examples/ConfigurationStoresCreateWithIdentity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand Down Expand Up @@ -69,7 +71,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand Down
4 changes: 3 additions & 1 deletion ...icrosoft.AppConfiguration/preview/2019-11-01-preview/examples/ConfigurationStoresGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand Down
8 changes: 6 additions & 2 deletions ...crosoft.AppConfiguration/preview/2019-11-01-preview/examples/ConfigurationStoresList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand All @@ -44,7 +46,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand Down
8 changes: 6 additions & 2 deletions ...iguration/preview/2019-11-01-preview/examples/ConfigurationStoresListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand All @@ -40,7 +42,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand Down
8 changes: 6 additions & 2 deletions ...osoft.AppConfiguration/preview/2019-11-01-preview/examples/ConfigurationStoresUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand All @@ -51,7 +53,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand Down
8 changes: 6 additions & 2 deletions ...figuration/preview/2019-11-01-preview/examples/ConfigurationStoresUpdateWithIdentity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand Down Expand Up @@ -68,7 +70,9 @@
"keyIdentifier": null,
"identityClientId": null
}
}
},
"privateEndpointConnections": [],
"publicNetworkAccess": "Disabled"
},
"sku": {
"name": "Standard"
Expand Down
3 changes: 3 additions & 0 deletions ...icrosoft.AppConfiguration/preview/2019-11-01-preview/examples/PrivateLinkResourceGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
"groupId": "configurationStores",
"requiredMembers": [
"configurationStores"
],
"requiredZoneNames": [
"privatelink.azconfig.io"
]
}
}
Expand Down
3 changes: 3 additions & 0 deletions ...ion/preview/2019-11-01-preview/examples/PrivateLinkResourcesListByConfigurationStore.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
"groupId": "configurationStores",
"requiredMembers": [
"configurationStores"
],
"requiredZoneNames": [
"privatelink.azconfig.io"
]
}
}
Expand Down