Added properties that were missed in 2019-11-01-preview API version. #9002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
This was referenced Apr 9, 2020
|
Can one of the admins verify this patch? |
|
@jimmyca15 Please fix prettier by running npm run prettier -- --write "specification/appconfiguration/**/*.json" |
|
@NullMDR I can't get that command to work. Tried deleting node modules and reinstalling. says it can't find "prettier-swagger-plugin". I can see that file in the scripts folder. Doesn't repro for you? |
|
Apparently my NPM was pretty outdated. I noticed v2.15.11 in the error log. I had to uninstall node and delete all of NPM, but now after reinstalling everything works. Will submit update to the PR. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@NullMDR Could you help for it? I can't merge it due to the breaking change. |
|
@nullmdr @ChenTanyi anything left I need to do for this one? |
ChenTanyi
approved these changes
Apr 20, 2020
ChenTanyi
added
the
Approved-OkToMerge
PhoenixHe-NV
suggested changes
Apr 20, 2020
...resource-manager/Microsoft.AppConfiguration/preview/2019-11-01-preview/appconfiguration.json
Show resolved
Hide resolved
| "$ref": "#/definitions/PrivateEndpointConnectionReference" | ||
| } | ||
| }, | ||
| "publicNetworkAccess": { |
There was a problem hiding this comment.
Also this one. Adding non-readonly property to response is considered breaking change.
There was a problem hiding this comment.
@NullMDR Public network access needs to be editable. We haven't made a breaking change before but we thought we would be able to since our API version is preview. Please let me know if that is not the case.
There was a problem hiding this comment.
@NullMDR This API needs to be editable and we are under the assumption that we can fix this because this is a preview version. Please let me know if this is not the case. Thanks!
|
@nullmdr @ChenTanyi please see my comments about the intended breaking change so that we know how to proceed. Thanks. |
|
@jimmyca15 I cannot do any thing about the change requested and the CI failure. If @NullMDR still no reply, you can send a email to |
|
Thanks @ChenTanyi I have reached out. Not sure, but editing out the email address might be helpful if it isn't advertised through this repo. |
PhoenixHe-NV
added
the
Approved-BreakingChange
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-trenton - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Closed
akning-ms
added a commit
that referenced
this pull request
May 15, 2020
* feat: update java readme (#9017) * [Data Factory]Add new auth/prefix/fileFilter/partitionRootPath to ADF public swagger (#8932) * add allowLargeResults/azureFileConnector/fileFilter * remove required * remove allowLargeResults, add prefix to Azurefile * add partitionRootPath Co-authored-by: Haoran Sun <[email protected]> * Add swagger spec for custom domain of appplatform (#8792) * Add swagger spec for custom domain of appplatform * Sub resource custom domain, Spring/apps/domains. * Sub resource certificate, Spring/certificates. * Action for certificates/validate. Signed-off-by: Pan Li <[email protected]> * Add pagable for list. Signed-off-by: Pan Li <[email protected]> * Add httpsonly and fqdn to app. Signed-off-by: Pan Li <[email protected]> * Resolve comments. Signed-off-by: Pan Li <[email protected]> * Adding decription of unlink action to Replication Link Swagger (#8720) * Luis sdk changes (#8985) * adding LuisApp import/ export lu format, adding LuisApp import v2 app, adding azure account related auth using arm token * fixing export app version lu format query parameters and adding output as file format * Adding successful importing for v2 * adding successful import lu application example * adding successful example in swager * fixing name typo * adding format for export lu export * updating produces type * removing reference and adding definition in schema * fixing spelling checks * adding missing parameters, fixing spelling * adding parameter in the right file * running prettier fix * [Code review] refactoring input to referenced parameter * adding "x-ms-parameter-location" in Armtoken parameter extension * PrettierCheck run * adding missing parameters in input * updating description * Relay: adding new API version 2018-preview (#8903) * Added 2018-preview API to Relay * updated with splittign swagger * removed the response code from delete * formating fixed * updated readme file * corrected file name * updated networkruleset * Added common definations * fixed modalvalidation * updated readme.go.md * regenerated all-api-versions * [Resources] Fix deployment validate response (urgent) (#9007) * Add updated validate call in resources swagger * Add back 200 response and update description * Update 202 response Co-authored-by: Filiz Topatan <[email protected]> * update compute python.md for track2 version (#9052) * update compute python.md for track2 version * new track2 will be in the same folder. * [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#9044) * Updating error codes Adding 429 and 503 explicitly * Update consumption.json adding more details * Update consumption.json fixing status code * Update consumption.json more * Update consumption.json test * update * u * u * Update costmanagement.json * prettify * Update custom-words.txt * updated test scenario (#9056) * updated test scenario * disabled some tests * Test cognitive services (#9060) * adding test scenario * updated test * one more fix * updated examples * undo unrelated * fixed example json * Fix digitaltwins readme (#9050) * fixed digital twins readme * one more fix * folder fix * Updating peering examples etc (#9048) * fixing test * peering examples fixes * enabled some tests that are passing * [Hub Generated] Review request for Microsoft.Marketplace to add version stable/2020-01-01 (#8956) * change title * Update swagger for new api * response to validation comments * adding swagger to sdk * prettier * update * prettier test * prettier fix * adding for deletr * delete * title change * adding description * remove title * return title * fix read.md * Removing Private Preview features from Swagger (#9046) * [Azure Stack] Updates to Azs.InfrastructuresInsights.Admin spec (#8975) * cumulative commit message: commit 9e551f0eab4057d4c2f54c333c7aa2a1a564c125 Author: bganapa <[email protected]> Date: Tue Nov 12 11:44:22 2019 -0800 Reset to Stackadmin2 (#7766) * Add autorest generation info to readme.md * Fix readme.md * regenerated all-api-versions * add configuration for polymorphism resource in machine learning for azure cli codegen (#8954) * add configuration for poly for DataConnections (#8953) * Track2 appconfiguration (#9070) * update appconfiguration python.md for track2 * remove $(python) * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md Co-authored-by: Zim Kalinowski <[email protected]> * update eventhub python.md for track2 (#9066) * update eventhub python.md for track2 * keep python: * Update readme.python.md Co-authored-by: Zim Kalinowski <[email protected]> * update monitor python.md for track2 (#9073) * update monitor python.md for track2 * keep python: * Update readme.python.md Co-authored-by: Zim Kalinowski <[email protected]> * update resource python.md for track2 (#9067) * update resource python.md for track2 * keep python: * Update readme.python.md Co-authored-by: Zim Kalinowski <[email protected]> * update keyvault python.md for track2 (#9071) * update keyvault python.md for track2 * keep python: * Update readme.python.md Co-authored-by: Zim Kalinowski <[email protected]> * fix config in compute (#9069) * fix config in compute * keep python: * Update readme.python.md Co-authored-by: Zim Kalinowski <[email protected]> * update storage python.md for track2 (#9068) * update storage python.md for track2 * keep python: * Update readme.python.md Co-authored-by: Zim Kalinowski <[email protected]> * Update cosmos-db.json (#9011) * Update cosmos-db.json * Update cosmos-db.json * Update cosmos-db.json * Update cosmos-db.json * Update cosmos-db.json * Update cosmos-db.json * Update cosmos-db.json * Update cosmos-db.json * Update cosmos-db.json * fixed readme (#9081) * swagger updates - task 6465636 (#8882) * fixed portal readme file (#9082) * az-output-folder-change (#9088) * az-output-folder-change * add azure-cli-extension automation * Service fabric api version 2020-03-01 adding missing properties (#9036) * adding serviceDnsName, instanceCloseDelayDuration and ApplicationTypeVersionsCleanupPolicy * fix model validation Co-authored-by: Alfredo Santamaria Gomez <[email protected]> * [Azure Stack] Updates to Subscriptions module (#8898) * commit dd09a40a97fdfd2b215498a6643ce21c9a2dbd38 Author: bganapa <[email protected]> Date: Tue Mar 17 17:32:10 2020 -0700 Update to camelCasing for resourceGroups commit 4212dd05b892d364f7271719847c4adeb896a9e6 Author: bganapa <[email protected]> Date: Tue Mar 17 17:30:07 2020 -0700 Update to camelCasing for resourcegroups commit 594441bce0507006aa23992f5f4cd9b7238633bf Author: Rakesh Kumar <[email protected]> Date: Tue Nov 26 14:06:28 2019 -0800 Rakku stackadmin issue (#7852) * network admin module changes * remove readme.azsautogen.md from network * rename new[ModuleName] to [ModuleName]Definition for AcquiredPlan, DirectoryTenant, Offer, OfferDelegation, Plan and Subscription * fix for enum naming error in github issue #7822 commit ac4e40dc221e38585d6417f054a8d04d0cc49734 Author: Rakesh Kumar <[email protected]> Date: Wed Nov 20 16:47:44 2019 -0800 Subscription Admin module parameter renaming (#7816) * network admin module changes * remove readme.azsautogen.md from network * rename new[ModuleName] to [ModuleName]Definition for AcquiredPlan, DirectoryTenant, Offer, OfferDelegation, Plan and Subscription commit 9e551f0eab4057d4c2f54c333c7aa2a1a564c125 Author: bganapa <[email protected]> Date: Tue Nov 12 11:44:22 2019 -0800 Reset to Stackadmin2 (#7766) * Fix example * Fix examples * Address PR comments * Updating Dashboards properties type to integer (#8829) Updating Dashboards properties type to integer Co-authored-by: Himanshu Chandel <[email protected]> * Add properties to CosmosDb PrivateEndpointConnection and PrivateLinkResource (#9064) * Add missing properties in PEC and PLR to swagger * fix whitespace * Added swagger file for Microsoft.Kubernetes (#9037) * Added swagger file for Microsoft.Kubernetes * Updated readme files * Prettier fix * Updated python and go readme files * Update GetClustersByResourceGroupExample.json just retriggering ci Co-authored-by: Akash Keshari <[email protected]> Co-authored-by: Zim Kalinowski <[email protected]> * regenerated all-api-versions * Update Common.json to match the API version (#8845) * 2020-02-01-preview for Media Services LVA Changes to MediaGraph model Changing PUT from sync to async Fixing some description * Prettier and model validations fix * Fixing validations * Fixing version in Common.json * Using common types.json * Updating new version * Adding old version * Revert "Adding old version" This reverts commit 6bf3a735ca31f072a4a329f2fc156a9e1914fb1e. * Using common types * Using 200 for operation locatio header. * Fixing validation errors * Trying to fix autorest * Reverting common.js to test if that matters for autorest. * Reverting default operation result to test if that matters for autorest * Fixing previous revert. * Fixing after merge from upstream * Testing default operation result * Testing description * Adding common json back * Testing empty description * Testing no default for operation result * Removing common.json * Updating common.json of AMS * Updating common.json * Updating common.json * Updating common.json * Rename unknown classification to undetermined classification (#8436) * Fixing the structure of RESTProxy documentation: Updating the OperationId (#8327) * Updating the OperationId Updating the OperationId because the grouping of operations isn't correct. * Updating the operationId spelling * Making prettier fixes as outputed * update lint doc, add the missed rules doc R2029,R2007 (#8502) * Linter tool document update: add R4004, modify R2016 ,R3006 (#8417) * Linter tool document update: add R4004. * Update linter doc : modify R2016 ,R3006 * change date format * Update description of R2016 * 2020 01 01 updates to rules engine caching behavior (#8455) * 2020 01 01 updates to rules engine caching behavior * add new cache settings fields to CacheConfiguration * cache settings fields will enable Rules Engine to allow cache override actions * fix typos in examples * renamed privateLinkResourceId to privateLinkAlias * fix x-nullable usage * Change cacheDuration to "format":"duration" Co-authored-by: Moustafa Eid <[email protected]> * add cli.md for postgresql (#8492) * add cli.md for postgresql * remove and update description * Added minimalTlsVersion property for Managed Instance endpoint, API version 2018-06-01-preview (#8508) * [SRP] Add blob service property for container soft delete (#8498) * Adds 'Offline' state to provisioning states. (#8509) * Fix x-ms-enum name conflict (#8465) * [Deployment Scripts] Deployment scripts error model update (#8481) * add package-subscriptions-2019-11 (#8503) * regenerated all-api-versions * Added redis cache publisher schema for azure event grid. (#8486) * Added redis cache Event Schema to Event Grid DP Repo * removed commented section * [Hub Generated] Review request for Microsoft.Attestation to add version preview/2018-09-01-preview (#8478) * Include Tags in GetSubscription and Deployment APIs (#8268) * changes to get subscription * tags for deployments * fixes from another fork * added extension * Remove readonly flag from microsoftSessionAddress properties in BgpSession; add an example for IxRs directPeeringType (#8517) * add cli.md for databricks (#8521) * Reverting to local Common.json to satisify autorest against md file. * Fixing prettier * Updating Common.json to match API version Co-authored-by: dosegal <[email protected]> Co-authored-by: anushreeringne <[email protected]> Co-authored-by: JianyeXi <[email protected]> Co-authored-by: aramesh-msft <[email protected]> Co-authored-by: Moustafa Eid <[email protected]> Co-authored-by: Kerwin <[email protected]> Co-authored-by: Andrija Cicovic <[email protected]> Co-authored-by: Zhenfeng <[email protected]> Co-authored-by: Akashdeep Goel <[email protected]> Co-authored-by: Lei Ni <[email protected]> Co-authored-by: Filiz Topatan <[email protected]> Co-authored-by: Jiashuo Li <[email protected]> Co-authored-by: azuresdkci <[email protected]> Co-authored-by: abebts2000 <[email protected]> Co-authored-by: gkostal <[email protected]> Co-authored-by: ramoka178 <[email protected]> Co-authored-by: Praneeth Sanapathi <[email protected]> * [Azure Stack] Updates to Azs.Backup.Admin spec (#9034) * Cumulative commit message: commit 72efdec25338cfbb9fea108dcfb390f4c5ff6295 Author: bganapa <[email protected]> Date: Thu Feb 27 17:26:56 2020 -0800 Update to have $(this-folder)/ in the input files commit 10ec2068533a0b5d1f5641b85030678ef61ebf75 Author: Daotian Zhang <[email protected]> Date: Fri Jan 3 04:01:04 2020 +0800 Add x-ms-long-running-operation-options (#8037) commit 70fbb623c3f2d965cd33c282da7439fe5262e2b8 Author: Daotian Zhang <[email protected]> Date: Wed Dec 18 14:13:52 2019 +0800 Fix resourceGroups in resource path and add top/skip (#7996) commit 9e551f0eab4057d4c2f54c333c7aa2a1a564c125 Author: bganapa <[email protected]> Date: Tue Nov 12 11:44:22 2019 -0800 Reset to Stackadmin2 (#7766) * Remove old specs from PR * Remove old spec package info from readme.md * Run Prettier check * Add autorest gen info to readme.md Co-authored-by: Daotian Zhang <[email protected]> * regenerated all-api-versions * Upgrade version of package @azure/rest-api-specs-scripts in PPE (#9051) Co-authored-by: Jianye Xi <[email protected]> * Jedi cmk ai (#9047) * add tag 2020-04 to include jedi request related specs * definition for ErrorResponse conflict with 2015-05-01/aiOperations_API.json * add description for tag package-2020-04 * Add multiapi section for go SDK (#9101) * [Azure Stack] Updates to Azs.Network.Admin Spec (#8960) * commit f809fa9a8217e9de7764e1b13dd203b5405d85f9 Author: Rakesh Kumar <[email protected]> Date: Wed Nov 13 11:49:29 2019 -0800 Stackadmin network (#7776) * network admin module changes * remove readme.azsautogen.md from network commit 9e551f0eab4057d4c2f54c333c7aa2a1a564c125 Author: bganapa <[email protected]> Date: Tue Nov 12 11:44:22 2019 -0800 Reset to Stackadmin2 (#7766) * Update Readme.md to include autorest generation info * Add quotes to file paths * Fix input file references * regenerated all-api-versions * Trenton Automation onboard (#9106) * cli extension * Update specificationRepositoryConfiguration.json * Update SwaggerToSDK.yml * Update SDKAutomation.yml * test_0330 * test_0330 * Update specificationRepositoryConfiguration.json * Update azure-pipelines.yml * sdk * [TEST] Terraform test securityInsights.fake [041303] * onboard Terraform in Prod * onboard Terraform in Prod * onboard Terraform in Prod * onboard Terraform in Prod Co-authored-by: Xiaoxu Qi <[email protected]> * Fix property of mountTarget (#9078) * Fix property of mountTarget * Added missing properties to mountTargetProperties for 2019-11-01 Co-authored-by: Audunn Baldvinsson <[email protected]> * Add Premium_LRS to enum values. (#9098) * [Hub Generated] Review request for Microsoft.Marketplace to add version stable/2020-01-01 (#9117) * Fixing readme.md file * Update readme.md * Update readme.md Co-authored-by: Zim Kalinowski <[email protected]> * Add-missing-multiapi-item (#9103) * refreshing web test specification (#9125) * Add api-version 2020-03-01 of network for go SDK (#9100) * update test (#9128) * update assignemnt config (#9132) * enable avocado-0.6.3 (#9133) * fix example issues (#9131) Co-authored-by: Changlong Liu <[email protected]> * Fix windowsesu readme (#9049) * fix package name * one more fix * one more fix * additional fix * Swagger update (#8967) * Update cluster and linked services API * Update LinkedServicesGet.json Fix * fix json * Prettier * fix modelValidation * fix modelValidation 2 * Fixes for PR * separate linkedServices to new file * Update readme.md * Fix PR * Change capacityReservationLevel to capacity * Fix version * writeAccessResourceId fix camel case * Fix cluster api * Update readme.md * added link targets * Make link, unlink and cluster delte async * Update SavedSearches.json * Fix typos * fix missing capacityreservation * update CapacityReservation * add all apis from stable * better name * prettier * add to build * Update AvailableServiceTiers.json * entity status * Update WorkspacePurge.json * Update WorkspacePurge.json * Update WorkspacePurge.json * Update WorkspacesAvailableServiceTiers.json * remove link targets [DEPRECATED] * Update readme.md * Update linked service for cluster async Co-authored-by: Or Argaman <[email protected]> Co-authored-by: Arie Olshanezky <[email protected]> * regenerated all-api-versions * Metric alerts- WebtestLocationAvailabilityCriteria should inherit from MetricAlertCriteria (#9027) * Adding autogenerated keyvault test (#9080) * adding keyvault tests * updated test * add type time to valueTime (#8977) * [Azure Cognitive Search] Add new relevance features (feature API, session ID and scoring statistics) to the Index Search APIs (#8793) * Add relevance features * Fix PR comments * Run prettier * Add restriction about session id * Fix two types (integer instead of number) in InformationProtectionPolicies.json (#9053) * Update informationProtectionPolicies.json * Update informationProtectionPolicies.json * Update informationProtectionPolicies.json * Update informationProtectionPolicies.json * Update informationProtectionPolicies.json * Update CreateOrUpdateInformationProtectionPolicy_example.json * Adding adding get ipAggregates API. (#9038) * Adding adding get ipAggregates API. * Adding 'extranet' and 'paginized' to the custom word file. * Adding Get IpAddressAggregateSettings. * Adding Patch IpAddressAggregateSettings. * Updated with PR comments. * Minor edit. * Minor change from 'Ip' to 'IP'. * Minor update. * Minor update. * Fixing test. * update version of rest-api-specs-scripts (#9134) Co-authored-by: Jianye Xi <[email protected]> * update network python.md for track2 (#9074) * update network python.md for track2 * remove payload * keep python: * Update readme.python.md Co-authored-by: Zim Kalinowski <[email protected]> * Onboarding applicationWhitelistings to a new stable API version - 2020-01-01 (#8639) * copy applicationWhitelistings API to new api-version * change applicationWhitelistings API-version to the new stable one * make the GET and PUT objects the same (and add readonly to some fields) * try fix model validation by adding required fields * changing the parameter from definitions to parameters * adding the AppWhitelistingGroup to parameters as well and referencing the definition * try change sub id * remove readonly properties from PUT * remove duplicate APIs from package composite Co-authored-by: erelh <[email protected]> * regenerated all-api-versions * [Blueprint] Remove length limitation from RG name and location properties (#9115) * Remove length limitation from RG name and location properties * prettify Co-authored-by: Weidong Xu <[email protected]> * [Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 (#8957) * add filter doc * trigger doc gen * fix formatting in old api version * trigger again * add link to categories * Add expand parameter to graphrbac user list (#9127) * Add Readme for Devops (#9153) * Add Readme for SecurityInsight (#9155) * Fix invalid resourceGroupname in Relay examples (#9138) * Fix invalid resourceGroupname in Relay examples * Fix comments * Add Readme for WindowsIot (#9154) * Update multiapi for go sdk of securityinsights (#9169) * SRP recent file share API change (#8900) * SRP recent file share API change * Fix CI * Update description * Address comment * fix assignment-bot config (#9171) * Upgrade pipeline scripts version (#9172) * Add free-form object spec for testing purpose. * Revert "Add free-form object spec for testing purpose." This reverts commit b711d809b6ae964fcbe7d04f31fec76db8798438. * Upgrade pipeline script version. Integrate rest-api-specs-scripts latest version with the fix in oav about output exception information when command switch pretty is on. * Private Repo Approved PR# 974 Add Blob Index Tag Support For Management Policy (#9012) * Add Blob Index Tag Support For Management Policy * Adding BlobIndexMatch Example * Update status and fix one property name. (#9152) Signed-off-by: Pan Li <[email protected]> * Fix name collisions causing incorrect code generation (#9091) * Add tenent-level provider listing to SDK * PR feedback: add tenant-level Provider_Get operation * Make operation names more consistent. * Update spec to match the provider API * Add missing description * Fix spelling typo * Switch new enums to modelAsString * Revert "Switch new enums to modelAsString" This reverts commit 695b4a932de68cce9c994ddcffffa38c132b28a1. * Fix name collisions causing incorrect code generation * Event Hub : Split swagger in to entities (#8987) * splitted 2017 and 2018 API version swagger * Lint fix * fix Prettier Check * corrected the examples and readme file * corrected definations paths * update * prettier check fix * added description * updated description * corrected parameter location Co-authored-by: v-ajnava <[email protected]> * Fix a bug in swagger (#9026) * Adding new VirtualMachineScaleSetVMs.POST.SimulateEviction action to compute api-version: 2019-12-01 (#9102) * [CosmosDB] Add PrivateEndpointConnections to DatabaseAccountGetResult (#9119) * Add PrivateEndpointConnections to DatabaseAccountGetResult * fix per comment * fix per comments * fix prettier * Added new features in new api version 2020-03-01 (#8403) * update version of rest-api-specs-script (#9188) Co-authored-by: Jianye Xi <[email protected]> * [Hub Generated] Review request for Microsoft.Marketplace to add version stable/2020-01-01 (#9123) * addinfg input for swagger to sdk * Fixing lint errors * fixing model validation * R3021 - PathResrouceTypeNameCamelCase fix * fixing semantic * changing name * removing plans from offer * response to arm comments * Update readme.md (#9192) * Fix example of get group ids (#9190) Co-authored-by: Arvind Krishnaa Jagannathan <[email protected]> * Add property for default export storage account to Healthcareapis (#8507) * Following changes are related to updating the arm api version number to GA version. Current version number is 2018-08-20-preview. GA version number is 2019-09-16 * Add new example, change example names, and update kind. * Remove common from examples. * Update doc and example * Add identity properties * Fix typo Co-authored-by: Pooja Adhikari <[email protected]> Co-authored-by: RB Johnson <[email protected]> * Add missing two properties in ErrorResponseBody. (#9116) * desktop virtualization (#9219) * desktop virtualization * fix spell check * add reseting * prettifier * spell check * 2019-12-10 pr changes more fixes add longer description more 204 descriptions missed one need to fix the file renames example changes revert all 01 23 one more revert enum chagne required and readonly require the above property remove require = true correct example prettifier fix properties more example fixing more fixes more issues remove dup * allow * fix 01-23 and 09-24 * fix descriptions * require x-ms-client-tenant-id * move stuff to top and add examples for tenant header * remove header * Cli onboard hardwaresecuritymodules (#9150) * Adding External Scopes properly based on ARM Suggestion (#9124) * Adding external scopes to Dimension & Query API 1. By introducing API Version 2019-11-01 accidentally these scopes got removed. This is to add the existing scopes 2. Addressing Arm Concern to introduce these scopes correctly * updated examples to reflect externalScope parameter * fixing a small issue * ran prettier to fix build issue * Addressed comment from ARM review * fixed semantic errors * updated examples * Fixed a small issue in enum * run prettier to fix some style errors * fixed a minor issue * fixed a small issue * Addressed PR feedback * Did some minor changes * corrected the Opeartions API version (#9207) Co-authored-by: v-ajnava <[email protected]> * Update ml config2 (#9193) * update email template (#9191) * update email template * update ci-fix url and change cc to [email protected] * test cli automation (#9226) * List.json - removing 404 (#8961) * Dev kubernetesconfiguration microsoft.kubernetes configuration 2019 11 01 preview (#9170) * Remove x-ms-parameter-location for api-version parameter to fix CLI issue * revert accidental updates to 2 readme files * add R4007& R4008 (#8931) * Support parallel read of Sql sources (#9090) * add sharepointonlinelist connector * support parallel read of sql sources * [cognitive-services-face-api] fixing documentation links and a few examples where the imageurl parameter is specified as strings when it should be json objects (#9182) * fixing broken documentation links and also making examples on image urls specify json objects instead of strings for in-body request contents * fixing example parameter name Co-authored-by: Nabil Lathiff <[email protected]> * Fix Swagger definition for customDimensions - remove additionalProper… (#9129) * Fix Swagger definition for customDimensions - remove additionalProperties * Fix removed additional-properties * Apparently additionalProperties: true is not supported in MS? * Deprecate the old additionalProperties attribute instead of removing it to avoid breaking change * The deprecated keyword is not supported in autorest apparently, moving on without deprecating it Co-authored-by: Alon Gafni <[email protected]> * update lang v3.0 --> return single language instead of a list (#8815) * Cognitive Services Form Recognizer v2.0-preview: Copy APIs (#8349) * Update FormRecognizer v2.0-preview spec with new operations 'CopyCustomModel' and 'GetCustomModelCopyResult'. Added new sample files for the operation - 'CopyModel.json' and 'CopyOperationResult.json'. * Add claimResourceRegion. Remove move option from Copy data contract based on review. Fixed required property issue in AuthorizationClaim contract * Address PR comments * Remove authorizationClaim from CopyRequest contract. Updated reference for targetResourceRegion. Added pattern for targetResourceId * Fixed typo in CopyRequest required attribute * Add AuthorizationClaim contract and include it with CopyRequest * AuthorizationClaim - typo in required attrib * Rename AuthorizationClaim to Authorization * Rename modelResourceId to modelId in the 'Authorization' contract. Fixed copy sample * Adding source query string parameter to the POST copy request * Set 'application/json' consumes option for POST copy * Introduce models/copyAuthorization route. Added sample for the new route. Updated existing samples for correctness. * Change expirationDateTime to expirationDateTimeTicks in the CopyAuthorizationResult contract. Follows the 'expires_on' convention in the AAD token. * Remove enum reference for targetResourceRegion. Update to a loose pattern and length specification * Address ModelValidation and Sample validation errors * Fix copy samples JSON validation issues * Run prettier on FormRecognizer.json swagger and example files * Add sample for COpy operation result with errors. Fix description for copy operations * Prettier fix for CopyOperationResultWithErrors.json * Add LRO annotation to copy API * [DeploymentScripts] inclusion of storage account settings (#9157) * inclusion of storage account settings * included examples * removed restartPolicy * updated sample response * updated based on feedback * renamed file * updated file name to prevent case sensitive error Co-authored-by: Jorge Cotillo <[email protected]> * change python client name (#9234) * change python client name * change python client name * bug-search (#9235) * Update Sql Auditing swager (#8897) * Update Sql Auditing swagger 1. Support auditing to storage with Vnet/Firewall rules API- supporting blob storage authentication with managed identity 2. Add List audit API * update DatabaseExtendedAuditingSettingsList examp * Update DatabaseExtendedAuditingSettingsList.json Co-authored-by: bashahee <[email protected]> * [HDInsight] Add two new APIs: listhosts and restart node (#8794) * Add FAQ document (#9230) * Add FAQ document * Fix typo & change MV descriptions * fix ci-fix url * Change SDK generation * Add checkQuotaAvailability to vmwarevirtustream 2019-08-09-preview swagger spec (#9244) * Add checkQuotaAvailability to vmwarevirtustream 2019-08-09-preview * fix missing/invalid types * update tags * updated to use location based routing * change description for host quotas * Update QuotaGet definition * make checkQuotaAvailability subscription level Co-authored-by: David Ricciardi <[email protected]> * [CosmosDB] Fix references in privateEndpointConnection.json (#9213) * Fix references in privateEndpointConnection.json * fix reference to common * Add similarity property to the Azure Search Index definition for API 2019-05-06-preview (#9249) * BM25 * Add descriptions * Update Azure.Search * Revert Microsoft.Azure.Search changes * Fix spacing * PR comments * Prettier + custom word * PR comments Co-authored-by: Raouf Merouche <[email protected]> * Fixing R3023 Operation API Implmentation ARM Swagger error (#8423) Co-authored-by: Venkat Akkinepally <[email protected]> * Add public network access (#9214) * remove x-ms-azure-resource to have workspacwe/workspacepatch/datasour… (#9168) * remove x-ms-azure-resource to have workspacwe/workspacepatch/datasource properly inherited from parent class * add entry in readme.go.md * update spec for dotnet SDK * remove 'x-ms-azure-resource: true' for Cluster * remove 'x-ms-azure-resource: true' for LinkedService * try-fix-cosmos-db-two-subscription-id (#9279) * Updating operationId to group the operations in a logical way … (#9159) * Updating operationId to group the opearions in a logical way and the generate APIs are grouped together based on the operations. * 1. Updating schema for autoQuotaRequest 2. Updating examples. * Updates to data model and examples. * Model Update. * Data Model Fix. * Fixing Data Model for AQI. * Removing duplicate definitions. * Adding type=object for emailAction. * Putting the similar definitions together. * Model Fix. * Fixing AQI examples. * Adding descriptions for enum. * Fixing Spell Check error. * Removing used object: phoneActions. Updating the comments for Put and Patch, that both can be used to update quota. * Updating the Put operatonId as _CreateOrUpdate. * Making Tag information same - QuotaInformation. * Updating example for commit. * remove shanghai assignee during 5.1 holiday (#9254) * eliminate quotas warnings in vmwarevirtustream 2019-08-09-preview (#9269) * eliminate quotas warnings * fix QuotaEnabled * change back to Quotas_CheckQuotaAvailability * rename to CheckQuotaAvailability to avoid warning * Time Series Insights - Fixes on existing api-versions (#8758) * Fix or suppress spec violations Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives. * Try removing 2nd top-level heading, which _may_ have been causing a linter warning. * Fix extra indention which prevented linter from running. * Added dataStringComparisonBehavior parameter to reference data put/update spec. * Fixed grammar. * adding partitionkeyProperty to environmentInfo * changing property name * changing modelAsString * Initial checkin of spec. Unchanged from GA release other than version. * Remove .orig files * Fix validation error by removing IoTHub ES from List ES example response * Add extra example that was missing from preview spec. * Add long-term environment to resource hierarchy, and update examples. * Switch to model-as-string for enums. Restore EnvironmentResource's inheritance from TrackedResource. * Upsate sku description * Add new TSI preview api-version to readme.md. * Add suppressions for false-positive linter failures. * Test suppression failures * Adding preview package tag to several other places in readme.md * Add preview package to the readme.go.md file * Remove invalid required property from EnvironmentCreateOrUpdateParameters * Initial version of data plane swagger spec for PAYG (Preview) SKU. * Added missing Readme.md * Fixed name of readme * Fixed path to swagger json * Attempt to fix readme * Apply suggestions from code review Co-Authored-By: dmdenmsft <[email protected]> * Update timeseriesinsights.json * Update timeseriesinsights.json * Added link to oav issue * Changing creation time to RFC1123 when TSI Environments are part of the response body * Renaming $expand to expand * Fixing patch Environment supporting S* and L1 parameters * Reverting creationTime format change * Tweaking Environments_Update to support inheritance * Fixing grammar * Fixing Microsoft.IoTHub namespace * Reverting environmentUpdateParameters renaming * Renaming expand back to $expand * Applying updates based on feedbacks * Removing partitionKeyProperties from StandardEnvironmentMutableProperties * Changing partitionKeyProperty description * Removing the flattening from warmStoreConfiguration * Removing maxlength from array * Removing support for other LocalTimeStamp formats than Embedded Co-authored-by: Eric Dettinger <[email protected]> Co-authored-by: Karthik Subramanian <[email protected]> Co-authored-by: Ravi Kumar Suresh Babu <[email protected]> Co-authored-by: ravikumarsureshbabu <[email protected]> Co-authored-by: Dmitry Denisov <[email protected]> Co-authored-by: Nick Schonning <[email protected]> Co-authored-by: Karthik Subramanian <[email protected]> * Added properties that were missed in 2019-11-01-preview API version. (#9002) * Added properties that were missed in 2019-11-01-preview API version. * Fixed prettier. * Added readonly to private endpoint connections. * netapp trenton pipeline (#9287) Co-authored-by: root <[email protected]> * Nasingla/stableversion (#9143) * New Version for subscription RP * Update readme.md * Update subscriptions.json * Update subscriptions.json * Update subscriptions.json * Update subscriptions.json * updated examples * Update renameSubscription.json * Update readme.md * Add descriptions to enums (#9276) * [PendingArmReview] Fixed Settings API (#9227) * fixed settings api. changed the dataexportsetting parameter name and the discriminator place * deleted propersties * ran prettier fix * fixed update test and added properties in Settings definition * deleting additionalproperties because of autorest errors * adding back additionalProperties * deleting a readonly property from the example * deleting another readonly property from the example * EventHub : 2018-01-01-preview Cluster SKU Name change (#9245) * Cluster Sku Name * update Co-authored-by: v-ajnava <[email protected]> * Settings API fix (#9312) * fixed settings api. changed the dataexportsetting parameter name and the discriminator place * deleted propersties * ran prettier fix * fixed update test and added properties in Settings definition * deleting additionalproperties because of autorest errors * adding back additionalProperties * deleting a readonly property from the example * deleting another readonly property from the example * deleting additionalProperties * deleting additionalProperties * [Hub Generated] Review request for Microsoft.KubernetesConfiguration to add version preview/2019-11-01-preview (#9299) * Add Microsoft.KubernetesConfiguration to azure api specs * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Revert "Add Microsoft.KubernetesConfiguration to azure api specs" This reverts commit e0889b2abea2dd7cc12c33677189dd1859c5bfd8. * Add Microsoft.KubernetesConfiguration specification * PrettierCheck fixes * Remove unused example file * Delete settings.json Deleting file added accidentally * Address review comments * Update output-folder for go config * Mark Delete as Sync; and address review comment * Updated Delete example to remove 202 * Updated readme of ruby and python for namespace values * More updates for readme of ruby, python and typescript * Remove x-ms-parameter-location for api-version parameter to fix CLI issue * revert accidental updates to 2 readme files * Remove the enum values of ComplianceState property * Revert "Remove the enum values of ComplianceState property" This reverts commit 59bb14f40450d6543ae39dccc5956114377c36ba. * Remove the enum values of ComplianceState property * Make ComplianceState a string type property * Converting back to enum and adding the new known values * Addressed PR comments * [Hub Generated] Review request for Microsoft.VirtualMachineImages to add version stable/2020-02-14 (#9297) * Update examples to include identity in requests/responses * Make identity field a required field for image template resource * Update to have POST /run & /cancel to return 200 code for powershell sdk generation * Update description of 200 code Co-authored-by: Feiyu Shi <[email protected]> * Add property 'minTlsVersion' to IoTHubProperties (#9162) * Add property 'minTlsVersion' to IoTHubProperties * Update examples * Update readme files for python, go and java for API version 2020-03-01 * Add rename instruction for 'PrivateLinkResources' for java to fix build error * [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (#9263) * added forecast api and all of it's scopes * added alerts path and it's example files * fixed typos in alertProperties * fixed spacing as per prettier script * differentiated forecastDefinition x-ms-enums * changed forecast operationID and forecast fixed response ids to correctly reflect current state in prod. * Update mountTarget type definition (#9294) Co-authored-by: Audunn Baldvinsson <[email protected]> * DoNotMerge preview Network april release (#9282) * Adds base for updating Microsoft.Network from version stable/2020-03-01 to version 2020-04-01 * Updates readme * Updates API version in new specs and examples * Swagger Changes for New Backend Pool Address format (#8993) * SLB Changes * addressed feedback * Fixed RoundTripTimeMs property type: integer -> number (#9023) * Add support for DEL operation (#9040) * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup (#9045) * Rename firewall policy sub resources s/RuleGroup/RuleCollectionGroup s/Rule/RuleCollection s/RuleCondition/Rule This was based on customer feedback - the feature is currently in preview. * rename files * Update examples with new names for the subresource and children * Fix model validation error * Update examples * Revert https://github.com/Azure/azure-rest-api-specs/pull/9045 + Add TI Whitelist (#9271) * TI whitelisting for firewall policy * running prettier * fixing description * removing extra property from the response * adding the new property in examples * retrigger the pr check * clean up * Revert "Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup (#9045)" This reverts commit b49caabeacecce6ddc7e357dd7d758bd9fd82dbc. * Fix ASN parameter of BGPPeerStatus model. (#9178) * Fix ASN for BGPPeerStatus model * Fix json pretty errors * Add premium tier to azure firewall (#9313) * Custom dns servers for Virtual Wan P2SVpnGateway (#9268) * Custom dns servers for Virtual Wan P2SVpnGateway * Fix example * Fix json pretty errors * Add TLS Termination support for FirewallPolicy (#9314) * Add TLS Termination support for FirewallPolicy * firewallPolicy: certificatesAuthority -> certificateAuthority * Add HubRouteTables specs to virtualWan.json (#9206) * add HubRouteTables specs to virtualWan.json * updated RoutingConfiguration as a connection property * added examples for hubRouteTable * updated examples for routingConfiguration * fix1 * some more fixes * fixes2 * prettier check done * validate spec done * fix3 * fixed model validation errors * model validations again * few more fxes: * remove type from examples * fix staging errors * add required field where needed * updated after review * onemore fix * added type * added type Co-authored-by: Mikhail <[email protected]> Co-authored-by: vivekagg-MSFT <[email protected]> Co-authored-by: irrogozh <[email protected]> Co-authored-by: gimotwanMSFT <[email protected]> Co-authored-by: Sai Sujith Reddy Mankala <[email protected]> Co-authored-by: Nilambari <[email protected]> Co-authored-by: odedlaz <[email protected]> Co-authored-by: Ritvika Reddy Nagula <[email protected]> * Frontdoor new API version 2020-05-01 (#9165) * initial commit. duplicate 2020-01-01 into 2020-05-01 * added backend field privateLinkResourceId and privateLinkLocation * updated 2020-01-01 to 2020-05-05 * updated readme.md * renamed readme.md to frontdoor.specs.md, updated response descriptions * updated operationid * fix readme.go * Updating owners for EventGrid (#9320) * Updating code owners for event gris * Updating code owners for EVent Grid * EventHub : Corrected Readme.md for Multi-API/Profile support (#9321) * Corrected Redme.md for Multi-API/Profile support * corrected API version Co-authored-by: v-ajnava <[email protected]> * [Azure Cognitive Search] Various Swagger improvements (#9301) * [Azure Cognitive Search] Add warning to Delete Index description * [Azure Cognitive Search] Rename searchMode to SuggesterSearchMode Trying to avoid ambiguity between generated model names in SDK code. * [Azure Cognitive Search] Remove access-condition parameter group The parameter group was for codegen purposes, but it turns out that clients will use a different pattern for exposing ETag capabilities, so this is no longer needed. However, we're keeping the If-Match and If-None-Match parameters themselves for REST API documentation purposes. Fixes https://github.com/Azure/azure-rest-api-specs/issues/9205 * [Azure Cognitive Search] Clarify docs for pattern analyzer & tokenizer Fixes https://github.com/Azure/azure-rest-api-specs/issues/9145 * [Azure Cognitive Search] Document more enums Fixes https://github.com/Azure/azure-rest-api-specs/issues/9146 * [Azure Cognitive Search] Make List Indexes "fake pageable" This makes codegen easier for now, with the expectation that this API may become pageable in the future. Fixes https://github.com/Azure/azure-rest-api-specs/issues/9274 * [Azure Cognitive Search] Rename models per arch board feedback Fixes https://github.com/Azure/azure-rest-api-specs/issues/9295 * [Azure Cognitive Search] Add names to dictionary * [Azure Cognitive Search] Improve the description of analyzingInfixMatching * [Azure Cognitive Search] Change prefix match example to pacify spell checker Co-authored-by: Bruce Johnston <[email protected]> * Add Pipeline Resources for Image Transfer (#8662) * update 2019-12-01-preview swagger for import and export pipelines * add pipeline runs resource * add examples for import and export pipelines * add pipeline run examples * fix importpipeline example responses * update example * remove isArchiveEnabled property so the used can explictly tell when to delete * fix model validation in pipelineRun examples * resolve duplicate model conflict * run prettier * update examples for pipeline run * Bug fixes for two known issues (#9272) * Bug fixes: skip url encoding for ScopeParameter; add client name for userAssignedIdentities. * Pretty check fix. * [Azure Stack] Updates to Azs.Keyvault.Admin spec (#8974) * Cumulative commit message: commit 9e551f0eab4057d4c2f54c333c7aa2a1a564c125 Author: bganapa <[email protected]> Date: Tue Nov 12 11:44:22 2019 -0800 Reset to Stackadmin2 (#7766) * Add autorest gen info to readme.md * regenerated all-api-versions * feat: update desktop virtualization java readme (#9337) * feat: update desktop virtualization java readme * fix: resource java readme * Add 'capabilities' field to Cognitive Services account properties. (#9309) * Add private endpoint support for Cognitive Services. (#9298) * Add private endpoint support for Cognitive Services. * Address comments * fix prettier * Adding NoPublicIP feature back (#9306) * Update deploymentScripts.json (#9325) Mark environment variable secureValue as secret * Windowsiot (#9333) * resourcegraph trenton * trenton pipeline * test windowsiot pipeline Co-authored-by: root <[email protected]> * Adding userassigned identities for compute (#8879) * Added User identities for compute * Changing the api version * Revert "[Do not Merge] Adding user identities" * Adding userassigned identities for compute * running prettier * Updating Quota examples * Undoing Quota examples * Updating the examples fine * Updating Quota examples Co-authored-by: Shail Paragbhai Shah <[email protected]> Co-authored-by: Sriram Kakara <[email protected]> * [Storage] Add support for listing private endpoint connections (#9324) * [Storage] Add support for listing private endpoint connections This change adds support for listing private endpoint connections through a GET collection API for Microsoft.Storage/storageAccounts/privateEndpointConnections. * Update StorageAccountListPrivateEndpointConnections.json Fixed prettier check fix. * Update storage.json Fixed lintdiff build error * Revert "remove shanghai assignee during 5.1 holiday" (#9354) * Revert "remove shanghai assignee during 5.1 holiday (#9254)" This reverts commit e4fd866ef08eb5e5a95caede3c915e27cec0772f. * remove Allen as reviewer in May as requested * service Fabric 7.1 (#9291) * added SF 7.1 * fixed spelling * added reference to main file * removed unused files * updated tag * regenerated all-api-versions * Change python client name (#9278) * change python client name * change python client name * change title overrider * fix folder name for schema auto generation (#9303) * feat: update java readme for network (#9341) * modelerfour need the x-ms-api-version extention to notify it that this api-version does not need special handling (#8803) * Revert commit:- CustomDnsServer optional param added for P2SVpnGateway resource from April release. (#9365) * Revert "Fix json pretty errors" This reverts commit bd5293975a73fe64d93af00debf93a87fefa29bc. * Revert "Fix example" This reverts commit 827e8829fa36678ba2247ff51cec40b5f8cf985c. * Revert "Custom dns servers for Virtual Wan P2SVpnGateway" This reverts commit a91490a45a80a370ec657a8ed7556a48d6be9d65. * [Hub Generated] Review request for Microsoft.ResourceGraph to add version preview/2018-09-01-preview (#9216) * feedback * Linter * Remove additional fields * Revert operation changes * Undo etag capitalization * Updated code owner for storage (#9338) * [Azure Stack] Updates to Azs.Commerce.Admin spec for autorest config (#9033) * Cumulative commit message: commit 4ec980f9748c6ee9a98389fff0b3941fc8f1fc63 (azure/stackadmin) Author: Yuxing Zhou <[email protected]> Date: Wed Mar 18 15:14:57 2020 +0800 [Azure Stack] Add scaleUnit and volumeLabel parameter to Disks_List (#8733) * add scaleUnit and volumeLabel to Disks_List * fix ref location * update parameter description commit dd09a40a97fdfd2b215498a6643ce21c9a2dbd38 Author: bganapa <[email protected]> Date: Tue Mar 17 17:32:10 2020 -0700 Update to camelCasing for resourceGroups commit 4212dd05b892d364f7271719847c4adeb896a9e6 Author: bganapa <[email protected]> Date: Tue Mar 17 17:30:07 2020 -0700 Update to camelCasing for resourcegroups commit b62db8ba4e29e14935ff33e82bda029393eb8393 Merge: 08d597aa1 fbe767051 Author: Vishnu Priya Ananthu Sundaram <[email protected]> Date: Thu Mar 12 11:23:30 2020 -0700 Merge branch 'stackadmin' of https://github.com/Azure/azure-rest-api-specs into stackadmin commit fbe767051ac6d3c324f7e4d028e7ec5639120407 Author: bganapa <[email protected]> Date: Tue Mar 10 14:06:55 2020 -0700 Update resourceGroups casing commit 848e5f76bc6983599cedb4a7e7cd1666ffd8a298 Author: bganapa <[email protected]> Date: Tue Mar 10 14:05:10 2020 -0700 Update resourcegroups casing to resourceGroups commit 591ff3c47d52bdfbe228ceadb2c8a11781630e99 Author: bganapa <[email protected]> Date: Tue Mar 10 13:58:14 2020 -0700 Update Updates.json commit adaabc1bd3b17d60f9ac39b4d95e7d0df60019ca Author: bganapa <[email protected]> Date: Wed Mar 4 18:07:20 2020 -0800 Changing casing in resourcgroups to resourceGroups commit 72efdec25338cfbb9fea108dcfb390f4c5ff6295 Author: bganapa <[email protected]> Date: Thu Feb 27 17:26:56 2020 -0800 Update to have $(this-folder)/ in the input files * Add autorest config to readme.md * Fix path reference * Auto-generated values * regenerated all-api-versions * Cli onboard desktopvirtualization (#9367) * cli validation for desktopvirtualization * correct readme title Co-authored-by: Changlong Liu <[email protected]> * [Compute] [SIG] [BugFix] Remove ID as required because update gallery image version is failing when ID is not present (#9257) * remove id as required * update for july too Co-authored-by: Jerry Chan <[email protected]> * Fix bad readme.go.md in azuredata (#9370) * Fix bad readme.go.md in azuredata * Fix comments * EventHub: added optional keyVersion property in KeyVaultProperties (#9335) * added optional keyVersion property in KeyVaultProperties * Keyvault properties to Array Co-authored-by: v-ajnava <[email protected]> * Adding the new resource type PrivateLinkForAzureAD (#8854) * Adding the new resource type PrivateLinkForAzureAD * Added the example * Updated the example * Updated the definition for privateLinkforAzureAD * Added privatelinkresource * Added privatelinkresource * Updated definitions * Updated definitions * Spell check * Moved to different files * Fixing Model validation * added xmspageable * Fixing example * Added nextlinks and corrected the versions in the examples * Added PUt/PATCH/DELETE to comply with a trackedResource * Fixes for Model Validation + AllTenants Property Fixed the error messages thrown by model validation as well as introduced the "allTenants" property under privatelinkpolicy * Fixes for Prettier Check Pushing fixes done by prettier check Co-authored-by: Arturo Lucatero <[email protected]> * regenerated all-api-versions * tf support secondary branch (#9378) Co-authored-by: Xiaoxu Qi <[email protected]> * attestation fix (#9077) * fixing attestation * undo unnecessary changes * missing * [Hub Generated] Review request for Microsoft.Insights to add version preview/2020-02-10-preview (#8383) * Adds base for updating Microsoft.Insights from version preview/2019-10-17-preview to version 2020-02-10-preview * Updates readme * Updates API version in new specs and examples * Added WebTestResults API * Adjusted tiles * made changes to example file. * Adjusted example to have better sample values * Updated doc to produce better help file. * corrected example file. * added _get to operationId to match GetInOperationName requirement * Adjustments from review * Adjusted enum for downloadAs * Adjusted file to make more readable. * Added better descriptions to the file format enum. * Removed partition ID from the example. * Updated description * Changes made based on Igors review. * removed dashes from example and removed _Get from operationId * Fixes typeo * adjusted with prettier * adjusted json * adjusted to a put call and added operationslist as per code review from arm team. * corrected to post * added operatinsList.json example file * adjusted file name. * adjusted example file. * adjusted case of microsoft.insights * minor fix * ran prettier-fix * changes per code review. * Fixed case in example file. * removed nextLink from Operations * regenerated all-api-versions * Fix the format of shareUsageBytes to show larger file share size (#9315) * updated modelAsString to true (#9327) * [Hub Generated] Review request for Microsoft.DigitalTwins to add version preview/2020-03-01-preview (#9304) * init commit * updates * re-add sku as future use * make sku writeOnly so it is not expected in return * correction * test * fixup * [AzureSearch] Add more examples on IP-restriction and private endpoint + fixes (#9381) * update iprules and add more samples for create and update;fix incorrect sample for private endpoint * verbose change * typo fix * wording fix * fix model validation * On boarding Solutions to latest stable API version (#8630) * Copy solutions files from 2015-06-01-preview * update API version * update readme * Add required to ExternalSecuritySolution * fix comment * fix conflict * fic conflict2 * fix conflict3 * fix conflict4 Co-authored-by: Arik Riklin <[email protected]> * regenerated all-api-versions * Revert "Add 'capabilities' field to Cognitive Services account properties. (#9309)" (#9360) * Add resource type sqlServerInstances (#9197) * Add resource type sqlServerInstances * add to resource provider - Microsoft.AzureData * exactly same REST API definitions as existing resource types of the same resource provider * Add property description and mark required properties # update examples to include required properties * set createTime and updateTime property to readonly update CreateOrUpdateSqlServerInstance.json sample to not include readonly properties in its request. Co-authored-by: Dong Cao <[email protected]> * Remove quotes from data queries in RI apis (#9323) * [DataFactory]Store settings should be added for Delete and GetMetadata (#9208) * [DataFactory]Store settings should be added for Delete and GetMetadata Activity * Add format settings for GetMetadata * [Hub Generated] Review request for Microsoft.ChangeAnalysis to add version preview/2020-04-01-preview (#8981) * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * add swagger spec second time * trying to fix violations #1 * adding descriptions and schema tag for default error * removing required location element from proxy resource. * adding prettifier fixed * update 3 * update 4 * update 5 * update 6 * update 7 * update 8 * update 9 * update 10 * update 11 * update 12 * update 13 * update 14 * update 15 * update 16 * update 17 * update 18 * Adds suppression to readme * updating comments of few models * changing description of few elements * prettier run: Co-authored-by: Alex Dubinkov <[email protected]> * regenerated all-api-versions * Fix readme.go.md for some sql service (#9348) * Update network (#9349) * Add multiapi section (#9347) * Dataplane swagger for tables (#8151) * adding swagger for tables dataplane * updating produces/consumes, adding format parameter and adding DataServiceVersion header * update swagger so that query parameters do not appear in x-ms-paths * add new custom words, fix incorrect api version * making suggested changes to continuation header, response status codes * Updates to tables spec * Fixed indentation * Removed storage references * Grammar * Improved match condition description * Remove format statements * Removed excess tags * Fix extra commas * Added missing example * Updated Delete example * Run prettier * Removed duplicate API version * Fixed insert response * Removed 2018 readme tag * Remove storage name * Remove multi-api reference Co-authored-by: Sam Hurd <[email protected]> Co-authored-by: annatisch <[email protected]> * regenerated all-api-versions * Datr m (#9332) * update readme docs * add nullables * add autogen * location required * add require to all * add requires * prettier * track resoruce ref and require for properties * remove # * fix # resoruce * pr comments * fix ruby * go fix * azure_mgmt_desktop_virtualization * rekickoff tests * regenerated all-api-versions * Allow empty access policies array in HealthcareApis (#9326) * Allow empty access polies array in HealthcareApis. * accessPolicies property can be omitted * [CDN] Add API version 2020-04-15 (#9242) * regenerated all-api-versions * Update readme.md (#9384) * Update readme.md Adding stable version to not break existing APIs * Added examples * fix example * prettier fix * regenerated all-api-versions * [MixedReality] Version Iteration for new Releases (#9351) * Version Iteration for new Releases (#8848) * Version Iteration for new Releases There are going to be 2 significant releases: 1. Public Preview of Remote Rendering in April 6th 2. GA of Spatial Anchors in May * Referring new swagger files in readme.md * Specifying default package version as 2020-05-01 * Fix MV * Fix MV (#9397) Fix MV in Patch examples Co-authored-by: Xiangyu Luo <[email protected]> Co-authored-by: Lei Ni <[email protected]> * fix network (#9369) * fix network * duplicated publicipprefix * fixed example in 2018-01-01 * final updates * missing examples * regenerated all-api-versions * SQLDB - update LicenseType description (#9001) * SDK support for Table and Queue Storage Services (#9259) * Adding table spec, without examples * Adding queue swagger, also updating comments for table * Updated the models to include ARM fields, completed, no examples * Added list table and queue services spec * Adding table CRUD examples * Adding Queue CRUD examples * Validation complete, TablName changed to camelCase * Modified comment * Spell correction * changing order in readme.md * Changed the object name from Queue to StorageQueue, as sdk code gen throws name conflict error with Collections.Queue * Resolve prettier check errors * Change URI param to be camel case * updated default error response schema * Change Default error response model schema * Added x-ms-nextLink * regenerated all-api-versions * [ACR] add regionEndpointEnabled to replication properties and replicationUpdateParameters (#8840) * add regionendpointenabled to replication properties and replicationupdateparameters * fix property placement error * Update spec. with update properties * Update descriptions Co-authored-by: Tosin Adewale <[email protected]> * update triage label (#9396) * validate blockchain cli codegen (#9089) * validate blockchain cli codegen * use strong password with length>=12 Co-authored-by: Changlong Liu <[email protected]> * feat: add subscription 2019 10 01 preview (#9388) * [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (#9288) * adding the views api to the 2019-11-01 version * Fix api version value * adding private view list example document * Fix enum conflict * fix Granularity enum type * Add api version of go SDK for imagebuilder (#9408) * Update PR template (#9371) * Update PR template * Add FAQ link * add Microsoft.AVS 2019-08-09-preview API spec (#9307) * cp -r vmwarevirtustream vmware * rebrand * add sku to PrivateCloud * add SSL thumbprints * Fix description typo (#5) * lists return value[] * suppress R3020 * fix suppress * add Locations_ prefix Co-authored-by: jspearman3 <[email protected]> * regenerated all-api-versions * Add 2020-04-01 API specification for Microsoft.Peering (#9361) * Remove readonly flag from microsoftSessionAddress properties in BgpSession; add an example for IxRs directPeeringType * Add 2020-04-01 API specification for Microsoft.Peering * Fix subId * Fix static validation issues * Fix GetPeeringReceivedRoutes example * Fix PeeringServiceSku * Add RPKI to custom-words * Update readme to include package-2020-04-01 * Fix input file path in package-2020-04-01 * Fix ErrorResponse data model Co-authored-by: Praneeth Sanapathi <[email protected]> * Move added client name IdentityUserAssignedIdentitiesValue into an inner scope (#9363) * Bug fixes: skip url encoding for ScopeParameter; add client name for userAssignedIdentities. * Pretty check fix. * Move added client name into additionalProperties of userAssignedIdentities. * Change operationID for table and queue, update the name of an example (#9410) * update version of rest-api-specs-scripts in PPE (#9420) Co-authored-by: Jianye Xi <j…
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…zure#9002) * Added properties that were missed in 2019-11-01-preview API version. * Fixed prettier. * Added readonly to private endpoint connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR were reviewed and approved in the private repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/1199