Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-Renaming ResourceGroupParameter to ResourceGroupNameParmameter #8345

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

bganapa
Copy link
Member

@bganapa bganapa commented Feb 10, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bganapa bganapa merged commit 8234329 into Azure:stackadmin Feb 10, 2020
Copy link
Contributor

@ionuttulai ionuttulai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like I missed this one in the initial commit,

viananth added a commit to viananth/azure-rest-api-specs that referenced this pull request Mar 25, 2020
commit adaabc1
Author: bganapa <[email protected]>
Date:   Wed Mar 4 18:07:20 2020 -0800

    Changing casing in resourcgroups to resourceGroups

commit fb5e9ae
Author: bganapa <[email protected]>
Date:   Wed Feb 26 14:00:37 2020 -0800

    Update Readme.md to have $(this-folder)/ for the input-file

commit 8234329
Author: bganapa <[email protected]>
Date:   Sun Feb 9 17:11:33 2020 -0800

    Fix-Renaming ResourceGroupParameter to ResourceGroupNameParmameter (Azure#8345)
markcowl pushed a commit that referenced this pull request Sep 11, 2020
* Cumulative commit message:
commit adaabc1
Author: bganapa <[email protected]>
Date:   Wed Mar 4 18:07:20 2020 -0800

    Changing casing in resourcgroups to resourceGroups

commit fb5e9ae
Author: bganapa <[email protected]>
Date:   Wed Feb 26 14:00:37 2020 -0800

    Update Readme.md to have $(this-folder)/ for the input-file

commit 8234329
Author: bganapa <[email protected]>
Date:   Sun Feb 9 17:11:33 2020 -0800

    Fix-Renaming ResourceGroupParameter to ResourceGroupNameParmameter (#8345)

* bug fixes and autorest config addition

* Fix path, read-only properties and example

* Fix model validation

* Suppress camelcase warnings in Activation.json

* Suppress RequiredPropertiesMissingInResourceModel

* Suppress PathResoourceProviderNamePascalCase

* Add default error response

* Add 204 response for delete

* Remove 404 and add 202 in examples

* Fix model validation failures
nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020
* Cumulative commit message:
commit adaabc1
Author: bganapa <[email protected]>
Date:   Wed Mar 4 18:07:20 2020 -0800

    Changing casing in resourcgroups to resourceGroups

commit fb5e9ae
Author: bganapa <[email protected]>
Date:   Wed Feb 26 14:00:37 2020 -0800

    Update Readme.md to have $(this-folder)/ for the input-file

commit 8234329
Author: bganapa <[email protected]>
Date:   Sun Feb 9 17:11:33 2020 -0800

    Fix-Renaming ResourceGroupParameter to ResourceGroupNameParmameter (Azure#8345)

* bug fixes and autorest config addition

* Fix path, read-only properties and example

* Fix model validation

* Suppress camelcase warnings in Activation.json

* Suppress RequiredPropertiesMissingInResourceModel

* Suppress PathResoourceProviderNamePascalCase

* Add default error response

* Add 204 response for delete

* Remove 404 and add 202 in examples

* Fix model validation failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants