[Azure Stack] Updates to Azs.AzureBridge.Admin spec #9035

viananth · 2020-04-13T18:44:40Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

commit adaabc1 Author: bganapa <[email protected]> Date: Wed Mar 4 18:07:20 2020 -0800 Changing casing in resourcgroups to resourceGroups commit fb5e9ae Author: bganapa <[email protected]> Date: Wed Feb 26 14:00:37 2020 -0800 Update Readme.md to have $(this-folder)/ for the input-file commit 8234329 Author: bganapa <[email protected]> Date: Sun Feb 9 17:11:33 2020 -0800 Fix-Renaming ResourceGroupParameter to ResourceGroupNameParmameter (Azure#8345)

azure-pipelines · 2020-04-13T18:44:56Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-04-13T18:46:09Z

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-13T18:46:09Z

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-13T18:46:14Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-13T18:46:14Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-13T18:49:27Z

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-13T18:58:03Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-04-13T19:09:10Z

Can one of the admins verify this patch?

bganapa · 2020-04-13T19:28:43Z

These are fixes to the existing swagger specs to the admin API surface of Azurestack. This API surface is consumed only thru powershell in azurestack. None of these are really breaking changes

azure-pipelines · 2020-04-22T18:43:30Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-04-22T18:55:35Z

azure-sdk-for-trenton

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

viananth · 2020-05-26T04:40:53Z

/azp run

azure-pipelines · 2020-05-26T04:41:12Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-sdkautomation · 2020-05-26T04:42:35Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-05-26T05:17:09Z

Azure Pipelines successfully started running 1 pipeline(s).

viananth · 2020-05-27T05:30:18Z

@markcowl, Mark, could you please take a look at this PR? The lintDiff errors are mostly pascalcase errors (reported wrong, CI issue):

Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureBridge.Admin/activations/{activationName}/products/{productName}'

Breaking changes are for autorest generation config. @bganapa FYI

markcowl · 2020-06-15T23:27:22Z

/azp run public.rest-api-specs

azure-pipelines · 2020-06-15T23:27:33Z

Azure Pipelines successfully started running 1 pipeline(s).

markcowl · 2020-06-15T23:28:39Z

@bganapa The breakign changes look like real breakign changes (for example, resourceGroup -> resourceGroupName). If these are intentional, then they are OK.

for the linter errors, please suppress these in your readme.md file.

bganapa · 2020-06-15T23:41:36Z

@markcowl Thanks. Yes the change is intentional, we are taking many breaking changes as bug fixes
In the following URI Path, Calling it as resourceGroupName is the standard everywhere. We had the option of either renaming it in the generator metadata or fix it for all in the spec.
resourcegroups/{resourceGroup}

We decided to do the breaking change in the spec as our admin specs are still in 'preview'

bganapa · 2020-06-15T23:42:59Z

@viananth as mark mentioned above
for the linter errors, please suppress these in your readme.md file.

markcowl · 2020-07-22T22:13:51Z

@viananth Ping? Need to suppress the linter errors and I can merge this as an approved breaking change.

viananth · 2020-08-03T19:13:23Z

/azp run

azure-pipelines · 2020-08-03T19:13:42Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-sdkautomation · 2020-08-03T19:14:52Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-03T19:15:01Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

markcowl · 2020-08-07T23:46:49Z

@viananth good sample of suppressions here: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/readme.md

openapi-pipeline-app · 2020-08-11T17:48:44Z

[Staging] Swagger Validation Report

️❌BreakingChange: 51 Errors, 0 Warnings [Detail] [Expand]

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroup}/providers/Microsoft.AzureBridge.Admin/activations/{activationName}/downloadedProducts/{productName}' removed or restructured? Old: Microsoft.AzureBridge.Admin/preview/2016-01-01/DownloadedProduct.json#L58:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroup}/providers/Microsoft.AzureBridge.Admin/activations/{activationName}/products/{productName}/download' removed or restructured? Old: Microsoft.AzureBridge.Admin/preview/2016-01-01/Product.json#L106:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroup}/providers/Microsoft.AzureBridge.Admin/activations/{activationName}/products/{productName}' removed or restructured? Old: Microsoft.AzureBridge.Admin/preview/2016-01-01/Product.json#L58:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroup}/providers/Microsoft.AzureBridge.Admin/activations/{activationName}/downloadedProducts' removed or restructured? Old: Microsoft.AzureBridge.Admin/preview/2016-01-01/DownloadedProduct.json#L13:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroup}/providers/Microsoft.AzureBridge.Admin/activations/{activationName}' removed or restructured? Old: Microsoft.AzureBridge.Admin/preview/2016-01-01/Activation.json#L55:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroup}/providers/Microsoft.AzureBridge.Admin/activations' removed or restructured? Old: Microsoft.AzureBridge.Admin/preview/2016-01-01/Activation.json#L13:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroup}/providers/Microsoft.AzureBridge.Admin/activations/{activationName}/products' removed or restructured? Old: Microsoft.AzureBridge.Admin/preview/2016-01-01/Product.json#L13:5
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupParameter' removed or renamed? New: Microsoft.AzureBridge.Admin/preview/2016-01-01/DownloadedProduct.json#L252:3 Old: Microsoft.AzureBridge.Admin/preview/2016-01-01/DownloadedProduct.json#L231:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupParameter' removed or renamed? New: Microsoft.AzureBridge.Admin/preview/2016-01-01/AzureBridge.json#L526:3 Old: Microsoft.AzureBridge.Admin/preview/2016-01-01/AzureBridge.json#L530:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupParameter' removed or renamed? New: Microsoft.AzureBridge.Admin/preview/2016-01-01/Activation.json#L306:3 Old: Microsoft.AzureBridge.Admin/preview/2016-01-01/Activation.json#L248:3

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-11T17:48:57Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T18:18:43Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T18:29:18Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T19:03:46Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T19:16:47Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T19:26:00Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T19:33:00Z

Azure Pipelines successfully started running 1 pipeline(s).

viananth · 2020-08-11T19:49:00Z

@markcowl, I fixed the lint and model errors. Could you pls merge this PR? Thanks!

viananth · 2020-09-01T16:57:45Z

@markcowl, Mark, Fixed lint errors. Could you pls merge this PR? Thanks!

openapi-sdkautomation · 2020-09-11T22:48:43Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

* Cumulative commit message: commit adaabc1 Author: bganapa <[email protected]> Date: Wed Mar 4 18:07:20 2020 -0800 Changing casing in resourcgroups to resourceGroups commit fb5e9ae Author: bganapa <[email protected]> Date: Wed Feb 26 14:00:37 2020 -0800 Update Readme.md to have $(this-folder)/ for the input-file commit 8234329 Author: bganapa <[email protected]> Date: Sun Feb 9 17:11:33 2020 -0800 Fix-Renaming ResourceGroupParameter to ResourceGroupNameParmameter (Azure#8345) * bug fixes and autorest config addition * Fix path, read-only properties and example * Fix model validation * Suppress camelcase warnings in Activation.json * Suppress RequiredPropertiesMissingInResourceModel * Suppress PathResoourceProviderNamePascalCase * Add default error response * Add 204 response for delete * Remove 404 and add 202 in examples * Fix model validation failures

…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: [Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2020-10-31 (Azure#10653) [SRP] Introduce 2020-08-01-preview version. (Azure#10570) Update Readmes for Python for Automanage (Azure#10633) Incident entities (Azure#10648) Fix Billing Swagger (Azure#10276) Connected machine az cli (Azure#10640) [Azure Stack] Updates to Azs.AzureBridge.Admin spec (Azure#9035)

viananth added 2 commits March 25, 2020 15:39

bug fixes and autorest config addition

80c15ba

viananth requested a review from bganapa April 13, 2020 18:44

openapi-assignment-bot bot assigned markcowl Apr 13, 2020

bganapa approved these changes Apr 13, 2020

View reviewed changes

Fix path, read-only properties and example

171ba76

Fix model validation

bc9a2f6

markcowl assigned bganapa Jun 15, 2020

markcowl added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Jun 15, 2020

bganapa assigned viananth Jun 15, 2020

Suppress camelcase warnings in Activation.json

d6975fc

Suppress RequiredPropertiesMissingInResourceModel

9c17cad

Suppress PathResoourceProviderNamePascalCase

f2e5f83

Add default error response

d87e7a5

Add 204 response for delete

f7bb61c

Remove 404 and add 202 in examples

840e504

Fix model validation failures

94ec55f

markcowl added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Sep 11, 2020

markcowl merged commit ff5dc59 into Azure:master Sep 11, 2020

[Azure Stack] Updates to Azs.AzureBridge.Admin spec #9035

[Azure Stack] Updates to Azs.AzureBridge.Admin spec #9035

Conversation

viananth commented Apr 13, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Apr 13, 2020

openapi-sdkautomation bot commented Apr 13, 2020 • edited Loading

azure-cli-extensions

openapi-sdkautomation bot commented Apr 13, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Apr 13, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Apr 13, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Apr 13, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Apr 13, 2020 • edited Loading

azure-sdk-for-js - Release

azuresdkci commented Apr 13, 2020

bganapa commented Apr 13, 2020

azure-pipelines bot commented Apr 22, 2020

openapi-sdkautomation bot commented Apr 22, 2020 • edited Loading

azure-sdk-for-trenton

viananth commented May 26, 2020

azure-pipelines bot commented May 26, 2020

openapi-sdkautomation bot commented May 26, 2020 • edited Loading

Azure CLI Extension Generation - Release

azure-pipelines bot commented May 26, 2020

viananth commented May 27, 2020

markcowl commented Jun 15, 2020

azure-pipelines bot commented Jun 15, 2020

markcowl commented Jun 15, 2020 • edited Loading

bganapa commented Jun 15, 2020

bganapa commented Jun 15, 2020

markcowl commented Jul 22, 2020

viananth commented Aug 3, 2020

azure-pipelines bot commented Aug 3, 2020

openapi-sdkautomation bot commented Aug 3, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Aug 3, 2020 • edited Loading

Trenton Generation - Release

markcowl commented Aug 7, 2020

openapi-pipeline-app bot commented Aug 11, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Aug 11, 2020

azure-pipelines bot commented Aug 11, 2020

azure-pipelines bot commented Aug 11, 2020

azure-pipelines bot commented Aug 11, 2020

azure-pipelines bot commented Aug 11, 2020

azure-pipelines bot commented Aug 11, 2020

azure-pipelines bot commented Aug 11, 2020

viananth commented Aug 11, 2020

viananth commented Sep 1, 2020

openapi-sdkautomation bot commented Sep 11, 2020 • edited Loading

azure-resource-manager-schemas - Release

openapi-sdkautomation bot commented Apr 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 22, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 26, 2020 •

edited

Loading

markcowl commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 3, 2020 •

edited

Loading

openapi-pipeline-app bot commented Aug 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 11, 2020 •

edited

Loading