Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Integration Runtime semantic validation error. #6989

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Fixed Integration Runtime semantic validation error. #6989

merged 1 commit into from
Aug 20, 2019

Conversation

zhangyd2015
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 19, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 4c59155, Iteration 1)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Warning datafactory/resource-manager/v2017_09_01_preview [Logs]
  • In-Progress datafactory/resource-manager/v2018_06_01 [Logs]
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress datafactory/mgmt/2018-06-01 [Logs]
  • In-Progress preview/datafactory/mgmt/2017-09-01-preview [Logs]
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.

@azuresdkci azuresdkci requested a review from raych1 August 19, 2019 06:41
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 19, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Aug 19, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 19, 2019
Merged
raych1
raych1 reviewed Aug 19, 2019
View reviewed changes
Copy link
Member

@raych1 raych1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangyd2015 , change property from optional to required is a breaking change to SDK.

@zhangyd2015
Copy link
Contributor Author

@zhangyd2015 , change property from optional to required is a breaking change to SDK.

@raych1 We don't want to change this however we got semantic validation error for new PR. Looks like there is new validation rule that requires the properties for "discriminator" need to be required.
So this property is actually always required since it is discriminator.
What do you think?

@raych1
Copy link
Member

raych1 commented Aug 19, 2019

@zhangyd2015 , change property from optional to required is a breaking change to SDK.

@raych1 We don't want to change this however we got semantic validation error for new PR. Looks like there is new validation rule that requires the properties for "discriminator" need to be required.
So this property is actually always required since it is discriminator.
What do you think?

To confirm with you, from SDK user perspective, they always pass the type as parameter, right? Can I assume this potential SDK breaking change will not break real user scenario?

@zhangyd2015
Copy link
Contributor Author

@zhangyd2015 , change property from optional to required is a breaking change to SDK.
@raych1 We don't want to change this however we got semantic validation error for new PR. Looks like there is new validation rule that requires the properties for "discriminator" need to be required.
So this property is actually always required since it is discriminator.
What do you think?

To confirm with you, from SDK user perspective, they always pass the type as parameter, right? Can I assume this potential SDK breaking change will not break real user scenario?

Right. type is always required from the beginning of the service. it definitely won't break real user scenario.

@raych1 raych1 self-requested a review August 20, 2019 00:35
@raych1 raych1 merged commit ae48ce6 into Azure:master Aug 20, 2019
@raych1 raych1 mentioned this pull request Aug 21, 2019
Merged
5 tasks
pathuang-sia added a commit that referenced this pull request Oct 26, 2022
@pathuang-sia @Arkanayan @vishal-kadam
[Microsoft.AzureStackHCI] 2021-09-01-preview update (#7147)
1e9e420 
* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <[email protected]>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <[email protected]>

* Add canceled to provisioningState enum

Co-authored-by: Arka <[email protected]>
Co-authored-by: vishal-kadam <[email protected]>
Co-authored-by: Vishal Kadam <[email protected]>
xiaoxuqi-ms pushed a commit that referenced this pull request Nov 15, 2022
@pathuang-sia @Arkanayan
@vishal-kadam @aeweston-msft
[Hub Generated] Publish private branch 'release-azurestackhci-Microso…
8bcf420 
…ft.AzureStackHCI-2021-09-01-preview' (#21296)

* Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* resolve conflicts

* [Microsoft.AzureStackHCI] 2021-09-01-preview update (#7147)

* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <[email protected]>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <[email protected]>

* Add canceled to provisioningState enum

Co-authored-by: Arka <[email protected]>
Co-authored-by: vishal-kadam <[email protected]>
Co-authored-by: Vishal Kadam <[email protected]>

* cherry-pick merge conflict resolution

* storage container changes (#6614)

* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <[email protected]>

* Change hybrididentitymetadata vmid to resourceUid (#4921)

* change hybrididentitymetadata vmid to resourceUid

* update examples

* fix missed merging changes

* cherry-pick merge conflict resolution

* remove 2022-09-01 examples

* git difftool align differences with RPSaaSMaster

* spellcheck fix

* breaking change cross version fix

* fix version

* fix custom word typo

* fix default tag to 2022-10

* address description and example feedback

* address swagger modelvalidation errors

* missed linter and model validation error

* prettier fix

* fixing breaking change errors

* backport common.json from 2021-07-01-preview

* prettier on common.json

* replace Idenitty from v2 definitions

* fix property bag capitalization

* Add missed capitalization modifications

* Add missed semantic fix

* Add missed semantic fix

* revert property definition capitalization according to reviewer feedback

Co-authored-by: Arka <[email protected]>
Co-authored-by: vishal-kadam <[email protected]>
Co-authored-by: Vishal Kadam <[email protected]>
Co-authored-by: aeweston-msft <[email protected]>
anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
@pathuang-sia @Arkanayan
@vishal-kadam @aeweston-msft @anandanthony
[Hub Generated] Publish private branch 'release-azurestackhci-Microso…
537a474 
…ft.AzureStackHCI-2021-09-01-preview' (Azure#21296)

* Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* resolve conflicts

* [Microsoft.AzureStackHCI] 2021-09-01-preview update (Azure#7147)

* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (Azure#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (Azure#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (Azure#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (Azure#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <[email protected]>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (Azure#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <[email protected]>

* Add canceled to provisioningState enum

Co-authored-by: Arka <[email protected]>
Co-authored-by: vishal-kadam <[email protected]>
Co-authored-by: Vishal Kadam <[email protected]>

* cherry-pick merge conflict resolution

* storage container changes (Azure#6614)

* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <[email protected]>

* Change hybrididentitymetadata vmid to resourceUid (Azure#4921)

* change hybrididentitymetadata vmid to resourceUid

* update examples

* fix missed merging changes

* cherry-pick merge conflict resolution

* remove 2022-09-01 examples

* git difftool align differences with RPSaaSMaster

* spellcheck fix

* breaking change cross version fix

* fix version

* fix custom word typo

* fix default tag to 2022-10

* address description and example feedback

* address swagger modelvalidation errors

* missed linter and model validation error

* prettier fix

* fixing breaking change errors

* backport common.json from 2021-07-01-preview

* prettier on common.json

* replace Idenitty from v2 definitions

* fix property bag capitalization

* Add missed capitalization modifications

* Add missed semantic fix

* Add missed semantic fix

* revert property definition capitalization according to reviewer feedback

Co-authored-by: Arka <[email protected]>
Co-authored-by: vishal-kadam <[email protected]>
Co-authored-by: Vishal Kadam <[email protected]>
Co-authored-by: aeweston-msft <[email protected]>
kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
@pathuang-sia @Arkanayan
@vishal-kadam @aeweston-msft @kayousef
[Hub Generated] Publish private branch 'release-azurestackhci-Microso…
fbd9082 
…ft.AzureStackHCI-2021-09-01-preview' (Azure#21296)

* Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* resolve conflicts

* [Microsoft.AzureStackHCI] 2021-09-01-preview update (Azure#7147)

* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (Azure#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (Azure#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (Azure#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (Azure#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <[email protected]>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (Azure#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <[email protected]>

* Add canceled to provisioningState enum

Co-authored-by: Arka <[email protected]>
Co-authored-by: vishal-kadam <[email protected]>
Co-authored-by: Vishal Kadam <[email protected]>

* cherry-pick merge conflict resolution

* storage container changes (Azure#6614)

* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <[email protected]>

* Change hybrididentitymetadata vmid to resourceUid (Azure#4921)

* change hybrididentitymetadata vmid to resourceUid

* update examples

* fix missed merging changes

* cherry-pick merge conflict resolution

* remove 2022-09-01 examples

* git difftool align differences with RPSaaSMaster

* spellcheck fix

* breaking change cross version fix

* fix version

* fix custom word typo

* fix default tag to 2022-10

* address description and example feedback

* address swagger modelvalidation errors

* missed linter and model validation error

* prettier fix

* fixing breaking change errors

* backport common.json from 2021-07-01-preview

* prettier on common.json

* replace Idenitty from v2 definitions

* fix property bag capitalization

* Add missed capitalization modifications

* Add missed semantic fix

* Add missed semantic fix

* revert property definition capitalization according to reviewer feedback

Co-authored-by: Arka <[email protected]>
Co-authored-by: vishal-kadam <[email protected]>
Co-authored-by: Vishal Kadam <[email protected]>
Co-authored-by: aeweston-msft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raych1 raych1 raych1 approved these changes

Assignees

@raych1 raych1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangyd2015 @azuresdkci @AutorestCI @raych1