Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Express Custom Setup #6969

Conversation

liubing-microsoft
Copy link
Contributor

@liubing-microsoft liubing-microsoft commented Aug 15, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 15, 2019

In Testing, Please Ignore

[Logs] (Generated from fc0bdde, Iteration 8)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Warning datafactory/resource-manager/v2017_09_01_preview [Logs]
  • In-Progress datafactory/resource-manager/v2018_06_01 [Logs]
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress datafactory/mgmt/2018-06-01 [Logs]
  • In-Progress preview/datafactory/mgmt/2017-09-01-preview [Logs]
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.

@AutorestCI
Copy link

AutorestCI commented Aug 15, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7023

@AutorestCI
Copy link

AutorestCI commented Aug 15, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5658

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantic and LintDiff checks fail, please fix this.

@ArcturusZhang ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 16, 2019
@liubing-microsoft
Copy link
Contributor Author

Hi @ArcturusZhang , I have updated my changes but the semantic check is still failed which is not introduced by my changes. How to handle it?

error :
code: OAV131
error: DISCRIMINATOR_NOT_REQUIRED
name: discriminator
params:

  • type
    message: discriminator must be a required property.
    path:
  • 'definitions,IntegrationRuntimeStatus'

error :
code: OAV131
error: DISCRIMINATOR_NOT_REQUIRED
name: discriminator
params:

  • type
    message: discriminator must be a required property.
    path:
  • 'definitions,SsisObjectMetadata'

@ArcturusZhang
Copy link
Member

ArcturusZhang commented Aug 16, 2019

Hi @ArcturusZhang , I have updated my changes but the semantic check is still failed which is not introduced by my changes. How to handle it?

error :
code: OAV131
error: DISCRIMINATOR_NOT_REQUIRED
name: discriminator
params:

  • type
    message: discriminator must be a required property.
    path:
  • 'definitions,IntegrationRuntimeStatus'

error :
code: OAV131
error: DISCRIMINATOR_NOT_REQUIRED
name: discriminator
params:

  • type
    message: discriminator must be a required property.
    path:
  • 'definitions,SsisObjectMetadata'

This is caused by something changed in the semantic tool. I asked owner of CI @NullMDR how to resolve this, but do not get reply right now. After they resolve this issue, we can re-run the tests.

@liubing-microsoft
Copy link
Contributor Author

liubing-microsoft commented Aug 19, 2019

@ArcturusZhang , Could you tell me when the semantic tool issue can be resolved? It will block our feature release. Thank you.

@raych1
Copy link
Member

raych1 commented Aug 21, 2019

@liubing-microsoft , the semantic errors was fixed by PR, please merge the change and re-run semantic check, it should pass.

@liubing-microsoft
Copy link
Contributor Author

Semantic and LintDiff checks fail, please fix this.

Hi @ArcturusZhang , all checks have passed.

@ArcturusZhang
Copy link
Member

Semantic and LintDiff checks fail, please fix this.

Hi @ArcturusZhang , all checks have passed.

I approved this. But please wait for ARM team response before you merge this

@ravbhatnagar
Copy link
Contributor

this is typically a breaking change, but for ADF the scenario is a bit more nuanced. We have discussed this in person in the past and given them exception with the understanding that we will bring up this usecase in front of folks like MarkRuss and seek guidance. Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 29, 2019
@ArcturusZhang ArcturusZhang merged commit 64f5a1d into Azure:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants