-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Express Custom Setup #6969
support Express Custom Setup #6969
Conversation
In Testing, Please Ignore[Logs] (Generated from fc0bdde, Iteration 8).NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Python: test-repo-billy/azure-sdk-for-python [Logs]
Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
|
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
...resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/IntegrationRuntime.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semantic and LintDiff checks fail, please fix this.
...resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/IntegrationRuntime.json
Outdated
Show resolved
Hide resolved
...resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/IntegrationRuntime.json
Outdated
Show resolved
Hide resolved
...resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/IntegrationRuntime.json
Outdated
Show resolved
Hide resolved
Hi @ArcturusZhang , I have updated my changes but the semantic check is still failed which is not introduced by my changes. How to handle it?
|
This is caused by something changed in the semantic tool. I asked owner of CI @NullMDR how to resolve this, but do not get reply right now. After they resolve this issue, we can re-run the tests. |
@ArcturusZhang , Could you tell me when the semantic tool issue can be resolved? It will block our feature release. Thank you. |
@liubing-microsoft , the semantic errors was fixed by PR, please merge the change and re-run semantic check, it should pass. |
Hi @ArcturusZhang , all checks have passed. |
I approved this. But please wait for ARM team response before you merge this |
this is typically a breaking change, but for ADF the scenario is a bit more nuanced. We have discussed this in person in the past and given them exception with the understanding that we will bring up this usecase in front of folks like MarkRuss and seek guidance. Signing off from ARM side. |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.