Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] fix schema and example validation warnings #4980

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Jan 3, 2019

Fixes these autorest warnings:

WARNING (DescriptionAndTitleMissing/R4000/SDKViolation): 'kubeconfigs' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    - file:///Users/matt/Projects/azure-rest-api-specs/specification/containerservices/resource-manager/Microsoft.ContainerService/stable/2018-03-31/managedClusters.json:1511:8 ($.definitions.CredentialResults.properties.kubeconfigs)

Apologies for the other whitespaces changes--that's VS Code's swagger plugin cleaning things up.

cc: @julienstroheker @zqingqing1

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Jan 3, 2019

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#816

@AutorestCI
Copy link

AutorestCI commented Jan 3, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4064

@AutorestCI
Copy link

AutorestCI commented Jan 3, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jan 3, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jan 3, 2019

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4437

@AutorestCI
Copy link

AutorestCI commented Jan 3, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3831

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anuchandy
Copy link
Member

@mboersma thanks!.

There are couple of model (example) validation errors. Are we planning to fix them as part of this PR or should we create a work item to address this in future?

@mboersma
Copy link
Member Author

mboersma commented Jan 5, 2019

There are couple of model (example) validation errors.

@anuchandy sure, I can fix those as well in this PR.

@mboersma mboersma changed the title [AKS] add missing description fields [AKS] fix schema and example validation warnings Jan 7, 2019
@mboersma
Copy link
Member Author

mboersma commented Jan 7, 2019

@zqingqing1 I reworked the AAD and SP reset endpoint examples so they pass now. Could you check that this change looks correct?

@mboersma mboersma force-pushed the fix-validation-errors branch from 04a08f6 to a2ab98d Compare January 8, 2019 16:24
@mboersma
Copy link
Member Author

mboersma commented Jan 8, 2019

@anuchandy I reverted this PR to the original commit you reviewed, because @zqingqing1 is addressing the example validation errors in #4948.

@zqingqing1
Copy link
Member

lgtm

@lmazuel
Copy link
Member

lmazuel commented Jan 8, 2019

@anuchandy merging the PR for Python work, let me know if you have concerns

@lmazuel lmazuel merged commit 6999055 into Azure:master Jan 8, 2019
@mboersma mboersma deleted the fix-validation-errors branch January 10, 2019 17:44
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants