-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] fix schema and example validation warnings #4980
Conversation
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
@mboersma thanks!. There are couple of model (example) validation errors. Are we planning to fix them as part of this PR or should we create a work item to address this in future? |
@anuchandy sure, I can fix those as well in this PR. |
@zqingqing1 I reworked the AAD and SP reset endpoint examples so they pass now. Could you check that this change looks correct? |
04a08f6
to
a2ab98d
Compare
@anuchandy I reverted this PR to the original commit you reviewed, because @zqingqing1 is addressing the example validation errors in #4948. |
a2ab98d
to
84cef65
Compare
lgtm |
@anuchandy merging the PR for Python work, let me know if you have concerns |
Fixes these
autorest
warnings:Apologies for the other whitespaces changes--that's VS Code's swagger plugin cleaning things up.
cc: @julienstroheker @zqingqing1
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.