[AKS]: Remove 200/OK response from reset SP/AAD api #4948

zqingqing1 · 2018-12-19T19:56:55Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-portal-comment · 2018-12-19T19:56:57Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-12-19T19:57:33Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#816

AutorestCI · 2018-12-19T19:57:49Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-12-19T19:57:50Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4064

AutorestCI · 2018-12-19T19:58:23Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-12-19T19:58:40Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4437

AutorestCI · 2018-12-19T19:59:39Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3831

azuresdkci · 2018-12-19T20:02:40Z

Can one of the admins verify this patch?

jhendrixMSFT

Need confirmation from @ravbhatnagar that returning 202 from a synchronous operation is ok.

.../resource-manager/Microsoft.ContainerService/preview/2018-08-01-preview/managedClusters.json

azuresdkci · 2018-12-19T22:38:28Z

Hello!!

The Rest API Specs team wishes everyone a happy holiday and would like to kindly inform you that responses and review to Pull request will be delayed during the holiday period (now -> 2nds of January) to allow for Awesome reviewers to have an awesome time with their families during the holidays!

Thanks and Have a WONDERFUL HOLIDAY

jhendrixMSFT · 2018-12-20T18:15:37Z

@zqingqing1 can you please explain why this is being removed? It's introducing new SDK validation failures, see here. Current requirement is to model the terminal LRO state in the swagger.

zqingqing1 · 2018-12-20T18:37:00Z

The reason why it is been removed, because 200 is not in the response status of these 2 APIs. So right now, I am thinking maybe we can return operation status as 200 after polling header, if we wanna resolve this error.

jhendrixMSFT · 2018-12-20T18:44:05Z

@lmazuel I was told you asked to have this validation rule put in place. Can you please explain the details behind it?

zqingqing1 · 2019-01-03T22:01:14Z

@jhendrixMSFT, I added 200 response to resolve the error. Please review :)

jhendrixMSFT · 2019-01-07T17:36:24Z

@zqingqing1 there is a merge conflict, can you please resolve it?

zqingqing1 · 2019-01-08T18:27:23Z

@jhendrixMSFT have time to review again?

jhendrixMSFT · 2019-01-08T18:29:35Z

@AutorestCI regenerate azure-sdk-for-go

jhendrixMSFT · 2019-01-08T18:45:37Z

With these changes the generated code no longer returns a ManagedCluster object when the LRO completes. Take a look at the Go codegen for an example. Is this expected?

zqingqing1 · 2019-01-08T18:47:03Z

Yes, it is expected.

jhendrixMSFT · 2019-01-08T18:49:05Z

So when the polling completes the user needs to make a separate API call then to retrieve the result?

zqingqing1 · 2019-01-08T20:51:11Z

Yes, that is right.

* add operation for 2018-03-31 and 2018-08-01-preview * correct example fileName * add default response and 202, correct typo * remove 200 response * long running operation * return 202 with no body * forget to remove 202 body from 2018-08-01-preview api * add 200 without schema

zqingqing1 added 5 commits December 17, 2018 16:49

add operation for 2018-03-31 and 2018-08-01-preview

45eb326

correct example fileName

705a889

add default response and 202, correct typo

739ebf4

remove 200 response

5879a7f

rebase

abbffc4

kpajdzik added the review label Dec 19, 2018

AutorestCI mentioned this pull request Dec 19, 2018

[AutoPR containerservices/resource-manager] [AKS]: Remove 200/OK response from reset SP/AAD api Azure/azure-sdk-for-js#866

Merged

AutorestCI mentioned this pull request Dec 19, 2018

[AutoPR containerservices/resource-manager] [AKS]: Remove 200/OK response from reset SP/AAD api Azure/azure-sdk-for-python#4099

Merged

AutorestCI mentioned this pull request Dec 19, 2018

[AutoPR containerservices/resource-manager] [AKS]: Remove 200/OK response from reset SP/AAD api Azure/azure-sdk-for-node#4481

Merged

AutorestCI mentioned this pull request Dec 19, 2018

[AutoPR containerservices/resource-manager] [AKS]: Remove 200/OK response from reset SP/AAD api Azure/azure-sdk-for-go#3766

Closed

azuresdkci assigned jhendrixMSFT Dec 19, 2018

azuresdkci requested a review from jhendrixMSFT December 19, 2018 20:03

jhendrixMSFT requested changes Dec 19, 2018

View reviewed changes

.../resource-manager/Microsoft.ContainerService/preview/2018-08-01-preview/managedClusters.json Outdated Show resolved Hide resolved

.../resource-manager/Microsoft.ContainerService/preview/2018-08-01-preview/managedClusters.json Outdated Show resolved Hide resolved

zqingqing1 added 3 commits December 19, 2018 17:00

long running operation

68b822a

return 202 with no body

db34227

forget to remove 202 body from 2018-08-01-preview api

b39369c

add 200 without schema

9436137

resolve conflict

df0936f

AutorestCI mentioned this pull request Jan 7, 2019

[AutoPR containerservices/resource-manager] [AKS]: Remove 200/OK response from reset SP/AAD api Azure/azure-sdk-for-go#3819

Closed

mboersma mentioned this pull request Jan 8, 2019

[AKS] fix schema and example validation warnings #4980

Merged

5 tasks

AutorestCI mentioned this pull request Jan 8, 2019

[AutoPR containerservices/resource-manager] [AKS]: Remove 200/OK response from reset SP/AAD api Azure/azure-sdk-for-go#3829

Merged

jhendrixMSFT added the potential-sdk-breaking-change label Jan 8, 2019

jhendrixMSFT approved these changes Jan 8, 2019

View reviewed changes

jhendrixMSFT merged commit fe884fb into Azure:master Jan 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AKS]: Remove 200/OK response from reset SP/AAD api #4948

[AKS]: Remove 200/OK response from reset SP/AAD api #4948

zqingqing1 commented Dec 19, 2018

openapi-portal-comment bot commented Dec 19, 2018

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

azuresdkci commented Dec 19, 2018

jhendrixMSFT left a comment

azuresdkci commented Dec 19, 2018

jhendrixMSFT commented Dec 20, 2018

zqingqing1 commented Dec 20, 2018

jhendrixMSFT commented Dec 20, 2018

zqingqing1 commented Jan 3, 2019

jhendrixMSFT commented Jan 7, 2019

zqingqing1 commented Jan 8, 2019

jhendrixMSFT commented Jan 8, 2019

jhendrixMSFT commented Jan 8, 2019

zqingqing1 commented Jan 8, 2019

jhendrixMSFT commented Jan 8, 2019

zqingqing1 commented Jan 8, 2019

[AKS]: Remove 200/OK response from reset SP/AAD api #4948

[AKS]: Remove 200/OK response from reset SP/AAD api #4948

Conversation

zqingqing1 commented Dec 19, 2018

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-portal-comment bot commented Dec 19, 2018

AutorestCI commented Dec 19, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Dec 19, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Dec 19, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Dec 19, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Dec 19, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Dec 19, 2018 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Dec 19, 2018

jhendrixMSFT left a comment

Choose a reason for hiding this comment

azuresdkci commented Dec 19, 2018

jhendrixMSFT commented Dec 20, 2018

zqingqing1 commented Dec 20, 2018

jhendrixMSFT commented Dec 20, 2018

zqingqing1 commented Jan 3, 2019

jhendrixMSFT commented Jan 7, 2019

zqingqing1 commented Jan 8, 2019

jhendrixMSFT commented Jan 8, 2019

jhendrixMSFT commented Jan 8, 2019

zqingqing1 commented Jan 8, 2019

jhendrixMSFT commented Jan 8, 2019

zqingqing1 commented Jan 8, 2019

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading