Adding support for interface endpoints #3783

rupalivohra · 2018-08-31T02:20:21Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkci · 2018-08-31T02:26:01Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-31T02:32:30Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3249

AutorestCI · 2018-08-31T07:08:17Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-08-31T11:00:57Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpn3_usu41/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpn3_usu41/sdk', '--nodejs', '[email protected]/autorest.nodejs@^2.1.43']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.79)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down
FATAL: nodejs/imodeler1 - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.modeler' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.modeler' terminated.

AutorestCI · 2018-08-31T11:05:36Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2018-08-31T12:39:50Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

dsgouda

Looks good for the most part. left a few comments

dsgouda · 2018-08-31T15:56:47Z

...fication/network/resource-manager/Microsoft.Network/stable/2018-08-01/interfaceEndpoint.json

+        "tags": [
+          "InterfaceEndpoints"
+        ],
+        "operationId": "InterfaceEndpoints_ListAll",


A better name is ListBySubscription assuming that is the intent here

updated to ListInterfaceEndpointsInSubscription

Apologize for the confusion, please rename it to InterfaceEndpoints_ListBySubscription

ListAll is what most of the other Network teams use for this operation. Why deviate?

...fication/network/resource-manager/Microsoft.Network/stable/2018-08-01/interfaceEndpoint.json

specification/network/resource-manager/readme.md

dsgouda · 2018-08-31T16:36:09Z

Per offline chat, REST endpoints have undergone ARM review

dsgouda

LGTM will merge on CIs passing

tjprescott · 2018-08-31T17:15:41Z

...fication/network/resource-manager/Microsoft.Network/stable/2018-08-01/interfaceEndpoint.json

+        "tags": [
+          "InterfaceEndpoints"
+        ],
+        "operationId": "ListInterfaceEndpointsInSubscription",


The more idiomatic thing to do in other Network swaggers is to call this operation "ListAll". Also, not sure what is causing it here in the swagger, but in the generated Python SDK, it is appearing at the root of the network management client instead of under interface_endpoints_operations. @lmazuel ideas?

I got feedback to change it from _ListAll to something more descriptive w/the subscription.

Do other subscription-based location operations not appear in the base? I’m guessing it’s because the path is not Microsoft.Network/interfaceEndpoints/...

There are ARM recommended guidelines for naming List operations, i.e., they can be named as one of these
Resources_List/Resources_ListBySubscription, Resources_ListByResourceGroup and Resources_ListByParentResource we probably need to revisit the existing operation names if Network is going with the Resources_ListAll operationIds
In this particular case, as I suggested earlier, the operationId must be renamed to InterfaceEndpoints_ListBySubscription

@ravbhatnagar FYI

kk, i'll rename it to that. I didn't realize there were guidelines on this :)

No other subscription-based list commands do not appear in the base. They appear in the operation group they pertain to.

Exactly, and the name before _ in operation id becomes the operation group, which would be as expected per the latest change @rupalivohra made

rupalivohra · 2018-08-31T18:09:11Z

@dsgouda looks like all checks passed, can it be merged?

* Brooklyn Ignite Swagger changes * Add missing example file changes * Add virtual hub route table * Fix travis build error * VPN profile bugfix * Fix casing for NRP automapping * Fix parsing errors * remove BgpSettings from P2SVpnGateway object * Added AddressPrefixes on Subnet properties (#3714) * Added address prefixes to subnet * Added example of multiple address prefixes. * Python Network conf 2018-08-01 * Changes to include required properties for outbound rule (#3728) * Mark outbound rule properties as required * Update outbound rule with required properties * Removing old change * Fix Python 2018-08 conf * Fix swagger contract errors with NRP * Fix network swagger * Fix virtualHub Properties for SDK and PS JSON serializer compliance * Fix bugs * Changing Cortex swagger to match NRP * Bug fixes * bugFix3 * Bug fix * Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic (#3743) * Do not confuse users with both InternalPublicIp and PublicIp for the same thing * Update AzureFirewall PUT example * This closes #3474 * Use the correct name for publicIPAddress in AzureFirewall PUT example * Azure Firewall FQDN Tag top level resource (#3744) * Azure Firewall FQDN Tag top level resource * Name FqdnTags property in AzureFirewallApplicationRule properly * Empty commit to trigger new validation * Vtapfinal (#3684) * Swagger Coverage/Completeness- for operation CheckNameAvailability (#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * vtap update * VTAP changes * VTAP changes * Adding examples for VTAP resource * Update changes for Examples * Further fixes to examples * Add exception for vtap's RequiredPropertiesMissingInResourceModel in readme * Azure Firewall NAT Rule Collection (#3745) * NAT Rule Collections for Azure Firewall * Update examples to include the new NAT Rule Collection * Shorten the NAT RC Properties name and mark etag read-only * Add NAT Rule Collection to Azure Firewall properties * Fix all <<a Azure>> in helper messages * Do not allow ICMP as Network protocol (#3742) * Adding linkedResourceType and hostedWorkloads to nic (#3780) * Adding support for interface endpoints (#3783) * Creating Interface Endpoint definition * Adding references to interface endpoints in existing resources * Added Trusted root certificate changes to new API version (#3731) * Add ExpressRoute gateway resource (#3776) * Initial version * Refactor connections. * Update API version * Add enum values. * Addressed all comments. * Adding support for delegations on a subnet (#3805) * Adding subnet delegation property on VNET * Updating subnet/vnet create & get examples to reflect delegation * Adding support for GetAvailableDelegations operation * Fixing properties in Swagger & updating examples to reflect fixes * Add availableDelegation as a subResource * Remove type from examples * Further updates to delegation PR * Additional changes to structure * Correct issues for SDK generation (#3818) * Remove x-ms-client-flatten attribute as that results in wrong descriptiosn during generation of the SDKs. * Missing descriptions. * Rename TargetUrls to TargetFqdns (#3739) * Fix travis errors in examples * Fixed error examples for P2S cortex resources * Fix swagger * Fix Semantic validation error * network swagger fix * Fix travis * Fix travis errors * Revert version change * Dummy changes for CI restart

* Trusted Root certificate (#3668) * Rebased master to monthly network branch (#3687) * Swagger Coverage/Completeness- for operation CheckNameAvailability (#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Update dns management Node.js version number to 3.0.0 (#3675) * Update batchai Node.js package version to 2.0.2 (#3664) * Update nofiticationhubs management Node.js package version to 2.0.0 (#3665) * WebApps - Add BackupName to backup API models (#3560) * WebApps - Add BackupName to replace non-ARM-compliant Name property on Backup API models * Revert breaking change to BackupItem. BackupItemName property will be fine in place of BackupName for now. * Update authorization management Node.js package version to 5.0.1 (#3676) * Update storagesync management Node.js package version to 1.0.0 (#3677) * add checknameavailability (#3608) * add checknameavailability * move checkname parameter to definition section * fix brackets * fix parameter name in checknameavailability exanple * update code owners for PowerBIDedicated * New Batch data plane API version 2018-08-01.7.0 (#3657) * Add new batch version 2018-08-01.7.0 * Update the new API * Fix up output from OAD, it does not output valid JSON * update OAV (#3678) * Update storage management Node.js package version to 5.2.0 (#3679) * Update compute.json and disk.json for some issues and add zone and rolling upgrade. (#3642) * Breaking change tool correctly handles multiple files with same name * Fix to breaking changes table generation * Trusted Root certificate (#3668) * Updated Microsoft.Network version to 2018-08-01 (#3672) * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * Added AddressPrefixes on Subnet properties (#3714) * Added address prefixes to subnet * Added example of multiple address prefixes. * Python Network conf 2018-08-01 * Changes to include required properties for outbound rule (#3728) * Mark outbound rule properties as required * Update outbound rule with required properties * Removing old change * Fix Python 2018-08 conf * Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic (#3743) * Do not confuse users with both InternalPublicIp and PublicIp for the same thing * Update AzureFirewall PUT example * This closes #3474 * Use the correct name for publicIPAddress in AzureFirewall PUT example * Azure Firewall FQDN Tag top level resource (#3744) * Azure Firewall FQDN Tag top level resource * Name FqdnTags property in AzureFirewallApplicationRule properly * Empty commit to trigger new validation * Vtapfinal (#3684) * Swagger Coverage/Completeness- for operation CheckNameAvailability (#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * vtap update * VTAP changes * VTAP changes * Adding examples for VTAP resource * Update changes for Examples * Further fixes to examples * Add exception for vtap's RequiredPropertiesMissingInResourceModel in readme * Azure Firewall NAT Rule Collection (#3745) * NAT Rule Collections for Azure Firewall * Update examples to include the new NAT Rule Collection * Shorten the NAT RC Properties name and mark etag read-only * Add NAT Rule Collection to Azure Firewall properties * Fix all <<a Azure>> in helper messages * Do not allow ICMP as Network protocol (#3742) * Adding linkedResourceType and hostedWorkloads to nic (#3780) * Adding support for interface endpoints (#3783) * Creating Interface Endpoint definition * Adding references to interface endpoints in existing resources * Added Trusted root certificate changes to new API version (#3731) * Add ExpressRoute gateway resource (#3776) * Initial version * Refactor connections. * Update API version * Add enum values. * Addressed all comments. * Adding support for delegations on a subnet (#3805) * Adding subnet delegation property on VNET * Updating subnet/vnet create & get examples to reflect delegation * Adding support for GetAvailableDelegations operation * Fixing properties in Swagger & updating examples to reflect fixes * Add availableDelegation as a subResource * Remove type from examples * Further updates to delegation PR * Additional changes to structure * Correct issues for SDK generation (#3818) * Remove x-ms-client-flatten attribute as that results in wrong descriptiosn during generation of the SDKs. * Missing descriptions. * Rename TargetUrls to TargetFqdns (#3739) * Add Network Profile swagger and examples (#3806) * add network profile swagger and examples * add x-ms-client-flatten property as per feedback * appease travis by fixing model + examples * vtapswaggerupdate (#3837) * Add Service Association Link and IP Configuration Profiles on Subnet (#3840) * add service association links for virtual network * add ipconfig profiles on subnet * fixed example issue * Review for tabfix and properties fromat rename * Vtap swagger update and made the property as readonly (#3845) * vtapswaggerupdate * Adding readonly property * Updated AppGW Autoscale Configuration (#3838) * VPN gateway new API for Reset VPN client PSK (#3800) * Brooklyn Ignite Swagger changes (#3715) * Brooklyn Ignite Swagger changes * Add missing example file changes * Add virtual hub route table * Fix travis build error * VPN profile bugfix * Fix casing for NRP automapping * Fix parsing errors * remove BgpSettings from P2SVpnGateway object * Added AddressPrefixes on Subnet properties (#3714) * Added address prefixes to subnet * Added example of multiple address prefixes. * Python Network conf 2018-08-01 * Changes to include required properties for outbound rule (#3728) * Mark outbound rule properties as required * Update outbound rule with required properties * Removing old change * Fix Python 2018-08 conf * Fix swagger contract errors with NRP * Fix network swagger * Fix virtualHub Properties for SDK and PS JSON serializer compliance * Fix bugs * Changing Cortex swagger to match NRP * Bug fixes * bugFix3 * Bug fix * Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic (#3743) * Do not confuse users with both InternalPublicIp and PublicIp for the same thing * Update AzureFirewall PUT example * This closes #3474 * Use the correct name for publicIPAddress in AzureFirewall PUT example * Azure Firewall FQDN Tag top level resource (#3744) * Azure Firewall FQDN Tag top level resource * Name FqdnTags property in AzureFirewallApplicationRule properly * Empty commit to trigger new validation * Vtapfinal (#3684) * Swagger Coverage/Completeness- for operation CheckNameAvailability (#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * vtap update * VTAP changes * VTAP changes * Adding examples for VTAP resource * Update changes for Examples * Further fixes to examples * Add exception for vtap's RequiredPropertiesMissingInResourceModel in readme * Azure Firewall NAT Rule Collection (#3745) * NAT Rule Collections for Azure Firewall * Update examples to include the new NAT Rule Collection * Shorten the NAT RC Properties name and mark etag read-only * Add NAT Rule Collection to Azure Firewall properties * Fix all <<a Azure>> in helper messages * Do not allow ICMP as Network protocol (#3742) * Adding linkedResourceType and hostedWorkloads to nic (#3780) * Adding support for interface endpoints (#3783) * Creating Interface Endpoint definition * Adding references to interface endpoints in existing resources * Added Trusted root certificate changes to new API version (#3731) * Add ExpressRoute gateway resource (#3776) * Initial version * Refactor connections. * Update API version * Add enum values. * Addressed all comments. * Adding support for delegations on a subnet (#3805) * Adding subnet delegation property on VNET * Updating subnet/vnet create & get examples to reflect delegation * Adding support for GetAvailableDelegations operation * Fixing properties in Swagger & updating examples to reflect fixes * Add availableDelegation as a subResource * Remove type from examples * Further updates to delegation PR * Additional changes to structure * Correct issues for SDK generation (#3818) * Remove x-ms-client-flatten attribute as that results in wrong descriptiosn during generation of the SDKs. * Missing descriptions. * Rename TargetUrls to TargetFqdns (#3739) * Fix travis errors in examples * Fixed error examples for P2S cortex resources * Fix swagger * Fix Semantic validation error * network swagger fix * Fix travis * Fix travis errors * Revert version change * Dummy changes for CI restart * Swagger changes (#3857) * Relocated readOnly property * Readded provisioning state to interfaceEndpoint.json * Updated networkInterface.json * Updated serviceEndpointPolicy.json * Update virtualNetworkTap.json * Fix semantic issue * Multiple changes * More example fixes * Dummy commit * Fixed duplicate * changes to swagger in interface endpoints and subnet delegation (#3860) * Revert "Trusted Root certificate (#3668)" This reverts commit 3ff4b52. * fixed api version in azure firewall example * Review comments incorporation (#3859)

rupalivohra requested a review from MikhailTryakhov as a code owner August 31, 2018 02:20

azuresdkci assigned dsgouda Aug 31, 2018

azuresdkci requested a review from dsgouda August 31, 2018 02:31

AutorestCI mentioned this pull request Aug 31, 2018

[AutoPR network/resource-manager] Adding support for interface endpoints Azure/azure-sdk-for-python#3249

Closed

rupalivohra force-pushed the ie branch 2 times, most recently from 7bcd0b2 to da91b31 Compare August 31, 2018 03:18

AutorestCI mentioned this pull request Aug 31, 2018

[AutoPR network/resource-manager] Adding support for interface endpoints Azure/azure-sdk-for-node#3477

Closed

dsgouda suggested changes Aug 31, 2018

View reviewed changes

dsgouda added Changes Required WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 31, 2018

rupalivohra force-pushed the ie branch from da91b31 to 396ced1 Compare August 31, 2018 16:42

dsgouda approved these changes Aug 31, 2018

View reviewed changes

tjprescott requested changes Aug 31, 2018

View reviewed changes

Rupali Vohra added 2 commits August 31, 2018 10:34

Creating Interface Endpoint definition

e0ec74e

Adding references to interface endpoints in existing resources

ee67a16

rupalivohra force-pushed the ie branch from 396ced1 to ee67a16 Compare August 31, 2018 17:34

dsgouda removed the Changes Required label Aug 31, 2018

dsgouda merged commit da8dc7c into Azure:Network-September-Release Aug 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding support for interface endpoints #3783

Adding support for interface endpoints #3783

rupalivohra commented Aug 31, 2018

azuresdkci commented Aug 31, 2018

AutorestCI commented Aug 31, 2018 •

edited

Loading

AutorestCI commented Aug 31, 2018 •

edited

Loading

AutorestCI commented Aug 31, 2018 •

edited

Loading

AutorestCI commented Aug 31, 2018 •

edited

Loading

AutorestCI commented Aug 31, 2018 •

edited

Loading

dsgouda left a comment •

edited

Loading

dsgouda Aug 31, 2018

rupalivohra Aug 31, 2018

dsgouda Aug 31, 2018

tjprescott Aug 31, 2018

dsgouda commented Aug 31, 2018

dsgouda left a comment

tjprescott Aug 31, 2018

rupalivohra Aug 31, 2018

rupalivohra Aug 31, 2018

dsgouda Aug 31, 2018 •

edited

Loading

dsgouda Aug 31, 2018

rupalivohra Aug 31, 2018

tjprescott Aug 31, 2018

dsgouda Aug 31, 2018

rupalivohra commented Aug 31, 2018

Adding support for interface endpoints #3783

Adding support for interface endpoints #3783

Conversation

rupalivohra commented Aug 31, 2018

PR information

Quality of Swagger

azuresdkci commented Aug 31, 2018

AutorestCI commented Aug 31, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 31, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Aug 31, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Aug 31, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Aug 31, 2018 • edited Loading

Automation for azure-sdk-for-java

dsgouda left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsgouda commented Aug 31, 2018

dsgouda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsgouda Aug 31, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rupalivohra commented Aug 31, 2018

AutorestCI commented Aug 31, 2018 •

edited

Loading

AutorestCI commented Aug 31, 2018 •

edited

Loading

AutorestCI commented Aug 31, 2018 •

edited

Loading

AutorestCI commented Aug 31, 2018 •

edited

Loading

AutorestCI commented Aug 31, 2018 •

edited

Loading

dsgouda left a comment •

edited

Loading

dsgouda Aug 31, 2018 •

edited

Loading