Vtapfinal #3684

karthikananth · 2018-08-21T01:26:12Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…zure#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name

…01 to version 2018-08-01

azuresdkci · 2018-08-21T01:30:09Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-21T01:32:26Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-08-21T01:36:33Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3216

AutorestCI · 2018-08-21T01:48:27Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3384

AutorestCI · 2018-08-21T01:53:27Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-08-21T01:54:05Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

jianghaolu · 2018-08-21T17:56:33Z

...fication/network/resource-manager/Microsoft.Network/stable/2018-08-01/virtualNetworkTap.json

+                    "description": "The name of the virtual network tap."
+                },
+                {
+                    "$ref": "./network.json/parameters/ApiVersionParameter"


Should be "$ref": "./network.json#/parameters/ApiVersionParameter"

jianghaolu · 2018-08-21T17:56:39Z

...fication/network/resource-manager/Microsoft.Network/stable/2018-08-01/virtualNetworkTap.json

+                    "$ref": "./network.json/parameters/ApiVersionParameter"
+                },
+                {
+                    "$ref": "./network.json/parameters/SubscriptionIdParameter"


anuchandy · 2018-08-22T16:19:38Z

@karthikananth please add examples for VTAP resource operations (see linter errors reported by CI)

jianghaolu · 2018-08-22T22:05:39Z

...fication/network/resource-manager/Microsoft.Network/stable/2018-08-01/virtualNetworkTap.json

+            "description": "Specifies the list of resource IDs for the network interface IP configuration that needs to be tapped."
+          },
+          "destinationNetworkInterfaceIPConfiguration": {
+            "$ref": "./networkInterface.json#/definitions/IPConfiguration",


@anuchandy this is the ip configuration PUT on vtap requires

jianghaolu · 2018-08-22T22:24:18Z

...ification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkInterface.json

+      },
+      "description": "Properties of IP configuration."
+    },
+    "IPConfiguration": {


@karthikananth This is the class VTAP's PUT request is asking for, while https://github.com/Azure/azure-rest-api-specs/pull/3684/files#diff-25f6237806e997a997c05be2ab43e267R855 is the class network interface's list ipconfiguration method returns - so our generator isn't trying to do anything wacky here. Instead we are just reflecting the actual types.

Can you remove this class and simply use NetworkInterfaceIPConfiguration? Some fields will be null but that should be okay?

sergey-shandar · 2018-08-27T21:01:15Z

@karthikananth please, resolve conflicts.

lmazuel · 2018-08-28T20:17:23Z

@AutorestCI rebuild azure-sdk-for-python

sergey-shandar · 2018-08-29T18:47:53Z

...ger/Microsoft.Network/stable/2018-08-01/examples/NetworkInterfaceTapConfigurationCreate.json

+        },
+        "location": "centraluseuap" 
+    },
+    "responses" : {


These are not valid examples. "responses" should be outside of parameters.

…readme

* Brooklyn Ignite Swagger changes * Add missing example file changes * Add virtual hub route table * Fix travis build error * VPN profile bugfix * Fix casing for NRP automapping * Fix parsing errors * remove BgpSettings from P2SVpnGateway object * Added AddressPrefixes on Subnet properties (#3714) * Added address prefixes to subnet * Added example of multiple address prefixes. * Python Network conf 2018-08-01 * Changes to include required properties for outbound rule (#3728) * Mark outbound rule properties as required * Update outbound rule with required properties * Removing old change * Fix Python 2018-08 conf * Fix swagger contract errors with NRP * Fix network swagger * Fix virtualHub Properties for SDK and PS JSON serializer compliance * Fix bugs * Changing Cortex swagger to match NRP * Bug fixes * bugFix3 * Bug fix * Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic (#3743) * Do not confuse users with both InternalPublicIp and PublicIp for the same thing * Update AzureFirewall PUT example * This closes #3474 * Use the correct name for publicIPAddress in AzureFirewall PUT example * Azure Firewall FQDN Tag top level resource (#3744) * Azure Firewall FQDN Tag top level resource * Name FqdnTags property in AzureFirewallApplicationRule properly * Empty commit to trigger new validation * Vtapfinal (#3684) * Swagger Coverage/Completeness- for operation CheckNameAvailability (#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * vtap update * VTAP changes * VTAP changes * Adding examples for VTAP resource * Update changes for Examples * Further fixes to examples * Add exception for vtap's RequiredPropertiesMissingInResourceModel in readme * Azure Firewall NAT Rule Collection (#3745) * NAT Rule Collections for Azure Firewall * Update examples to include the new NAT Rule Collection * Shorten the NAT RC Properties name and mark etag read-only * Add NAT Rule Collection to Azure Firewall properties * Fix all <<a Azure>> in helper messages * Do not allow ICMP as Network protocol (#3742) * Adding linkedResourceType and hostedWorkloads to nic (#3780) * Adding support for interface endpoints (#3783) * Creating Interface Endpoint definition * Adding references to interface endpoints in existing resources * Added Trusted root certificate changes to new API version (#3731) * Add ExpressRoute gateway resource (#3776) * Initial version * Refactor connections. * Update API version * Add enum values. * Addressed all comments. * Adding support for delegations on a subnet (#3805) * Adding subnet delegation property on VNET * Updating subnet/vnet create & get examples to reflect delegation * Adding support for GetAvailableDelegations operation * Fixing properties in Swagger & updating examples to reflect fixes * Add availableDelegation as a subResource * Remove type from examples * Further updates to delegation PR * Additional changes to structure * Correct issues for SDK generation (#3818) * Remove x-ms-client-flatten attribute as that results in wrong descriptiosn during generation of the SDKs. * Missing descriptions. * Rename TargetUrls to TargetFqdns (#3739) * Fix travis errors in examples * Fixed error examples for P2S cortex resources * Fix swagger * Fix Semantic validation error * network swagger fix * Fix travis * Fix travis errors * Revert version change * Dummy changes for CI restart

* Trusted Root certificate (#3668) * Rebased master to monthly network branch (#3687) * Swagger Coverage/Completeness- for operation CheckNameAvailability (#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Update dns management Node.js version number to 3.0.0 (#3675) * Update batchai Node.js package version to 2.0.2 (#3664) * Update nofiticationhubs management Node.js package version to 2.0.0 (#3665) * WebApps - Add BackupName to backup API models (#3560) * WebApps - Add BackupName to replace non-ARM-compliant Name property on Backup API models * Revert breaking change to BackupItem. BackupItemName property will be fine in place of BackupName for now. * Update authorization management Node.js package version to 5.0.1 (#3676) * Update storagesync management Node.js package version to 1.0.0 (#3677) * add checknameavailability (#3608) * add checknameavailability * move checkname parameter to definition section * fix brackets * fix parameter name in checknameavailability exanple * update code owners for PowerBIDedicated * New Batch data plane API version 2018-08-01.7.0 (#3657) * Add new batch version 2018-08-01.7.0 * Update the new API * Fix up output from OAD, it does not output valid JSON * update OAV (#3678) * Update storage management Node.js package version to 5.2.0 (#3679) * Update compute.json and disk.json for some issues and add zone and rolling upgrade. (#3642) * Breaking change tool correctly handles multiple files with same name * Fix to breaking changes table generation * Trusted Root certificate (#3668) * Updated Microsoft.Network version to 2018-08-01 (#3672) * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * Added AddressPrefixes on Subnet properties (#3714) * Added address prefixes to subnet * Added example of multiple address prefixes. * Python Network conf 2018-08-01 * Changes to include required properties for outbound rule (#3728) * Mark outbound rule properties as required * Update outbound rule with required properties * Removing old change * Fix Python 2018-08 conf * Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic (#3743) * Do not confuse users with both InternalPublicIp and PublicIp for the same thing * Update AzureFirewall PUT example * This closes #3474 * Use the correct name for publicIPAddress in AzureFirewall PUT example * Azure Firewall FQDN Tag top level resource (#3744) * Azure Firewall FQDN Tag top level resource * Name FqdnTags property in AzureFirewallApplicationRule properly * Empty commit to trigger new validation * Vtapfinal (#3684) * Swagger Coverage/Completeness- for operation CheckNameAvailability (#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * vtap update * VTAP changes * VTAP changes * Adding examples for VTAP resource * Update changes for Examples * Further fixes to examples * Add exception for vtap's RequiredPropertiesMissingInResourceModel in readme * Azure Firewall NAT Rule Collection (#3745) * NAT Rule Collections for Azure Firewall * Update examples to include the new NAT Rule Collection * Shorten the NAT RC Properties name and mark etag read-only * Add NAT Rule Collection to Azure Firewall properties * Fix all <<a Azure>> in helper messages * Do not allow ICMP as Network protocol (#3742) * Adding linkedResourceType and hostedWorkloads to nic (#3780) * Adding support for interface endpoints (#3783) * Creating Interface Endpoint definition * Adding references to interface endpoints in existing resources * Added Trusted root certificate changes to new API version (#3731) * Add ExpressRoute gateway resource (#3776) * Initial version * Refactor connections. * Update API version * Add enum values. * Addressed all comments. * Adding support for delegations on a subnet (#3805) * Adding subnet delegation property on VNET * Updating subnet/vnet create & get examples to reflect delegation * Adding support for GetAvailableDelegations operation * Fixing properties in Swagger & updating examples to reflect fixes * Add availableDelegation as a subResource * Remove type from examples * Further updates to delegation PR * Additional changes to structure * Correct issues for SDK generation (#3818) * Remove x-ms-client-flatten attribute as that results in wrong descriptiosn during generation of the SDKs. * Missing descriptions. * Rename TargetUrls to TargetFqdns (#3739) * Add Network Profile swagger and examples (#3806) * add network profile swagger and examples * add x-ms-client-flatten property as per feedback * appease travis by fixing model + examples * vtapswaggerupdate (#3837) * Add Service Association Link and IP Configuration Profiles on Subnet (#3840) * add service association links for virtual network * add ipconfig profiles on subnet * fixed example issue * Review for tabfix and properties fromat rename * Vtap swagger update and made the property as readonly (#3845) * vtapswaggerupdate * Adding readonly property * Updated AppGW Autoscale Configuration (#3838) * VPN gateway new API for Reset VPN client PSK (#3800) * Brooklyn Ignite Swagger changes (#3715) * Brooklyn Ignite Swagger changes * Add missing example file changes * Add virtual hub route table * Fix travis build error * VPN profile bugfix * Fix casing for NRP automapping * Fix parsing errors * remove BgpSettings from P2SVpnGateway object * Added AddressPrefixes on Subnet properties (#3714) * Added address prefixes to subnet * Added example of multiple address prefixes. * Python Network conf 2018-08-01 * Changes to include required properties for outbound rule (#3728) * Mark outbound rule properties as required * Update outbound rule with required properties * Removing old change * Fix Python 2018-08 conf * Fix swagger contract errors with NRP * Fix network swagger * Fix virtualHub Properties for SDK and PS JSON serializer compliance * Fix bugs * Changing Cortex swagger to match NRP * Bug fixes * bugFix3 * Bug fix * Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic (#3743) * Do not confuse users with both InternalPublicIp and PublicIp for the same thing * Update AzureFirewall PUT example * This closes #3474 * Use the correct name for publicIPAddress in AzureFirewall PUT example * Azure Firewall FQDN Tag top level resource (#3744) * Azure Firewall FQDN Tag top level resource * Name FqdnTags property in AzureFirewallApplicationRule properly * Empty commit to trigger new validation * Vtapfinal (#3684) * Swagger Coverage/Completeness- for operation CheckNameAvailability (#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * vtap update * VTAP changes * VTAP changes * Adding examples for VTAP resource * Update changes for Examples * Further fixes to examples * Add exception for vtap's RequiredPropertiesMissingInResourceModel in readme * Azure Firewall NAT Rule Collection (#3745) * NAT Rule Collections for Azure Firewall * Update examples to include the new NAT Rule Collection * Shorten the NAT RC Properties name and mark etag read-only * Add NAT Rule Collection to Azure Firewall properties * Fix all <<a Azure>> in helper messages * Do not allow ICMP as Network protocol (#3742) * Adding linkedResourceType and hostedWorkloads to nic (#3780) * Adding support for interface endpoints (#3783) * Creating Interface Endpoint definition * Adding references to interface endpoints in existing resources * Added Trusted root certificate changes to new API version (#3731) * Add ExpressRoute gateway resource (#3776) * Initial version * Refactor connections. * Update API version * Add enum values. * Addressed all comments. * Adding support for delegations on a subnet (#3805) * Adding subnet delegation property on VNET * Updating subnet/vnet create & get examples to reflect delegation * Adding support for GetAvailableDelegations operation * Fixing properties in Swagger & updating examples to reflect fixes * Add availableDelegation as a subResource * Remove type from examples * Further updates to delegation PR * Additional changes to structure * Correct issues for SDK generation (#3818) * Remove x-ms-client-flatten attribute as that results in wrong descriptiosn during generation of the SDKs. * Missing descriptions. * Rename TargetUrls to TargetFqdns (#3739) * Fix travis errors in examples * Fixed error examples for P2S cortex resources * Fix swagger * Fix Semantic validation error * network swagger fix * Fix travis * Fix travis errors * Revert version change * Dummy changes for CI restart * Swagger changes (#3857) * Relocated readOnly property * Readded provisioning state to interfaceEndpoint.json * Updated networkInterface.json * Updated serviceEndpointPolicy.json * Update virtualNetworkTap.json * Fix semantic issue * Multiple changes * More example fixes * Dummy commit * Fixed duplicate * changes to swagger in interface endpoints and subnet delegation (#3860) * Revert "Trusted Root certificate (#3668)" This reverts commit 3ff4b52. * fixed api version in azure firewall example * Review comments incorporation (#3859)

vivekkothakota and others added 4 commits August 17, 2018 09:55

Swagger Coverage/Completeness- for operation CheckNameAvailability (A…

5ba2af3

…zure#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name

Adds base for updating Microsoft.Network from version stable/2018-07-…

a913be0

…01 to version 2018-08-01

Updates readme

41f35a8

Updates API version in new specs and examples

4756434

karthikananth requested a review from MikhailTryakhov as a code owner August 21, 2018 01:26

azuresdkci assigned anuchandy Aug 21, 2018

azuresdkci requested a review from anuchandy August 21, 2018 01:27

AutorestCI mentioned this pull request Aug 21, 2018

[AutoPR migrate/resource-manager/network/resource-manager] Vtapfinal Azure/azure-sdk-for-node#3384

Closed

AutorestCI mentioned this pull request Aug 21, 2018

[AutoPR migrate/resource-manager/network/resource-manager] Vtapfinal Azure/azure-sdk-for-go#2497

Merged

vtap update

5d12417

jianghaolu reviewed Aug 21, 2018

View reviewed changes

VTAP changes

161a2a6

anuchandy requested review from sergey-shandar and removed request for anuchandy August 22, 2018 18:38

jianghaolu reviewed Aug 22, 2018

View reviewed changes

anuchandy assigned sergey-shandar Aug 22, 2018

jianghaolu reviewed Aug 22, 2018

View reviewed changes

VTAP changes

3da9ee7

jianghaolu mentioned this pull request Aug 23, 2018

VTAP changes #3682

Closed

10 tasks

merge changes for vtap resource

c5b3e4e

lmazuel mentioned this pull request Aug 28, 2018

VTAP from c5b3e4ea206a68363d349f476e86c5b943983b84 Azure/azure-sdk-for-python#3216

Merged

Adding examples for VTAP resource

cea67db

sergey-shandar suggested changes Aug 29, 2018

View reviewed changes

chandrasekarsrinivasan added 3 commits August 30, 2018 12:12

Update changes for Examples

fb03b72

Further fixes to examples

0c9b72c

Add exception for vtap's RequiredPropertiesMissingInResourceModel in …

ebbcd71

…readme

anuchandy approved these changes Aug 30, 2018

View reviewed changes

sergey-shandar approved these changes Aug 30, 2018

View reviewed changes

sergey-shandar merged commit 59a73c0 into Azure:Network-September-Release Aug 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vtapfinal #3684

Vtapfinal #3684

karthikananth commented Aug 21, 2018

azuresdkci commented Aug 21, 2018

AutorestCI commented Aug 21, 2018 •

edited

Loading

AutorestCI commented Aug 21, 2018 •

edited

Loading

AutorestCI commented Aug 21, 2018 •

edited

Loading

AutorestCI commented Aug 21, 2018 •

edited

Loading

AutorestCI commented Aug 21, 2018 •

edited

Loading

jianghaolu Aug 21, 2018

karthikananth Aug 21, 2018

jianghaolu Aug 21, 2018

karthikananth Aug 21, 2018

anuchandy commented Aug 22, 2018

jianghaolu Aug 22, 2018

jianghaolu Aug 22, 2018

karthikananth Aug 23, 2018

sergey-shandar commented Aug 27, 2018

lmazuel commented Aug 28, 2018

sergey-shandar Aug 29, 2018

Vtapfinal #3684

Vtapfinal #3684

Conversation

karthikananth commented Aug 21, 2018

PR information

Quality of Swagger

azuresdkci commented Aug 21, 2018

AutorestCI commented Aug 21, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Aug 21, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 21, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Aug 21, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Aug 21, 2018 • edited Loading

Automation for azure-sdk-for-go

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anuchandy commented Aug 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergey-shandar commented Aug 27, 2018

lmazuel commented Aug 28, 2018

Choose a reason for hiding this comment

AutorestCI commented Aug 21, 2018 •

edited

Loading

AutorestCI commented Aug 21, 2018 •

edited

Loading

AutorestCI commented Aug 21, 2018 •

edited

Loading

AutorestCI commented Aug 21, 2018 •

edited

Loading

AutorestCI commented Aug 21, 2018 •

edited

Loading