Added the replica count API change to Shared Image Gallery swagger file. #3757
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1053,12 +1053,12 @@ | |
| }, | ||
| "GalleryArtifactPublishingProfileBase": { | ||
| "properties": { | ||
| "targetRegions": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/TargetRegion" | ||
| }, | ||
| "description": "The target regions where the artifact is going to be published." | ||
| }, | ||
| "source": { | ||
| "$ref": "#/definitions/GalleryArtifactSource" | ||
|
|
@@ -1069,6 +1069,20 @@ | |
| ], | ||
| "description": "Describes the basic gallery artifact publishing profile." | ||
| }, | ||
| "TargetRegion": { | ||
| "properties": { | ||
| "name": { | ||
| "type": "string", | ||
| "description": "The name of the region." | ||
| }, | ||
| "regionalReplicaCount": { | ||
| "type": "integer", | ||
| "format": "int32", | ||
| "description": "This is the number of source blob copies in this specific region." | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment. So it is the copies of the source blob in the target regions. Will this be better "This is the number of copies of the source blobs in this target region."? There was a problem hiding this comment. @vanbasten2323 what exactly is the "number of copies of the source blobs mean"? There was a problem hiding this comment. @singhkays, the original mail communicates the new name would be There was a problem hiding this comment. Also, what is the service end default value for this? |
||
| } | ||
| }, | ||
| "description": "Describes the target region information." | ||
| }, | ||
| "GalleryArtifactSource": { | ||
| "properties": { | ||
| "managedImage": { | ||
|
|
@@ -1094,17 +1108,10 @@ | |
| }, | ||
| "GalleryImageVersionPublishingProfile": { | ||
| "properties": { | ||
| "replicaCount": { | ||
| "type": "integer", | ||
| "format": "int32", | ||
| "description": "This is the number of source blob copies in a region." | ||
| }, | ||
| "excludeFromLatest": { | ||
| "type": "boolean", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the name of the region is called
name, why the replica count still has theregionas the property's prefix? Why not justreplicaCount?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Initially, we call it "replicaCount", the same as you suggested. Then we got some feedback from Kay Singh that it might be clearer to use "regionalReplicaCount". So we use this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK