Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the replica count API change to Shared Image Gallery swagger file. #3757

Merged

Conversation

vanbasten2323
Copy link
Contributor

@vanbasten2323 vanbasten2323 commented Aug 29, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2982

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#3481

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2607

"type": "string",
"description": "The name of the region."
},
"regionalReplicaCount": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the name of the region is called name, why the replica count still has the region as the property's prefix? Why not just replicaCount?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Initially, we call it "replicaCount", the same as you suggested. Then we got some feedback from Kay Singh that it might be clearer to use "regionalReplicaCount". So we use this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

"regionalReplicaCount": {
"type": "integer",
"format": "int32",
"description": "This is the number of source blob copies in this specific region."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source blob in the source region, or in the target region? Or target blob? Please consider revising the statement to make it clearer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is the copies of the source blob in the target regions. Will this be better "This is the number of copies of the source blobs in this target region."?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanbasten2323 what exactly is the "number of copies of the source blobs mean"?

Copy link
Contributor

@yugangw-msft yugangw-msft Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singhkays, the original mail communicates the new name would be scaleTier, so i am bit confused now. Can you guys offer some explanation, so i can communicate better to CLI users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what is the service end default value for this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified in offline call

@huangpf
Copy link
Contributor

huangpf commented Aug 29, 2018

LGTM, with some minor comments.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants