Service Endpoint Policies Swagger #3558

chandrasekarsrinivasan · 2018-07-31T19:47:21Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkci · 2018-07-31T19:47:22Z

Can one of the admins verify this patch?

AutorestCI · 2018-07-31T19:49:26Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3056

AutorestCI · 2018-07-31T19:53:31Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-07-31T19:59:49Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmp2fimu42t/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmp2fimu42t/sdk', '--nodejs', '[email protected]/autorest.nodejs@^2.1.43']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.79)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down
FATAL: nodejs/generate - FAILED
FATAL: Error: Connection is closed.
Process() cancelled due to exception : Connection is closed.
  Error: Connection is closed.

AutorestCI · 2018-07-31T20:27:56Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpjqn1pa2t/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpjqn1pa2t/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '[email protected]/autorest.go@~2.1.109', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.109->2.1.110)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-06"} .
Shutting Down
Shutting Down
FATAL: go/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Failure during batch task - {"tag":"package-2018-06"} -- false.

AutorestCI · 2018-07-31T20:31:03Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

jianghaolu · 2018-08-01T23:07:58Z

...source-manager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyCreate.json

+           "provisioningState" : "Succeeded"
+           }
+          ]
+         },


Remove extra comma

jianghaolu · 2018-08-01T23:08:07Z

...source-manager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyCreate.json

+           "provisioningState" : "Succeeded"
+           }
+          ]
+         },


remove extra comma

jianghaolu · 2018-08-01T23:08:19Z

...ager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyDefinitionCreate.json

+        "/subscriptions/subid1/resourceGroups/storageRg",
+        "/subscriptions/subid1/resourceGroups/storageRg/providers/Microsoft.Storage/storageAccounts/stAccount"
+     ]
+    },


Remove extra comma

jianghaolu · 2018-08-01T23:08:28Z

...ager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyDefinitionCreate.json

+            "/subscriptions/subid1/resourceGroups/storageRg",
+            "/subscriptions/subid1/resourceGroups/storageRg/providers/Microsoft.Storage/storageAccounts/stAccount"
+         ]
+    },


jianghaolu · 2018-08-01T23:08:36Z

...ager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyDefinitionCreate.json

+            "/subscriptions/subid1/resourceGroups/storageRg",
+            "/subscriptions/subid1/resourceGroups/storageRg/providers/Microsoft.Storage/storageAccounts/stAccount"
+         ]
+        },


jianghaolu · 2018-08-01T23:08:48Z

...anager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyDefinitionList.json

+                "/subscriptions/subid1/resourceGroups/storageRg",
+                "/subscriptions/subid1/resourceGroups/storageRg/providers/Microsoft.Storage/storageAccounts/stAccount"
+             ]
+            },


jianghaolu · 2018-08-01T23:10:15Z

...tion/network/resource-manager/Microsoft.Network/stable/2018-07-01/serviceEndpointPolicy.json

+        "tags": [
+          "ServiceEndpointPolicies"
+        ],
+        "operationId": "ServiceEndpointPolicies_ListAll",


This method should be called "List"

jianghaolu · 2018-08-01T23:10:30Z

...tion/network/resource-manager/Microsoft.Network/stable/2018-07-01/serviceEndpointPolicy.json

+        "tags": [
+          "serviceEndpointPolicies"
+        ],
+        "operationId": "serviceEndpointPolicies_List",


This should be called "ListByResourceGroup"

jianghaolu · 2018-08-02T00:12:46Z

@chandrasekarsrinivasan Can you push your fixes?

Also you need to sync with Network-August-Release branch?

chandrasekarsrinivasan · 2018-08-02T00:32:38Z

I pushed the fixes. Also, yes, I need this on network-august-release

jianghaolu · 2018-08-02T00:44:17Z

@chandrasekarsrinivasan I meant that you have to pull from Network-August-Release.

chandrasekarsrinivasan · 2018-08-02T00:59:48Z

Yes, I already pulled. I pulled again now.

jianghaolu · 2018-08-02T01:06:11Z

...tion/network/resource-manager/Microsoft.Network/stable/2018-07-01/serviceEndpointPolicy.json

+            "description": "The name of the resource group."
+          },
+          {
+            "name": "ServiceEndpointPolicyName",


Should be "serviceEndpointPolicyName"

jianghaolu · 2018-08-02T22:59:28Z

...tion/network/resource-manager/Microsoft.Network/stable/2018-07-01/serviceEndpointPolicy.json

+        "x-ms-long-running-operation": true
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/serviceEndpointPolicies/{ServiceEndpointPolicyName}/serviceEndpointPolicyDefinitions": {


{ServiceEndpointPolicyName} should be {serviceEndpointPolicyName}

jianghaolu · 2018-08-03T18:12:04Z

.../resource-manager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyGet.json

+                "/subscriptions/subid1/resourceGroups/storageRg/providers/Microsoft.Storage/storageAccounts/stAccount"
+             ]
+            },
+           "provisioningState" : "Succeeded"


provisioningState is not defined in the ServiceEndpointPolicyDefinition definition

jianghaolu · 2018-08-03T18:18:38Z

...source-manager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyCreate.json

@@ -0,0 +1,63 @@
+{
+  "parameters" : {


Missing parameter serviceEndpointPolicyName

jianghaolu · 2018-08-03T18:19:01Z

...source-manager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyCreate.json

+                "/subscriptions/subid1/resourceGroups/storageRg/providers/Microsoft.Storage/storageAccounts/stAccount"
+             ]
+            },
+           "provisioningState" : "Succeeded"


jianghaolu · 2018-08-03T18:19:14Z

...source-manager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyCreate.json

+                "/subscriptions/subid1/resourceGroups/storageRg/providers/Microsoft.Storage/storageAccounts/stAccount"
+             ]
+            },
+           "provisioningState" : "Succeeded"


jianghaolu · 2018-08-03T18:19:35Z

...ource-manager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyListAll.json

+                    "/subscriptions/subid1/resourceGroups/storageRg/providers/Microsoft.Storage/storageAccounts/stAccount"
+                 ]
+                },
+               "provisioningState" : "Succeeded"


jianghaolu · 2018-08-03T18:19:52Z

...ource-manager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyListAll.json

+                    "/subscriptions/subid1/resourceGroups/storageRg/providers/Microsoft.Storage/storageAccounts/stAccount"
+                 ]
+                },
+               "provisioningState" : "Succeeded"


Same - you probably missed defining it in your spec?

jianghaolu · 2018-08-03T18:20:25Z

...manager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyDefinitionGet.json

@@ -0,0 +1,28 @@
+{
+  "parameters" : {


Missing parameter serviceEndpointPolicyName

jianghaolu · 2018-08-03T18:22:46Z

...manager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyDefinitionGet.json

+          "destinationAddressPrefix": "*",
+          "access": "Allow",
+          "priority": 130,
+          "direction": "Inbound"


Additional properties not allowed:
direction,priority,access,destinationAddressPrefix,sourceAddressPrefix,destinationPortRange,sourcePortRange,protocol are not defined in ServiceEndpointPolicyDefinition

jianghaolu · 2018-08-03T18:26:48Z

...ager/Microsoft.Network/stable/2018-07-01/examples/ServiceEndpointPolicyDefinitionCreate.json

+    "resourceGroupName" : "rg1",
+    "serviceEndpointPolicyName" : "testPolicy",
+    "serviceEndpointPolicyDefinitionName": "testDefinition",
+    "properties": {


wrap this in ServiceEndpointPolicyDefinitionParameters

jianghaolu · 2018-08-03T18:27:31Z

...tion/network/resource-manager/Microsoft.Network/stable/2018-07-01/serviceEndpointPolicy.json

+            "description": "The name of the service endpoint policy definition name."
+          },
+          {
+            "name": "ServiceEndpointPolicyDefinitionParameters",


BTW parameter names should be camel cased. I missed this earlier my bad

* Created folder for 2018-07-01 api version (#3509) * Created folder for 2018-07-01 api version * fixed incorrect encoding symbol * Fix lint diff and improve output on failure (#3528) Lint diff was failing on PRs with a base branch other than master. We needed to fetch the base branch ref from the origin before trying to resolve it to its commit hash. * Python conf for Network 2018-06 (#3535) * Py conf for Network 2018-07-01 (#3539) * Introduce Publicipprefix to swagger (#3520) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Publicipprefixaugust (#3573) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Service Endpoint Policies Swagger (#3558) * Service Endpoint Policies Swagger * Fix review comments * Updated Network Usage location parameter pattern (#3583) * Add enableTcpReset property to load balancer (#3545) * Add enableTcpReset property to load balancer. * Update loadbalancer examples with enableTcpReset. * added global reach flag (#3542) * fix query packet capture status in latest version (#3601) * Publicipprefixaugust (#3618) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Publicipprefixaugust (#3631) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Add PublicIpPrefix Subresource to VirtualMachineScaleSetPublicIPAddressConfigurationProperties * Changes to Support MSEEv2 Datapath for ExpressRoute. (#3647) Description of Changes: - Added a flag expressRouteGatewayBypass to the Connection Properties. - The user can set the flag to True to use MSEEv2 datapath Related work items: #2628003 * Added new API to networkwatcher.json and examples (#3650) * Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * Fix name from ServiceEndpointDefinition to ServiceEndpointDefinitions while doing a put, get and delete (#3655) * Add/Edit Outbound Rule on Load Balancer and Examples (#3592) * Add/Edit Outbound Rule on Load Balancer and Examples * Adding properties enabletcpreset, idletimeoutinminutes and protocol * Adding a reference to Public IP Prefix * Dummy Commit * Removed QueryConnectionMOnitors API (#3661) * Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * removed QueryConnectionMonitors Api

chandrasekarsrinivasan requested review from DeepakRajendranMsft and MikhailTryakhov as code owners July 31, 2018 19:47

azuresdkci assigned jianghaolu Jul 31, 2018

azuresdkci requested a review from jianghaolu July 31, 2018 19:47

chandrasekarsrinivasan force-pushed the Network-August-Release_07 branch 2 times, most recently from 93e969a to 9b76dd2 Compare July 31, 2018 21:29

This was referenced Jul 31, 2018

[AutoPR network/resource-manager] Service Endpoint Policies Swagger Azure/azure-sdk-for-python#3056

Merged

[AutoPR network/resource-manager] Service Endpoint Policies Swagger Azure/azure-sdk-for-node#3274

Closed

jianghaolu added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 1, 2018

jianghaolu suggested changes Aug 1, 2018

View reviewed changes

Service Endpoint Policies Swagger

b4ca3e6

chandrasekarsrinivasan force-pushed the Network-August-Release_07 branch from 8624f15 to 6a5c166 Compare August 2, 2018 00:46

jianghaolu suggested changes Aug 2, 2018

View reviewed changes

chandrasekarsrinivasan force-pushed the Network-August-Release_07 branch from 6a5c166 to cc40a2c Compare August 2, 2018 14:24

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 2, 2018

jianghaolu suggested changes Aug 2, 2018

View reviewed changes

chandrasekarsrinivasan force-pushed the Network-August-Release_07 branch from cc40a2c to b7bdcc1 Compare August 2, 2018 23:04

jianghaolu suggested changes Aug 3, 2018

View reviewed changes

Fix review comments

6d2f752

chandrasekarsrinivasan force-pushed the Network-August-Release_07 branch from b7bdcc1 to 6d2f752 Compare August 3, 2018 20:12

jianghaolu approved these changes Aug 3, 2018

View reviewed changes

Merge branch 'Network-August-Release' into Network-August-Release_07

a590e55

jianghaolu merged commit 65683a8 into Azure:Network-August-Release Aug 3, 2018

Service Endpoint Policies Swagger #3558

Service Endpoint Policies Swagger #3558

Conversation

chandrasekarsrinivasan commented Jul 31, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

azuresdkci commented Jul 31, 2018

AutorestCI commented Jul 31, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 31, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jul 31, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jul 31, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jul 31, 2018 • edited Loading

Automation for azure-sdk-for-java

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jianghaolu commented Aug 2, 2018

chandrasekarsrinivasan commented Aug 2, 2018

jianghaolu commented Aug 2, 2018

chandrasekarsrinivasan commented Aug 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chandrasekarsrinivasan commented Jul 31, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jul 31, 2018 •

edited

Loading

AutorestCI commented Jul 31, 2018 •

edited

Loading

AutorestCI commented Jul 31, 2018 •

edited

Loading

AutorestCI commented Jul 31, 2018 •

edited

Loading

AutorestCI commented Jul 31, 2018 •

edited

Loading