Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Azure / azure-rest-api-specs Public

Notifications You must be signed in to change notification settings
Fork 5.2k
Star 2.7k

Code
Issues 1.7k
Pull requests 798
Discussions
Actions
Projects
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick fix for linter into "Network-August-Release" #3528

Merged

dsgouda merged 1 commit into Azure:Network-August-Release from anton-evseev:build-fix-cherry-pick

Jul 27, 2018

Merged

Cherry pick fix for linter into "Network-August-Release" #3528

dsgouda merged 1 commit into Azure:Network-August-Release from anton-evseev:build-fix-cherry-pick

Jul 27, 2018

Conversation 6 Commits 1 Checks 0 Files changed

Conversation

Copy link

Contributor

anton-evseev commented Jul 27, 2018 •

edited

Loading

Cherry picked fix for failing builds (like in those PRs: #3509, #3520).

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Sorry, something went wrong.

All reactions


          Fix lint diff and improve output on failure

0ee1542

Lint diff was failing on PRs with a base branch other than master. We
needed to fetch the base branch ref from the origin before trying to
resolve it to its commit hash.

Copy link

AutorestCI commented Jul 27, 2018 •

edited

Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

Copy link

AutorestCI commented Jul 27, 2018 •

edited

Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

Copy link

AutorestCI commented Jul 27, 2018 •

edited

Loading

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

Copy link

AutorestCI commented Jul 27, 2018 •

edited

Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

Copy link

AutorestCI commented Jul 27, 2018 •

edited

Loading

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

dsgouda approved these changes

View reviewed changes

Copy link

Contributor

dsgouda left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

All reactions

dsgouda merged commit a09c1b7 into Azure:Network-August-Release

anton-evseev deleted the build-fix-cherry-pick branch

July 30, 2018 05:59

jianghaolu pushed a commit that referenced this pull request


          Azure Network August release (#3635)

c9d1315

* Created folder for 2018-07-01 api version (#3509)

* Created folder for 2018-07-01 api version

* fixed incorrect encoding symbol

* Fix lint diff and improve output on failure (#3528)

Lint diff was failing on PRs with a base branch other than master. We
needed to fetch the base branch ref from the origin before trying to
resolve it to its commit hash.

* Python conf for Network 2018-06 (#3535)

* Py conf for Network 2018-07-01 (#3539)

* Introduce Publicipprefix to swagger (#3520)

* Add PublicIpPrefix

* Add PublicIpPrefix

* Add PublicIpPrefix

* Move to 2018-07-01 branch

* revertversionchange

* Fix Syntax error

* Fix IpTag description because evidently everything is global

* Fix $ref for PublicIpPrefix

* Fix Casing

* Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel

* Fix Version#

* Fix Examples

* Publicipprefixaugust (#3573)

* Add PublicIpPrefix

* Add PublicIpPrefix

* Add PublicIpPrefix

* Move to 2018-07-01 branch

* revertversionchange

* Fix Syntax error

* Fix IpTag description because evidently everything is global

* Fix $ref for PublicIpPrefix

* Fix Casing

* Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel

* Fix Version#

* Fix Examples

* Remove IdleTimeout parameter

* Fix comma

* Service Endpoint Policies Swagger (#3558)

* Service Endpoint Policies Swagger

* Fix review comments

* Updated Network Usage location parameter pattern (#3583)

* Add enableTcpReset property to load balancer (#3545)

* Add enableTcpReset property to load balancer.

* Update loadbalancer examples with enableTcpReset.

* added global reach flag (#3542)

* fix query packet capture status in latest version (#3601)

* Publicipprefixaugust (#3618)

* Add PublicIpPrefix

* Add PublicIpPrefix

* Add PublicIpPrefix

* Move to 2018-07-01 branch

* revertversionchange

* Fix Syntax error

* Fix IpTag description because evidently everything is global

* Fix $ref for PublicIpPrefix

* Fix Casing

* Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel

* Fix Version#

* Fix Examples

* Remove IdleTimeout parameter

* Fix comma

* Add PublicIpPrefix for PublicIpAddressConfiguration

* Fix PublicIPAddress to refer to PublicIpPrefix as SubResource

* Fix Comma

* Remove compute update

* Publicipprefixaugust (#3631)

* Add PublicIpPrefix

* Add PublicIpPrefix

* Add PublicIpPrefix

* Move to 2018-07-01 branch

* revertversionchange

* Fix Syntax error

* Fix IpTag description because evidently everything is global

* Fix $ref for PublicIpPrefix

* Fix Casing

* Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel

* Fix Version#

* Fix Examples

* Remove IdleTimeout parameter

* Fix comma

* Add PublicIpPrefix for PublicIpAddressConfiguration

* Fix PublicIPAddress to refer to PublicIpPrefix as SubResource

* Fix Comma

* Remove compute update

* Add PublicIpPrefix Subresource to VirtualMachineScaleSetPublicIPAddressConfigurationProperties

* Changes to Support MSEEv2 Datapath for ExpressRoute. (#3647)

Description of Changes:
    - Added a flag expressRouteGatewayBypass to the Connection
      Properties.
    - The user can set the flag to True to use MSEEv2 datapath

Related work items: #2628003

* Added new API to networkwatcher.json and examples (#3650)

* Added new API to networkwatcher.json and examples

* Added NetworkWatcherNetworkConfigurationDiagnostic example

* Fix name from ServiceEndpointDefinition to ServiceEndpointDefinitions while doing a put, get and delete (#3655)

* Add/Edit Outbound Rule on Load Balancer and Examples (#3592)

* Add/Edit Outbound Rule on Load Balancer and Examples

* Adding properties enabletcpreset, idletimeoutinminutes and protocol

* Adding a reference to Public IP Prefix

* Dummy Commit

* Removed QueryConnectionMOnitors API (#3661)

* Added new API to networkwatcher.json and examples

* Added NetworkWatcherNetworkConfigurationDiagnostic example

* removed QueryConnectionMonitors Api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dsgouda dsgouda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.