Fix foir Azure Networking swagger #3146

MikhailTryakhov · 2018-05-29T20:29:11Z

moved progress from 2018-05-01 to the April branch to unblock PS progress

* Created May folder. Updated version for exampls, commands * Updated package to May version * Returned NW examples * Fixed API version; Fixed NetworkWatcher examples * Fixed VPN Gateway/Connection examples * Add changes from PR#2975 https://github.com/Azure/azure-rest-api-specs/pull/2975/files

…nfig object for enhancing the Network Watcher cmdlets (Azure#3023) * Adding optional traffic analytics parameters with existing network watched flowlog configuration * Updating the version * Updating latest versoin in readme.md

* Adding optional traffic analytics parameters with existing network watched flowlog configuration * Updating the version * Updating latest versoin in readme.md * Adding optional traffic analytics parameters with flowlog parameters * Reverting old chnages

Expose new SKUs for VMSS VPN and ER gateways

* Initial network error fixes and suppressions * reworked exception to specified code blocks only * Added express route fixes

dsgouda

Please update the version in all examples
Also confirm what version the new APIs you plan to introduce are on (they cannot be on 2018-05-01).

AutorestCI · 2018-05-29T20:38:55Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#22

AutorestCI · 2018-05-29T20:43:25Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2610

AutorestCI · 2018-05-29T20:57:14Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2376

AutorestCI · 2018-05-29T20:58:11Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1327

lmazuel

Inconsistent folder and content

lmazuel · 2018-05-29T21:04:53Z

...ication/network/resource-manager/Microsoft.Network/stable/2018-04-01/applicationGateway.json

@@ -3,7 +3,7 @@
  "info": {
    "title": "NetworkManagementClient",
    "description": "The Microsoft Azure Network management API provides a RESTful set of web services that interact with Microsoft Azure Networks service to manage your network resources. The API has entities that capture the relationship between an end user and the Microsoft Azure Networks service.",
-    "version": "2018-04-01"
+    "version": "2018-05-01"


Does not make sense, if this is a new api, this is a new folder

AutorestCI · 2018-05-29T21:19:33Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1915

MikhailTryakhov · 2018-05-29T22:35:30Z

@dsgouda @lmazuel please review fixed api-version

dsgouda · 2018-05-29T22:36:55Z

specification/network/resource-manager/readme.md

-tag: package-2018-05
-```
-
-### Tag: package-2018-05


You can keep this tag, just default the tag back to package-2018-04

Let's publish it in May to avoid misunderstanding? :)

There is already a directory for May created in master. Wouldn't help just removing references here. Let's keep this as is and simply default the tag to April

dsgouda

There really shouldn't be any new changes introduced to the May directory here, can you explain where those come from?

dsgouda · 2018-05-29T22:39:27Z

...tion/network/resource-manager/Microsoft.Network/stable/2018-04-01/virtualNetworkGateway.json

-        "tags": [
-          "VirtualNetworkGateways"
-        ],
-        "operationId": "VirtualNetworkGateways_SetVpnclientIpsecParameters",


Can you confirm whether this API has been removed from the April version? At this point we should really be adding additive changes only

Yes, we had this discussion during approval. that's a private feature was accidently published earlier (and removed).

dsgouda · 2018-05-29T22:40:21Z

...ication/network/resource-manager/Microsoft.Network/stable/2018-05-01/applicationGateway.json

@@ -0,0 +1,2088 @@
+{
+  "swagger": "2.0",
+  "info": {


Why is this being added to the May folder

dsgouda · 2018-05-29T22:41:47Z

specification/network/resource-manager/readme.md

+## Suppression  
+``` yaml
+directive:
+  - suppress: RequiredPropertiesMissingInResourceModel


I'm confused, why are the suppressions a part of this PR?

dsgouda · 2018-05-29T22:52:21Z

@MikhailTryakhov Please update the PR with upstream changes

# Conflicts: # specification/network/resource-manager/readme.md

dsgouda · 2018-05-29T22:57:18Z

LGTM subject to CIs passing

MikhailTryakhov · 2018-05-29T23:09:31Z

Need @lmazuel approval please to be unblocked

* Use common Resource & Sku definitions in all Sql specs (#3134) * Use common Resource & Sku definitions * Don't use common Sku definition * Just use common SQL definitions * Fixed syntax error * Fixed another syntax error * Fixed sku ref error * Fixed syntax error in example * Fix Python conf of servermanager (#3140) * Fix ServerManager Py Conf (#3141) * Plug SwaggerToSdk to LogAnalyticsMgmt (#3142) * [Storage] Support Management policy on new api version 2018-03-01-preview (#3137) * [Storage] Add new API version 2018-03-01-preview * [Storage] Update rest version 2018-03-01-preview * [Storage] Support Management Policy * [Storage] Update since code review comments * Add Python conf * [Storage] Add managment policy doc link to policy description. * [Storage] modify as review comments * RSA key size examples, ECC descriptions (#3136) * RSA key size examples, ECC descriptions * remove preview changes for now * Added GroupType property in HybridWorkerGroup (#3132) * Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (#3102) * Watcher specs * using the same model for get/put input and output. * Fix storage Python conf (#3148) * Fix for Azure Networking swagger 2018-04-01 version (#3146)

* One file for server and db apis Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json * Add extended server auditing settings API * Fixed operation id. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Fixing examples of existing APIs and modifying blobAuditing Swagger file storageAccountAccessKey was removed from requests response, and examples were modified accordingly. * Remove description of predicateExpression related exceptions from old APIs description. Fixing a small issue for client readability. AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs. After this fix, predicateExpression related exceptions will not be mentioned on old APIs. * Moving files to preview/stable as appropriate. * Modifying swagger and examples of 2017 BlobAuditing APIs (#421) * 2017 Blob Auditing APIs - Swagger and examples. Modifying swagger and examples of 2017 blob auditing APIs. * Resetting examples of DatabaseBlobAuditing API to 2017 Resetting examples of DatabaseBlobAuditing API to 2017 * Fixing follwing comments Fixing follwing comments * Fixing build errors Fixing build errors * Fix build errors Fix build errors * Fixing comments fixing comments * Removed 2017 database API Removed 2017 database API * Revert "Fixing comments" This reverts commit c09f9f6. * Modifying description of APIs Modifying description of APIs after generating new swagger. * Modifying readme.md. Modifying readme.md. * Updating blobAuditing Json files. Updating blobAuditing Json files. * Temp change Temp change * Final commit Final commit * Fix Duplicated model name with non-identical definitions build error Fix Duplicated model name with non-identical definitions * Fix Duplicated model name with non-identical definitions build error This reverts commit 616851d and commits fixes. * Fix Automation Duplicated model name with non-identical definitions Fix Automation Duplicated model name with non-identical definitions * One file for server and db apis Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json * Add extended server auditing settings API * Fixed operation id. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Fixing examples of existing APIs and modifying blobAuditing Swagger file storageAccountAccessKey was removed from requests response, and examples were modified accordingly. * Remove description of predicateExpression related exceptions from old APIs description. Fixing a small issue for client readability. AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs. After this fix, predicateExpression related exceptions will not be mentioned on old APIs. * Moving files to preview/stable as appropriate. * Modifying swagger and examples of 2017 BlobAuditing APIs (#421) * 2017 Blob Auditing APIs - Swagger and examples. Modifying swagger and examples of 2017 blob auditing APIs. * Resetting examples of DatabaseBlobAuditing API to 2017 Resetting examples of DatabaseBlobAuditing API to 2017 * Fixing follwing comments Fixing follwing comments * Fixing build errors Fixing build errors * Fixing comments fixing comments * Removed 2017 database API Removed 2017 database API * Revert "Fixing comments" This reverts commit c09f9f6. * Modifying description of APIs Modifying description of APIs after generating new swagger. * Modifying readme.md. Modifying readme.md. * Updating blobAuditing Json files. Updating blobAuditing Json files. * Temp change Temp change * Final commit Final commit * Fix Python conf of servermanager (#3140) * Fix ServerManager Py Conf (#3141) * Plug SwaggerToSdk to LogAnalyticsMgmt (#3142) * [Storage] Support Management policy on new api version 2018-03-01-preview (#3137) * [Storage] Add new API version 2018-03-01-preview * [Storage] Update rest version 2018-03-01-preview * [Storage] Support Management Policy * [Storage] Update since code review comments * Add Python conf * [Storage] Add managment policy doc link to policy description. * [Storage] modify as review comments * RSA key size examples, ECC descriptions (#3136) * RSA key size examples, ECC descriptions * remove preview changes for now * Added GroupType property in HybridWorkerGroup (#3132) * Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (#3102) * Watcher specs * using the same model for get/put input and output. * Fix storage Python conf (#3148) * Fix for Azure Networking swagger 2018-04-01 version (#3146) * Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger (#3114) * Forecast Api swagger * consumption readme file update for the new swagger version * addressing review comment on adding nextLink * fixing build error * Addressed feedback on enum and fixed a typo * Stop using unobscured credentials * Fix Duplicated model name with non-identical definitions build error Fix Duplicated model name with non-identical definitions * Fix go tag for storage management plane 2018-03-02 api version (#3156) * Refactoring Job Definitions (#3116) * MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. (#3138) * Fix Python conf * Adding the VNET Rest APIs to 2017-12-01 version. Adding the VNET Rest APIs to 2017-12-01 version. * Add specs for machine learning services provider (#3135) * Add specs for machine learning services provider * Added python config to readme * Added repo generation for Python * Addressed feedback * Address more comments * Adding Security RP API swagger (#3144) * Reverted methods in vpn gateways. (#3163) * Fix Duplicated model name with non-identical definitions build error This reverts commit 616851d and commits fixes. * Fix Automation Duplicated model name with non-identical definitions Fix Automation Duplicated model name with non-identical definitions * Revert "Fix Duplicated model name with non-identical definitions build error" This reverts commit d1c40f7. * Revert "Fix Duplicated model name with non-identical definitions build error" This reverts commit 2c1261e. * Update readme.md file Update readme.md file

* Fix ASE instance metrics url * Add java multi-api sections in select readme files * Add java multi api to network (temporary) * Add Java multi api to resources * Fix readme for Java in media * Add web app multiapi * Add multi api for web app and network * sync with master (#3153) * Use common Resource & Sku definitions in all Sql specs (#3134) * Use common Resource & Sku definitions * Don't use common Sku definition * Just use common SQL definitions * Fixed syntax error * Fixed another syntax error * Fixed sku ref error * Fixed syntax error in example * Fix Python conf of servermanager (#3140) * Fix ServerManager Py Conf (#3141) * Plug SwaggerToSdk to LogAnalyticsMgmt (#3142) * [Storage] Support Management policy on new api version 2018-03-01-preview (#3137) * [Storage] Add new API version 2018-03-01-preview * [Storage] Update rest version 2018-03-01-preview * [Storage] Support Management Policy * [Storage] Update since code review comments * Add Python conf * [Storage] Add managment policy doc link to policy description. * [Storage] modify as review comments * RSA key size examples, ECC descriptions (#3136) * RSA key size examples, ECC descriptions * remove preview changes for now * Added GroupType property in HybridWorkerGroup (#3132) * Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (#3102) * Watcher specs * using the same model for get/put input and output. * Fix storage Python conf (#3148) * Fix for Azure Networking swagger 2018-04-01 version (#3146) * Adding storage 2018-03-01-preview to java multi-api section (#3155) * readme for resource,keyvault,web * Fix keyvault namespace * Fix keyvault,dns, add storage 2016-01-01 * Fix web and storage multi api config * Add java multi api for authorization, iotcentral, keyvault, resources * Add policyinsights and fconfig to resources * Fix web app output path * Multiapibatch (#3205) * Change all existing ##Java sections * Add java multi api sections * Use azure-sdk-for-java repo * Fix typo in batch readme

EvgenyAgafonchikov and others added 7 commits May 7, 2018 16:18

#AppGw Fundamentals Clean Up (Azure#3046)

cea91ef

Expose new SKUs for VMSS VPN and ER gateways (Azure#3069)

c8aea94

Expose new SKUs for VMSS VPN and ER gateways

Initial network error fixes and suppressions (Azure#3051)

6f5c90a

* Initial network error fixes and suppressions * reworked exception to specified code blocks only * Added express route fixes

moved 2018-05-01 progress to April folder

5f0be8e

MikhailTryakhov requested a review from DeepakRajendranMsft as a code owner May 29, 2018 20:29

MikhailTryakhov requested review from dsgouda and salameer May 29, 2018 20:29

azuresdkci assigned lmazuel May 29, 2018

azuresdkci requested a review from lmazuel May 29, 2018 20:33

dsgouda suggested changes May 29, 2018

View reviewed changes

AutorestCI mentioned this pull request May 29, 2018

[AutoPR network/resource-manager] Fix foir Azure Networking swagger AutorestCI/azure-libraries-for-java#202

Merged

AutorestCI mentioned this pull request May 29, 2018

[AutoPR network/resource-manager] Fix foir Azure Networking swagger Azure/azure-sdk-for-python#2652

Merged

AutorestCI mentioned this pull request May 29, 2018

[AutoPR network/resource-manager] Fix foir Azure Networking swagger Azure/azure-sdk-for-ruby#1325

Merged

lmazuel requested changes May 29, 2018

View reviewed changes

AutorestCI mentioned this pull request May 29, 2018

[AutoPR network/resource-manager] Fix foir Azure Networking swagger Azure/azure-sdk-for-go#1914

Merged

fixed api-version to the april one

edb1d9d

MikhailTryakhov force-pushed the Network-fix-april branch from 087118d to edb1d9d Compare May 29, 2018 22:32

Fixed readme.md

292071d

dsgouda reviewed May 29, 2018

View reviewed changes

dsgouda suggested changes May 29, 2018

View reviewed changes

fixed readme extra-revertion

f77897b

Merge branch 'master' into Network-fix-april

5e5dc68

# Conflicts: # specification/network/resource-manager/readme.md

dsgouda approved these changes May 29, 2018

View reviewed changes

AutorestCI mentioned this pull request May 29, 2018

[AutoPR network/resource-manager] Fix foir Azure Networking swagger Azure/azure-sdk-for-node#2922

Merged

lmazuel approved these changes May 29, 2018

View reviewed changes

dsgouda merged commit 5a7197f into Azure:master May 29, 2018

anton-evseev mentioned this pull request May 30, 2018

Re-generated Network SDK based on master branch Azure/azure-sdk-for-net#4381

Merged

9 tasks

MikhailTryakhov deleted the Network-fix-april branch June 1, 2018 23:33

bashahee pushed a commit that referenced this pull request Jun 3, 2018

Fix for Azure Networking swagger 2018-04-01 version (#3146)

704b9ef

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix foir Azure Networking swagger #3146

Fix foir Azure Networking swagger #3146

MikhailTryakhov commented May 29, 2018 •

edited by azuresdkci

Loading

dsgouda left a comment

AutorestCI commented May 29, 2018 •

edited

Loading

AutorestCI commented May 29, 2018 •

edited

Loading

AutorestCI commented May 29, 2018 •

edited

Loading

AutorestCI commented May 29, 2018 •

edited

Loading

lmazuel left a comment

lmazuel May 29, 2018

AutorestCI commented May 29, 2018 •

edited

Loading

MikhailTryakhov commented May 29, 2018

dsgouda May 29, 2018

MikhailTryakhov May 29, 2018

dsgouda May 29, 2018

MikhailTryakhov May 29, 2018

dsgouda left a comment

dsgouda May 29, 2018

MikhailTryakhov May 29, 2018

dsgouda May 29, 2018

dsgouda May 29, 2018

dsgouda commented May 29, 2018

dsgouda commented May 29, 2018

MikhailTryakhov commented May 29, 2018

Fix foir Azure Networking swagger #3146

Fix foir Azure Networking swagger #3146

Conversation

MikhailTryakhov commented May 29, 2018 • edited by azuresdkci Loading

dsgouda left a comment

Choose a reason for hiding this comment

AutorestCI commented May 29, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented May 29, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented May 29, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 29, 2018 • edited Loading

Automation for azure-sdk-for-ruby

lmazuel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented May 29, 2018 • edited Loading

Automation for azure-sdk-for-go

MikhailTryakhov commented May 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsgouda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsgouda commented May 29, 2018

dsgouda commented May 29, 2018

MikhailTryakhov commented May 29, 2018

MikhailTryakhov commented May 29, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 29, 2018 •

edited

Loading

AutorestCI commented May 29, 2018 •

edited

Loading

AutorestCI commented May 29, 2018 •

edited

Loading

AutorestCI commented May 29, 2018 •

edited

Loading

AutorestCI commented May 29, 2018 •

edited

Loading